All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI
Date: Wed, 12 Jul 2017 15:18:12 +0800	[thread overview]
Message-ID: <20170712071811.GI3172@dragon> (raw)
In-Reply-To: <20170701073911.7338-1-mindentropy@gmail.com>

On Sat, Jul 01, 2017 at 01:09:11PM +0530, mindentropy wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
> 
>  * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
>    should be 2.8V but the voltage provided is a maximum of 3.3V and
>    minimum of 1.8V. Providing such a higher voltage might damage the
>    peripherals and violates the schematic settings.

For such single paragraph commit log, the bullet and indentation are not
really necessary.  I edited it a bit and apply the patch.  Thanks.

Shawn

> 
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
> ---
> Changes in v2:
>  - Added subject line according to convention
> 
>  arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index 5be01a1bf840..1da1f97ec342 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -262,8 +262,8 @@
>  			};
>  
>  			vgen6_reg: vldo4 {
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <3300000>;
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
>  				regulator-always-on;
>  			};
>  		};
> -- 
> 2.11.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: mindentropy <mindentropy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI
Date: Wed, 12 Jul 2017 15:18:12 +0800	[thread overview]
Message-ID: <20170712071811.GI3172@dragon> (raw)
In-Reply-To: <20170701073911.7338-1-mindentropy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Sat, Jul 01, 2017 at 01:09:11PM +0530, mindentropy wrote:
> From: Gautam Bhat <mindentropy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
>  * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
>    should be 2.8V but the voltage provided is a maximum of 3.3V and
>    minimum of 1.8V. Providing such a higher voltage might damage the
>    peripherals and violates the schematic settings.

For such single paragraph commit log, the bullet and indentation are not
really necessary.  I edited it a bit and apply the patch.  Thanks.

Shawn

> 
> Signed-off-by: Gautam Bhat <mindentropy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> Changes in v2:
>  - Added subject line according to convention
> 
>  arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index 5be01a1bf840..1da1f97ec342 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -262,8 +262,8 @@
>  			};
>  
>  			vgen6_reg: vldo4 {
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <3300000>;
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
>  				regulator-always-on;
>  			};
>  		};
> -- 
> 2.11.0
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: mindentropy <mindentropy@gmail.com>
Cc: festevam@gmail.com, Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI
Date: Wed, 12 Jul 2017 15:18:12 +0800	[thread overview]
Message-ID: <20170712071811.GI3172@dragon> (raw)
In-Reply-To: <20170701073911.7338-1-mindentropy@gmail.com>

On Sat, Jul 01, 2017 at 01:09:11PM +0530, mindentropy wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
> 
>  * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
>    should be 2.8V but the voltage provided is a maximum of 3.3V and
>    minimum of 1.8V. Providing such a higher voltage might damage the
>    peripherals and violates the schematic settings.

For such single paragraph commit log, the bullet and indentation are not
really necessary.  I edited it a bit and apply the patch.  Thanks.

Shawn

> 
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
> ---
> Changes in v2:
>  - Added subject line according to convention
> 
>  arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index 5be01a1bf840..1da1f97ec342 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -262,8 +262,8 @@
>  			};
>  
>  			vgen6_reg: vldo4 {
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <3300000>;
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
>  				regulator-always-on;
>  			};
>  		};
> -- 
> 2.11.0
> 

  parent reply	other threads:[~2017-07-12  7:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 17:45 [PATCH] Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI mindentropy
2017-06-28 17:45 ` mindentropy
2017-06-28 17:45 ` mindentropy
2017-06-28 20:19 ` Fabio Estevam
2017-06-28 20:19   ` Fabio Estevam
2017-06-28 20:19   ` Fabio Estevam
2017-07-01  7:39   ` [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to " mindentropy
2017-07-01  7:39     ` mindentropy
2017-07-01  7:39     ` mindentropy
2017-07-01 12:41     ` Fabio Estevam
2017-07-01 12:41       ` Fabio Estevam
2017-07-01 12:41       ` Fabio Estevam
2017-07-12  7:18     ` Shawn Guo [this message]
2017-07-12  7:18       ` Shawn Guo
2017-07-12  7:18       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712071811.GI3172@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.