From: Stephen Boyd <sboyd@codeaurora.org>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-clk@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Alexey Firago <alexey_firago@mentor.com>,
Michael Turquette <mturquette@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V3 4/8] clk: vc5: Configure the output buffer input mux on prepare
Date: Wed, 12 Jul 2017 16:10:22 -0700 [thread overview]
Message-ID: <20170712231022.GJ22780@codeaurora.org> (raw)
In-Reply-To: <20170709132814.2339-4-marek.vasut+renesas@gmail.com>
On 07/09, Marek Vasut wrote:
> The output buffer input mux can be configured in either of three
> states -- disabled, input from FOD, input from previous output.
> Once the .prepare() callback of the output buffer is called, the
> output buffer input mux must be set to either input from FOD or
> input from previous output, it cannot be set to Disabled anymore
> or the output won't work.
>
> Default to the input from FOD if the output buffer input mux was
> Disabled and the .prepare() was called on it.
>
> Note that we do not set the output buffer input mux back to Disabled
> in the .unprepare() callback as there is no obvious benefit of doing
> so. We disable the entire output buffer in the .unprepare() callback
> already.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Alexey Firago <alexey_firago@mentor.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-renesas-soc@vger.kernel.org
> Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> on Salvator-XS with the display LVDS output.
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-12 23:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 13:28 [PATCH V3 1/8] clk: vc5: Prevent division by zero on unconfigured outputs Marek Vasut
2017-07-09 13:28 ` [PATCH V3 2/8] clk: vc5: Fix trivial typo Marek Vasut
2017-07-12 23:10 ` Stephen Boyd
2017-07-09 13:28 ` [PATCH V3 3/8] clk: vc5: Do not warn about disabled output buffer input muxes Marek Vasut
2017-07-12 23:10 ` Stephen Boyd
2017-07-09 13:28 ` [PATCH V3 4/8] clk: vc5: Configure the output buffer input mux on prepare Marek Vasut
2017-07-12 23:10 ` Stephen Boyd [this message]
2017-07-09 13:28 ` [PATCH V3 5/8] clk: vc5: Split clock input mux and predivider Marek Vasut
2017-07-12 23:10 ` Stephen Boyd
2017-07-09 13:28 ` [PATCH V3 6/8] clk: vc5: Add support for the input frequency doubler Marek Vasut
2017-07-12 23:10 ` Stephen Boyd
2017-07-09 13:28 ` [PATCH V3 7/8] clk: vc5: Add bindings for IDT VersaClock 5P49V6901 Marek Vasut
2017-07-09 13:28 ` Marek Vasut
2017-07-12 23:10 ` Stephen Boyd
2017-07-09 13:28 ` [PATCH V3 8/8] clk: vc5: Add support " Marek Vasut
2017-07-12 23:10 ` Stephen Boyd
2017-07-12 23:10 ` [PATCH V3 1/8] clk: vc5: Prevent division by zero on unconfigured outputs Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712231022.GJ22780@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=alexey_firago@mentor.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.