All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH rfc 3/3] nvmet-rdma: assign cq completion vector based on the port allowed cpus
Date: Thu, 13 Jul 2017 19:24:37 +0200	[thread overview]
Message-ID: <20170713172437.GA5236@lst.de> (raw)
In-Reply-To: <C2439AB7-BC2E-4B71-87CA-3F8313282828@oracle.com>

On Thu, Jul 13, 2017@01:19:00PM -0400, Chuck Lever wrote:
> 
> > On Jul 13, 2017,@11:50 AM, Christoph Hellwig <hch@lst.de> wrote:
> > 
> > We really shouldn't be doing any of this in NVMe I think.  We'll need
> > to go back to the cq pool API first.  The last version I had was here:
> > 
> > 	http://git.infradead.org/users/hch/rdma.git/shortlog/refs/heads/rdma-cq
> > 
> > and then do the affinity in common code.
> 
> This seems to address the problem I mentioned to you with properly
> estimating send CQ size when using the rdma_rw API. If these are
> going to be merged soon, I can drop the new API I proposed here:
> 
> http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=commit;h=2156cb956101da854f64918066710ff4e7affc5b

I'd need to find time to get back to it, and I have a few big
chunks on my todo list.  Any chance you (or someone else interested)
could take the series over?

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	James Smart <james.smart-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Keith Busch <keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rfc 3/3] nvmet-rdma: assign cq completion vector based on the port allowed cpus
Date: Thu, 13 Jul 2017 19:24:37 +0200	[thread overview]
Message-ID: <20170713172437.GA5236@lst.de> (raw)
In-Reply-To: <C2439AB7-BC2E-4B71-87CA-3F8313282828-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

On Thu, Jul 13, 2017 at 01:19:00PM -0400, Chuck Lever wrote:
> 
> > On Jul 13, 2017, at 11:50 AM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
> > 
> > We really shouldn't be doing any of this in NVMe I think.  We'll need
> > to go back to the cq pool API first.  The last version I had was here:
> > 
> > 	http://git.infradead.org/users/hch/rdma.git/shortlog/refs/heads/rdma-cq
> > 
> > and then do the affinity in common code.
> 
> This seems to address the problem I mentioned to you with properly
> estimating send CQ size when using the rdma_rw API. If these are
> going to be merged soon, I can drop the new API I proposed here:
> 
> http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=commit;h=2156cb956101da854f64918066710ff4e7affc5b

I'd need to find time to get back to it, and I have a few big
chunks on my todo list.  Any chance you (or someone else interested)
could take the series over?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-07-13 17:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 15:01 [PATCH rfc 0/3] Expose cpu mapping hints to a nvme target port Sagi Grimberg
2017-07-02 15:01 ` Sagi Grimberg
2017-07-02 15:01 ` [PATCH rfc 1/3] nvmet: allow assignment of a cpulist for each nvmet port Sagi Grimberg
2017-07-02 15:01   ` Sagi Grimberg
2017-07-02 15:01 ` [PATCH rfc 2/3] RDMA/core: expose cpu affinity based completion vector lookup Sagi Grimberg
2017-07-02 15:01   ` Sagi Grimberg
2017-07-13 15:50   ` Christoph Hellwig
2017-07-13 15:50     ` Christoph Hellwig
2017-07-13 16:30     ` Sagi Grimberg
2017-07-13 16:30       ` Sagi Grimberg
2017-07-02 15:01 ` [PATCH rfc 3/3] nvmet-rdma: assign cq completion vector based on the port allowed cpus Sagi Grimberg
2017-07-02 15:01   ` Sagi Grimberg
2017-07-13 15:50   ` Christoph Hellwig
2017-07-13 15:50     ` Christoph Hellwig
2017-07-13 16:37     ` Sagi Grimberg
2017-07-13 16:37       ` Sagi Grimberg
2017-07-13 17:16       ` Christoph Hellwig
2017-07-13 17:16         ` Christoph Hellwig
2017-07-13 17:19     ` Chuck Lever
2017-07-13 17:19       ` Chuck Lever
2017-07-13 17:24       ` Christoph Hellwig [this message]
2017-07-13 17:24         ` Christoph Hellwig
2017-07-13 17:31         ` Chuck Lever
2017-07-13 17:31           ` Chuck Lever
2017-07-02 16:30 ` [PATCH rfc 0/3] Expose cpu mapping hints to a nvme target port Max Gurtovoy
2017-07-02 16:30   ` Max Gurtovoy
2017-07-02 17:41   ` Sagi Grimberg
2017-07-02 17:41     ` Sagi Grimberg
2017-07-03  9:52     ` Max Gurtovoy
2017-07-03  9:52       ` Max Gurtovoy
2017-07-03 10:14       ` Sagi Grimberg
2017-07-03 10:14         ` Sagi Grimberg
2017-07-10  6:08 ` Sagi Grimberg
2017-07-10  6:08   ` Sagi Grimberg
2017-07-11  7:27   ` Leon Romanovsky
2017-07-11  7:27     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713172437.GA5236@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.