* [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc @ 2017-07-13 4:03 Matt Weber 2017-07-13 4:07 ` Baruch Siach 0 siblings, 1 reply; 6+ messages in thread From: Matt Weber @ 2017-07-13 4:03 UTC (permalink / raw) To: buildroot Fixes a missing include of signal.h This breaks when building gcc 5.4.0 with target_platform=powerpc-unknown-linux-gnu with glibc 2.25: ../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)': ../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope return signum == SIGSEGV && common_flags()->handle_segv; This applies only to gcc-5-branch, the code has been reworked for gcc 6. Resolves Bug: https://bugs.busybox.net/show_bug.cgi?id=10061 Upstream: https://patchwork.ozlabs.org/patch/725596/ Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> --- .../942-asan-fix-missing-include-signal-h.patch | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch diff --git a/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch b/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file mode 100644 index 0000000..2fbc497 --- /dev/null +++ b/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch @@ -0,0 +1,40 @@ +From patchwork Wed Feb 8 11:07:16 2017 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: 7bit +Subject: asan: fix missing include of signal.h +From: Rolf Eike Beer <eb@emlix.com> +X-Patchwork-Id: 725596 +Message-Id: <6824253.3U2boEivI2@devpool21> +To: gcc-patches at gcc.gnu.org +Date: Wed, 08 Feb 2017 12:07:16 +0100 + +>From 205aa8e97bab553e5e6fe45896325e97962de704 Mon Sep 17 00:00:00 2001 +From: Rolf Eike Beer <eb@emlix.com> +Date: Wed, 8 Feb 2017 11:42:52 +0100 +Subject: [PATCH] asan: fix missing include of signal.h + +This breaks when building gcc 5.4.0 with +target_platform=powerpc-unknown-linux-gnu with glibc 2.25: + +../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)': +../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope + return signum == SIGSEGV && common_flags()->handle_segv; + +This applies only to gcc-5-branch, the code has been reworked for gcc 6. +--- + libsanitizer/asan/asan_linux.cc | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/libsanitizer/asan/asan_linux.cc b/libsanitizer/asan/asan_linux.cc +index c504168..59087b9 100644 +--- a/libsanitizer/asan/asan_linux.cc ++++ b/libsanitizer/asan/asan_linux.cc +@@ -29,6 +29,7 @@ + #include <dlfcn.h> + #include <fcntl.h> + #include <pthread.h> ++#include <signal.h> + #include <stdio.h> + #include <unistd.h> + #include <unwind.h> -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc 2017-07-13 4:03 [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc Matt Weber @ 2017-07-13 4:07 ` Baruch Siach 2017-07-13 13:29 ` Matthew Weber 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2017-07-13 4:07 UTC (permalink / raw) To: buildroot Hi Matt, On Wed, Jul 12, 2017 at 11:03:39PM -0500, Matt Weber wrote: > Fixes a missing include of signal.h > > This breaks when building gcc 5.4.0 with > target_platform=powerpc-unknown-linux-gnu with glibc 2.25: > > ../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)': > ../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope > return signum == SIGSEGV && common_flags()->handle_segv; > > This applies only to gcc-5-branch, the code has been reworked for gcc 6. > > Resolves Bug: https://bugs.busybox.net/show_bug.cgi?id=10061 > > Upstream: https://patchwork.ozlabs.org/patch/725596/ Mentioning the Buildroot bugzilla issue that this patch fixes would be nice. > > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > --- > .../942-asan-fix-missing-include-signal-h.patch | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch > > diff --git a/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch b/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch > new file mode 100644 > index 0000000..2fbc497 > --- /dev/null > +++ b/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch > @@ -0,0 +1,40 @@ > +From patchwork Wed Feb 8 11:07:16 2017 > +Content-Type: text/plain; charset="utf-8" > +MIME-Version: 1.0 > +Content-Transfer-Encoding: 7bit > +Subject: asan: fix missing include of signal.h > +From: Rolf Eike Beer <eb@emlix.com> > +X-Patchwork-Id: 725596 > +Message-Id: <6824253.3U2boEivI2@devpool21> > +To: gcc-patches at gcc.gnu.org > +Date: Wed, 08 Feb 2017 12:07:16 +0100 > + > +>From 205aa8e97bab553e5e6fe45896325e97962de704 Mon Sep 17 00:00:00 2001 > +From: Rolf Eike Beer <eb@emlix.com> > +Date: Wed, 8 Feb 2017 11:42:52 +0100 > +Subject: [PATCH] asan: fix missing include of signal.h > + > +This breaks when building gcc 5.4.0 with > +target_platform=powerpc-unknown-linux-gnu with glibc 2.25: > + > +../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)': > +../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope > + return signum == SIGSEGV && common_flags()->handle_segv; > + > +This applies only to gcc-5-branch, the code has been reworked for gcc 6. Your sign-off is missing. > +--- > + libsanitizer/asan/asan_linux.cc | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/libsanitizer/asan/asan_linux.cc b/libsanitizer/asan/asan_linux.cc > +index c504168..59087b9 100644 > +--- a/libsanitizer/asan/asan_linux.cc > ++++ b/libsanitizer/asan/asan_linux.cc > +@@ -29,6 +29,7 @@ > + #include <dlfcn.h> > + #include <fcntl.h> > + #include <pthread.h> > ++#include <signal.h> > + #include <stdio.h> > + #include <unistd.h> > + #include <unwind.h> baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc 2017-07-13 4:07 ` Baruch Siach @ 2017-07-13 13:29 ` Matthew Weber 2017-07-13 17:33 ` Thomas Petazzoni 0 siblings, 1 reply; 6+ messages in thread From: Matthew Weber @ 2017-07-13 13:29 UTC (permalink / raw) To: buildroot Baruch, On Wed, Jul 12, 2017 at 11:07 PM, Baruch Siach <baruch@tkos.co.il> wrote: > > Hi Matt, > > On Wed, Jul 12, 2017 at 11:03:39PM -0500, Matt Weber wrote: > > Fixes a missing include of signal.h > > > > This breaks when building gcc 5.4.0 with > > target_platform=powerpc-unknown-linux-gnu with glibc 2.25: > > > > ../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)': > > ../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope > > return signum == SIGSEGV && common_flags()->handle_segv; > > > > This applies only to gcc-5-branch, the code has been reworked for gcc 6. > > > > Resolves Bug: https://bugs.busybox.net/show_bug.cgi?id=10061 > > > > Upstream: https://patchwork.ozlabs.org/patch/725596/ > > Mentioning the Buildroot bugzilla issue that this patch fixes would be nice. > > > > > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > > --- > > .../942-asan-fix-missing-include-signal-h.patch | 40 ++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > create mode 100644 package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch > > > > diff --git a/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch b/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch > > new file mode 100644 > > index 0000000..2fbc497 > > --- /dev/null > > +++ b/package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch > > @@ -0,0 +1,40 @@ > > +From patchwork Wed Feb 8 11:07:16 2017 > > +Content-Type: text/plain; charset="utf-8" > > +MIME-Version: 1.0 > > +Content-Transfer-Encoding: 7bit > > +Subject: asan: fix missing include of signal.h > > +From: Rolf Eike Beer <eb@emlix.com> > > +X-Patchwork-Id: 725596 > > +Message-Id: <6824253.3U2boEivI2@devpool21> > > +To: gcc-patches at gcc.gnu.org > > +Date: Wed, 08 Feb 2017 12:07:16 +0100 > > + > > +>From 205aa8e97bab553e5e6fe45896325e97962de704 Mon Sep 17 00:00:00 2001 > > +From: Rolf Eike Beer <eb@emlix.com> > > +Date: Wed, 8 Feb 2017 11:42:52 +0100 > > +Subject: [PATCH] asan: fix missing include of signal.h > > + > > +This breaks when building gcc 5.4.0 with > > +target_platform=powerpc-unknown-linux-gnu with glibc 2.25: > > + > > +../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)': > > +../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope > > + return signum == SIGSEGV && common_flags()->handle_segv; > > + > > +This applies only to gcc-5-branch, the code has been reworked for gcc 6. > > Your sign-off is missing. I had assumed if I used the patch as is I would leave it without mods. I can add the bug tracker url and my signed off. Thanks! > > > > +--- > > + libsanitizer/asan/asan_linux.cc | 1 + > > + 1 file changed, 1 insertion(+) > > + > > +diff --git a/libsanitizer/asan/asan_linux.cc b/libsanitizer/asan/asan_linux.cc > > +index c504168..59087b9 100644 > > +--- a/libsanitizer/asan/asan_linux.cc > > ++++ b/libsanitizer/asan/asan_linux.cc > > +@@ -29,6 +29,7 @@ > > + #include <dlfcn.h> > > + #include <fcntl.h> > > + #include <pthread.h> > > ++#include <signal.h> > > + #include <stdio.h> > > + #include <unistd.h> > > + #include <unwind.h> > > baruch > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - -- Matthew L Weber / Pr Software Engineer Airborne Information Systems / Security Systems and Software / Secure Platforms MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.com Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc 2017-07-13 13:29 ` Matthew Weber @ 2017-07-13 17:33 ` Thomas Petazzoni 2017-07-13 17:45 ` Matthew Weber 0 siblings, 1 reply; 6+ messages in thread From: Thomas Petazzoni @ 2017-07-13 17:33 UTC (permalink / raw) To: buildroot Hello, On Thu, 13 Jul 2017 08:29:32 -0500, Matthew Weber wrote: > > > +This applies only to gcc-5-branch, the code has been reworked for gcc 6. > > > > Your sign-off is missing. > > > I had assumed if I used the patch as is I would leave it without mods. > I can add the bug tracker url and my signed off. Please add your SoB and the bug tracker reference. Also, does this issue applies to gcc 4.9 as well ? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc 2017-07-13 17:33 ` Thomas Petazzoni @ 2017-07-13 17:45 ` Matthew Weber 2017-07-13 20:02 ` Matthew Weber 0 siblings, 1 reply; 6+ messages in thread From: Matthew Weber @ 2017-07-13 17:45 UTC (permalink / raw) To: buildroot Thomas, On Thu, Jul 13, 2017 at 12:33 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Thu, 13 Jul 2017 08:29:32 -0500, Matthew Weber wrote: > >> > > +This applies only to gcc-5-branch, the code has been reworked for gcc 6. >> > >> > Your sign-off is missing. >> >> >> I had assumed if I used the patch as is I would leave it without mods. >> I can add the bug tracker url and my signed off. > > Please add your SoB and the bug tracker reference. > > Also, does this issue applies to gcc 4.9 as well ? > I'll check, we were using earlier versions of 5.4 and the bump broke us. I'll find the point it was introduced and add a comment. Matt ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc 2017-07-13 17:45 ` Matthew Weber @ 2017-07-13 20:02 ` Matthew Weber 0 siblings, 0 replies; 6+ messages in thread From: Matthew Weber @ 2017-07-13 20:02 UTC (permalink / raw) To: buildroot Thomas, Baruch, On Thu, Jul 13, 2017 at 12:45 PM, Matthew Weber <matthew.weber@rockwellcollins.com> wrote: > Thomas, > > On Thu, Jul 13, 2017 at 12:33 PM, Thomas Petazzoni > <thomas.petazzoni@free-electrons.com> wrote: >> Hello, >> >> On Thu, 13 Jul 2017 08:29:32 -0500, Matthew Weber wrote: >> >>> > > +This applies only to gcc-5-branch, the code has been reworked for gcc 6. >>> > >>> > Your sign-off is missing. >>> >>> >>> I had assumed if I used the patch as is I would leave it without mods. >>> I can add the bug tracker url and my signed off. >> >> Please add your SoB and the bug tracker reference. >> >> Also, does this issue applies to gcc 4.9 as well ? >> > > I'll check, we were using earlier versions of 5.4 and the bump broke > us. I'll find the point it was introduced and add a comment. Superseded by: https://patchwork.ozlabs.org/patch/787965/ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-13 20:02 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-13 4:03 [Buildroot] [PATCH 1/1] br toolchain: gcc5.4 bugfix libsanitizer powerpc Matt Weber 2017-07-13 4:07 ` Baruch Siach 2017-07-13 13:29 ` Matthew Weber 2017-07-13 17:33 ` Thomas Petazzoni 2017-07-13 17:45 ` Matthew Weber 2017-07-13 20:02 ` Matthew Weber
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.