From: "Michael S. Tsirkin" <mst@redhat.com>
To: gengdongjiu <gengdongjiu@huawei.com>
Cc: peter.maydell@linaro.org, wuquanming@huawei.com, famz@redhat.com,
zhengqiang10@huawei.com, qemu-devel@nongnu.org,
Gaozhihui <zhihui.gao@huawei.com>,
qemu-arm@nongnu.org, james.morse@arm.com, huangshaoyu@huawei.com,
zhaoshenglong@huawei.com, imammedo@redhat.com,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros
Date: Thu, 13 Jul 2017 20:35:05 +0300 [thread overview]
Message-ID: <20170713203308-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <47cc803a-d1d9-da3b-43f9-31a54ce290e2@huawei.com>
On Thu, Jul 13, 2017 at 08:00:26PM +0800, gengdongjiu wrote:
> Laszlo, I pasted Michael's comments here, as shown below. Michael said the definition
> should use build_append_int_noprefix to add data. but I think it may not good, becuase
> the section "UEFI_CPER_SEC_PLATFORM_MEM" is runtime recorded as CPER,
One thing I wanted to understand is how are races avoided. E.g. what if
you are in the process of writing out CPER and guest reads it.
I tried to find where is this function writing CPER called and couldn't.
Can you clarify pls?
> not a ACPI/HEST
> table member, so it is not generated when system boot up. On the other hand,UEFI_CPER_SEC_PLATFORM_MEM
> definition is from UEFI spec 2.6, N.2.2 Section Descriptor: {0xA5BC1114, 0x6F64, 0x4EDE, {0xB8, 0x63, 0x3E, 0x83, 0xED, 0x7C, 0x83, 0xB1}}.
> if use build_append_int_noprefix to add, may confuse others.
Right but ACPI/HEST generation could use cleanup, and build_append_int_noprefix
would be a nice way to do it.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: gengdongjiu <gengdongjiu@huawei.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
imammedo@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
zhaoshenglong@huawei.com, peter.maydell@linaro.org,
qemu-arm@nongnu.org, james.morse@arm.com,
zhengqiang10@huawei.com, huangshaoyu@huawei.com,
wuquanming@huawei.com, Gaozhihui <zhihui.gao@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros
Date: Thu, 13 Jul 2017 20:35:05 +0300 [thread overview]
Message-ID: <20170713203308-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <47cc803a-d1d9-da3b-43f9-31a54ce290e2@huawei.com>
On Thu, Jul 13, 2017 at 08:00:26PM +0800, gengdongjiu wrote:
> Laszlo, I pasted Michael's comments here, as shown below. Michael said the definition
> should use build_append_int_noprefix to add data. but I think it may not good, becuase
> the section "UEFI_CPER_SEC_PLATFORM_MEM" is runtime recorded as CPER,
One thing I wanted to understand is how are races avoided. E.g. what if
you are in the process of writing out CPER and guest reads it.
I tried to find where is this function writing CPER called and couldn't.
Can you clarify pls?
> not a ACPI/HEST
> table member, so it is not generated when system boot up. On the other hand,UEFI_CPER_SEC_PLATFORM_MEM
> definition is from UEFI spec 2.6, N.2.2 Section Descriptor: {0xA5BC1114, 0x6F64, 0x4EDE, {0xB8, 0x63, 0x3E, 0x83, 0xED, 0x7C, 0x83, 0xB1}}.
> if use build_append_int_noprefix to add, may confuse others.
Right but ACPI/HEST generation could use cleanup, and build_append_int_noprefix
would be a nice way to do it.
--
MST
next prev parent reply other threads:[~2017-07-13 17:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 2:08 [Qemu-arm] [PATCH v5 0/3] Generate APEI GHES table and dynamically record CPER Dongjiu Geng
2017-07-12 2:08 ` [Qemu-devel] " Dongjiu Geng
2017-07-12 2:08 ` [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros Dongjiu Geng
2017-07-12 2:08 ` Dongjiu Geng
2017-07-13 10:33 ` [Qemu-arm] " Laszlo Ersek
2017-07-13 10:33 ` Laszlo Ersek
2017-07-13 12:00 ` [Qemu-arm] " gengdongjiu
2017-07-13 12:00 ` gengdongjiu
2017-07-13 15:33 ` [Qemu-arm] " Laszlo Ersek
2017-07-13 15:33 ` Laszlo Ersek
2017-07-13 17:13 ` [Qemu-arm] " Michael S. Tsirkin
2017-07-13 17:13 ` Michael S. Tsirkin
2017-07-14 8:25 ` [Qemu-arm] " gengdongjiu
2017-07-14 8:25 ` gengdongjiu
2017-07-13 17:35 ` Michael S. Tsirkin [this message]
2017-07-13 17:35 ` Michael S. Tsirkin
2017-07-13 17:01 ` [Qemu-arm] " Michael S. Tsirkin
2017-07-13 17:01 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-14 5:51 ` [Qemu-arm] " gengdongjiu
2017-07-14 5:51 ` [Qemu-devel] " gengdongjiu
2017-07-13 17:11 ` [Qemu-arm] " Michael S. Tsirkin
2017-07-13 17:11 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-14 8:22 ` [Qemu-arm] " gengdongjiu
2017-07-14 8:22 ` [Qemu-devel] " gengdongjiu
2017-07-12 2:08 ` [Qemu-arm] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support Dongjiu Geng
2017-07-12 2:08 ` [Qemu-devel] " Dongjiu Geng
2017-07-13 17:32 ` [Qemu-arm] " Michael S. Tsirkin
2017-07-13 17:32 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-13 19:41 ` [Qemu-arm] " Laszlo Ersek
2017-07-13 19:41 ` [Qemu-devel] " Laszlo Ersek
2017-07-13 22:31 ` [Qemu-arm] " Michael S. Tsirkin
2017-07-13 22:31 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-17 4:43 ` [Qemu-arm] " gengdongjiu
2017-07-17 4:43 ` [Qemu-devel] " gengdongjiu
2017-07-12 2:08 ` [Qemu-devel] [PATCH v5 3/3] ACPI: build and enable APEI GHES in the Makefile and configuration Dongjiu Geng
2017-07-12 2:08 ` Dongjiu Geng
2017-07-13 17:36 ` [Qemu-arm] [PATCH v5 0/3] Generate APEI GHES table and dynamically record CPER Michael S. Tsirkin
2017-07-13 17:36 ` [Qemu-devel] " Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2017-07-15 0:14 [Qemu-arm] [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713203308-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=famz@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=huangshaoyu@huawei.com \
--cc=imammedo@redhat.com \
--cc=james.morse@arm.com \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wuquanming@huawei.com \
--cc=zhaoshenglong@huawei.com \
--cc=zhengqiang10@huawei.com \
--cc=zhihui.gao@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.