Re: [Qemu-devel] [PATCH v3 2/4] intel_iommu: let iotlb size tunable

[Peter Xu <peterx@redhat.com>]

On Thu, Jul 13, 2017 at 08:47:00PM +0300, Michael S. Tsirkin wrote:
> On Wed, Jul 12, 2017 at 04:13:41PM +0800, Peter Xu wrote:
> > We were having static IOTLB size as 1024. Let it be a tunable. We can
> > also turns IOTLB off if we want, by specify the size as zero.
> > 
> > The tunable is named as "x-iotlb-size" since that should not really be
> > something used by user yet, but mostly for debugging purpose now.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> 
> I'm somewhat vary of adding tunables just for developers to play with.
> People will find and abuse them :)

I would think it convenient (especially with "x-") and I would never
worry about people using it (I really see nothing dangerous...). But
if you don't like it, I can drop it in next version for sure.

Thanks,

-- 
Peter Xu