From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
andy.gross@linaro.org, david.brown@linaro.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins
Date: Fri, 14 Jul 2017 10:23:36 -0700 [thread overview]
Message-ID: <20170714172336.GO20973@minitux> (raw)
In-Reply-To: <6ca041fa-533d-6c6b-8c77-4c079cb7e9f6@codeaurora.org>
On Fri 14 Jul 10:17 PDT 2017, Timur Tabi wrote:
> On 07/14/2017 12:11 PM, Stephen Boyd wrote:
>
> > > +/*
> > > + * Request a GPIO. If the number of pins for this GPIO group is zero,
> > > + * then assume that the GPIO is unavailable.
> > > + */
> > > +static int msm_request(struct pinctrl_dev *pctldev, unsigned int offset)
> >
> > These names are awful. Reminds me of the serial driver that has
> > functions like msm_reset(). But when in Rome this is how it goes
> > I suppose.
>
> I can change it to msm_pinctrl_request().
>
msm_pinmux_request()
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins
Date: Fri, 14 Jul 2017 10:23:36 -0700 [thread overview]
Message-ID: <20170714172336.GO20973@minitux> (raw)
In-Reply-To: <6ca041fa-533d-6c6b-8c77-4c079cb7e9f6@codeaurora.org>
On Fri 14 Jul 10:17 PDT 2017, Timur Tabi wrote:
> On 07/14/2017 12:11 PM, Stephen Boyd wrote:
>
> > > +/*
> > > + * Request a GPIO. If the number of pins for this GPIO group is zero,
> > > + * then assume that the GPIO is unavailable.
> > > + */
> > > +static int msm_request(struct pinctrl_dev *pctldev, unsigned int offset)
> >
> > These names are awful. Reminds me of the serial driver that has
> > functions like msm_reset(). But when in Rome this is how it goes
> > I suppose.
>
> I can change it to msm_pinctrl_request().
>
msm_pinmux_request()
Regards,
Bjorn
next prev parent reply other threads:[~2017-07-14 17:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 21:52 [PATCH 0/2] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-07-13 21:52 ` Timur Tabi
2017-07-13 21:52 ` [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-07-13 21:52 ` Timur Tabi
2017-07-14 16:44 ` Bjorn Andersson
2017-07-14 16:44 ` Bjorn Andersson
2017-07-14 17:01 ` Timur Tabi
2017-07-14 17:01 ` Timur Tabi
2017-07-14 17:35 ` Bjorn Andersson
2017-07-14 17:35 ` Bjorn Andersson
2017-07-14 17:11 ` Stephen Boyd
2017-07-14 17:11 ` Stephen Boyd
2017-07-14 17:17 ` Timur Tabi
2017-07-14 17:17 ` Timur Tabi
2017-07-14 17:23 ` Bjorn Andersson [this message]
2017-07-14 17:23 ` Bjorn Andersson
2017-07-14 21:43 ` Timur Tabi
2017-07-14 21:43 ` Timur Tabi
2017-07-14 21:46 ` Stephen Boyd
2017-07-14 21:46 ` Stephen Boyd
2017-07-14 22:01 ` Timur Tabi
2017-07-14 22:01 ` Timur Tabi
2017-07-14 22:04 ` Stephen Boyd
2017-07-14 22:04 ` Stephen Boyd
2017-07-13 21:52 ` [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-07-13 21:52 ` Timur Tabi
2017-07-14 17:21 ` Bjorn Andersson
2017-07-14 17:21 ` Bjorn Andersson
2017-07-14 18:30 ` Timur Tabi
2017-07-14 18:30 ` Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2017-06-30 0:42 [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-06-30 0:42 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714172336.GO20973@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.