From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Martin Wilck <mwilck@suse.com>
Cc: Martin Wilck <mwilck@suse.de>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
tang.junhui@zte.com.cn, Guan Junxiong <guanjunxiong@huawei.com>,
linux-nvme@lists.infradead.org, dm-devel@redhat.com
Subject: Re: [PATCH 3/4] libmultipath: only listen for uevents with DEVTYPE=disk
Date: Fri, 14 Jul 2017 17:29:56 -0500 [thread overview]
Message-ID: <20170714222956.GC2940@octiron.msp.redhat.com> (raw)
In-Reply-To: <20170714113209.17177-4-mwilck@suse.com>
ACK
-Ben
On Fri, Jul 14, 2017 at 01:32:08PM +0200, Martin Wilck wrote:
> We are only interested in disks anyway. This saves us checking
> for devtype in the uevent processing queue, and is more powerful
> than the previous test in the dropped function
> uevent_can_discard_by_devpath().
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> ---
> libmultipath/uevent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c
> index b688ca03..eb44da56 100644
> --- a/libmultipath/uevent.c
> +++ b/libmultipath/uevent.c
> @@ -770,7 +770,7 @@ int uevent_listen(struct udev *udev)
> goto out;
> }
> err = udev_monitor_filter_add_match_subsystem_devtype(monitor, "block",
> - NULL);
> + "disk");
> if (err)
> condlog(2, "failed to create filter : %s", strerror(-err));
> err = udev_monitor_enable_receiving(monitor);
> --
> 2.13.2
WARNING: multiple messages have this Message-ID (diff)
From: bmarzins@redhat.com (Benjamin Marzinski)
Subject: [PATCH 3/4] libmultipath: only listen for uevents with DEVTYPE=disk
Date: Fri, 14 Jul 2017 17:29:56 -0500 [thread overview]
Message-ID: <20170714222956.GC2940@octiron.msp.redhat.com> (raw)
In-Reply-To: <20170714113209.17177-4-mwilck@suse.com>
ACK
-Ben
On Fri, Jul 14, 2017@01:32:08PM +0200, Martin Wilck wrote:
> We are only interested in disks anyway. This saves us checking
> for devtype in the uevent processing queue, and is more powerful
> than the previous test in the dropped function
> uevent_can_discard_by_devpath().
>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> Reviewed-by: Hannes Reinecke <hare at suse.de>
> ---
> libmultipath/uevent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c
> index b688ca03..eb44da56 100644
> --- a/libmultipath/uevent.c
> +++ b/libmultipath/uevent.c
> @@ -770,7 +770,7 @@ int uevent_listen(struct udev *udev)
> goto out;
> }
> err = udev_monitor_filter_add_match_subsystem_devtype(monitor, "block",
> - NULL);
> + "disk");
> if (err)
> condlog(2, "failed to create filter : %s", strerror(-err));
> err = udev_monitor_enable_receiving(monitor);
> --
> 2.13.2
next prev parent reply other threads:[~2017-07-14 22:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 11:32 [PATCH 0/4] libmultipath: Fixes for NVME / NVMEoF Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 11:32 ` [PATCH 1/4] libmultipath: get_udev_uid: make sure pp->wwid is 0-terminated Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 14:56 ` Bart Van Assche
2017-07-14 14:56 ` [dm-devel] " Bart Van Assche
2017-07-14 19:21 ` Martin Wilck
2017-07-14 19:21 ` [dm-devel] " Martin Wilck
2017-07-14 20:21 ` Bart Van Assche
2017-07-14 20:21 ` [dm-devel] " Bart Van Assche
2017-07-14 21:21 ` Martin Wilck
2017-07-14 21:21 ` [dm-devel] " Martin Wilck
2017-07-14 21:27 ` Bart Van Assche
2017-07-14 21:27 ` [dm-devel] " Bart Van Assche
2017-07-14 22:17 ` Benjamin Marzinski
2017-07-14 22:17 ` Benjamin Marzinski
2017-07-14 11:32 ` [PATCH 2/4] libmultipath: drop uevent_can_discard_by_devpath Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 22:18 ` Schremmer, Steven
2017-07-14 22:18 ` [dm-devel] " Schremmer, Steven
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-17 1:12 ` Guan Junxiong
2017-07-17 1:12 ` Guan Junxiong
2017-07-14 11:32 ` [PATCH 3/4] libmultipath: only listen for uevents with DEVTYPE=disk Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 22:16 ` Schremmer, Steven
2017-07-14 22:16 ` [dm-devel] " Schremmer, Steven
2017-07-14 22:29 ` Benjamin Marzinski [this message]
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-17 1:12 ` Guan Junxiong
2017-07-17 1:12 ` Guan Junxiong
2017-07-14 11:32 ` [PATCH 4/4] libmultipath: fix over-long NVME WWIDs Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 22:38 ` Benjamin Marzinski
2017-07-14 22:38 ` Benjamin Marzinski
2017-07-17 1:13 ` Guan Junxiong
2017-07-17 1:13 ` Guan Junxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714222956.GC2940@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
--cc=guanjunxiong@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mwilck@suse.com \
--cc=mwilck@suse.de \
--cc=tang.junhui@zte.com.cn \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.