* [PATCH] video: bfin-lq035q1-fb: constify dev_pm_ops @ 2017-07-17 1:19 ` Gustavo A. R. Silva 0 siblings, 0 replies; 4+ messages in thread From: Gustavo A. R. Silva @ 2017-07-17 1:19 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz; +Cc: linux-fbdev, linux-kernel, Gustavo A. R. Silva This dev_pm_ops structure is only stored in the pm field of a device_driver structure. This field is declared const, so dev_pm_ops structures that have this property can be declared as const also. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/video/fbdev/bfin-lq035q1-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/bfin-lq035q1-fb.c b/drivers/video/fbdev/bfin-lq035q1-fb.c index b594a58..b459354 100644 --- a/drivers/video/fbdev/bfin-lq035q1-fb.c +++ b/drivers/video/fbdev/bfin-lq035q1-fb.c @@ -841,7 +841,7 @@ static int bfin_lq035q1_resume(struct device *dev) return 0; } -static struct dev_pm_ops bfin_lq035q1_dev_pm_ops = { +static const struct dev_pm_ops bfin_lq035q1_dev_pm_ops = { .suspend = bfin_lq035q1_suspend, .resume = bfin_lq035q1_resume, }; -- 2.5.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: bfin-lq035q1-fb: constify dev_pm_ops @ 2017-07-17 1:19 ` Gustavo A. R. Silva 0 siblings, 0 replies; 4+ messages in thread From: Gustavo A. R. Silva @ 2017-07-17 1:19 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz; +Cc: linux-fbdev, linux-kernel, Gustavo A. R. Silva This dev_pm_ops structure is only stored in the pm field of a device_driver structure. This field is declared const, so dev_pm_ops structures that have this property can be declared as const also. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/video/fbdev/bfin-lq035q1-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/bfin-lq035q1-fb.c b/drivers/video/fbdev/bfin-lq035q1-fb.c index b594a58..b459354 100644 --- a/drivers/video/fbdev/bfin-lq035q1-fb.c +++ b/drivers/video/fbdev/bfin-lq035q1-fb.c @@ -841,7 +841,7 @@ static int bfin_lq035q1_resume(struct device *dev) return 0; } -static struct dev_pm_ops bfin_lq035q1_dev_pm_ops = { +static const struct dev_pm_ops bfin_lq035q1_dev_pm_ops = { .suspend = bfin_lq035q1_suspend, .resume = bfin_lq035q1_resume, }; -- 2.5.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: bfin-lq035q1-fb: constify dev_pm_ops 2017-07-17 1:19 ` Gustavo A. R. Silva @ 2017-08-01 13:23 ` Bartlomiej Zolnierkiewicz -1 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-08-01 13:23 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel On Sunday, July 16, 2017 08:19:06 PM Gustavo A. R. Silva wrote: > This dev_pm_ops structure is only stored in the pm field of a > device_driver structure. This field is declared const, so > dev_pm_ops structures that have this property can be declared > as const also. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: bfin-lq035q1-fb: constify dev_pm_ops @ 2017-08-01 13:23 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-08-01 13:23 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel On Sunday, July 16, 2017 08:19:06 PM Gustavo A. R. Silva wrote: > This dev_pm_ops structure is only stored in the pm field of a > device_driver structure. This field is declared const, so > dev_pm_ops structures that have this property can be declared > as const also. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-01 13:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170717011910epcas2p2df602abe7ade94050b8277cc186ce1e4@epcas2p2.samsung.com>
2017-07-17 1:19 ` [PATCH] video: bfin-lq035q1-fb: constify dev_pm_ops Gustavo A. R. Silva
2017-07-17 1:19 ` Gustavo A. R. Silva
2017-08-01 13:23 ` Bartlomiej Zolnierkiewicz
2017-08-01 13:23 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.