From: Pavel Machek <pavel@ucw.cz>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 3/5] pwm-backlight: add support for PWM delays proprieties.
Date: Thu, 20 Jul 2017 08:06:56 +0000 [thread overview]
Message-ID: <20170720080656.GC13103@amd> (raw)
In-Reply-To: <d38fa016-ea9c-edf8-9684-5c1235d27c82@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Hi!
> >--- a/drivers/video/backlight/pwm_bl.c
> >+++ b/drivers/video/backlight/pwm_bl.c
> >@@ -10,6 +10,7 @@
> > * published by the Free Software Foundation.
> > */
> >+#include <linux/delay.h>
> > #include <linux/gpio/consumer.h>
> > #include <linux/gpio.h>
> > #include <linux/module.h>
> >@@ -35,6 +36,7 @@ struct pwm_bl_data {
> > struct gpio_desc *enable_gpio;
> > unsigned int scale;
> > bool legacy;
> >+ unsigned int pwm_delay[2];
>
> Two named members would be better here (eliminating the "magic" 0
>and 1).
My thought, too.
> >@@ -56,6 +58,9 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness)
> > pwm_enable(pb->pwm);
> >+ if (pb->pwm_delay[0])
> >+ usleep_range(pb->pwm_delay[0], pb->pwm_delay[0] * 2);
Plus I'd just do the delay unconditionally :-).
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 3/5] pwm-backlight: add support for PWM delays proprieties.
Date: Thu, 20 Jul 2017 10:06:56 +0200 [thread overview]
Message-ID: <20170720080656.GC13103@amd> (raw)
In-Reply-To: <d38fa016-ea9c-edf8-9684-5c1235d27c82@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Hi!
> >--- a/drivers/video/backlight/pwm_bl.c
> >+++ b/drivers/video/backlight/pwm_bl.c
> >@@ -10,6 +10,7 @@
> > * published by the Free Software Foundation.
> > */
> >+#include <linux/delay.h>
> > #include <linux/gpio/consumer.h>
> > #include <linux/gpio.h>
> > #include <linux/module.h>
> >@@ -35,6 +36,7 @@ struct pwm_bl_data {
> > struct gpio_desc *enable_gpio;
> > unsigned int scale;
> > bool legacy;
> >+ unsigned int pwm_delay[2];
>
> Two named members would be better here (eliminating the "magic" 0
>and 1).
My thought, too.
> >@@ -56,6 +58,9 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness)
> > pwm_enable(pb->pwm);
> >+ if (pb->pwm_delay[0])
> >+ usleep_range(pb->pwm_delay[0], pb->pwm_delay[0] * 2);
Plus I'd just do the delay unconditionally :-).
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-07-20 8:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 21:28 [PATCH v3 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Enric Balletbo i Serra
2017-07-17 21:28 ` Enric Balletbo i Serra
2017-07-17 21:28 ` [PATCH v3 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties Enric Balletbo i Serra
2017-07-17 21:28 ` Enric Balletbo i Serra
2017-07-20 8:04 ` Pavel Machek
2017-07-20 8:04 ` Pavel Machek
2017-07-17 21:28 ` [PATCH v3 3/5] pwm-backlight: add support for PWM delays proprieties Enric Balletbo i Serra
2017-07-17 21:28 ` Enric Balletbo i Serra
2017-07-18 9:38 ` Daniel Thompson
2017-07-18 9:38 ` Daniel Thompson
2017-07-20 8:06 ` Pavel Machek [this message]
2017-07-20 8:06 ` Pavel Machek
2017-07-20 10:37 ` Daniel Thompson
2017-07-20 10:37 ` Daniel Thompson
2017-07-20 11:05 ` Pavel Machek
2017-07-20 11:05 ` Pavel Machek
2017-08-08 8:11 ` Pavel Machek
2017-08-08 8:11 ` Pavel Machek
2017-07-17 21:28 ` [PATCH v3 4/5] ARM: dts: rockchip: set PWM delay backlight settings for Veyron Enric Balletbo i Serra
2017-07-17 21:28 ` Enric Balletbo i Serra
2017-07-17 21:28 ` [PATCH v3 5/5] ARM: dts: rockchip: set PWM delay backlight settings for Minnie Enric Balletbo i Serra
2017-07-17 21:28 ` Enric Balletbo i Serra
2017-07-20 8:10 ` Pavel Machek
2017-07-20 8:10 ` Pavel Machek
2017-07-20 10:03 ` Enric Balletbo Serra
2017-07-20 10:03 ` Enric Balletbo Serra
2017-07-20 10:13 ` Pavel Machek
2017-07-20 10:13 ` Pavel Machek
2017-07-18 9:34 ` [PATCH v3 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Daniel Thompson
2017-07-18 9:34 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720080656.GC13103@amd \
--to=pavel@ucw.cz \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.