From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Peter Chen <Peter.Chen-3arQi8VN3Tc@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>,
Rakesh Iyer <riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Peter Meerwald-Stadler
<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Xinliang Liu
<z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Vincent Abriou <vincent.abriou-qxv4g6HH51o@public.gmane.org>,
Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel@
Subject: Re: [PATCH 000/102] Convert drivers to explicit reset API
Date: Thu, 20 Jul 2017 10:11:57 +0200 [thread overview]
Message-ID: <20170720081157.GA11630@kroah.com> (raw)
In-Reply-To: <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Peter Chen" <Peter.Chen@nxp.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org,
"Marc Dietrich" <marvin24@gmx.de>,
"Rakesh Iyer" <riyer@nvidia.com>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
linux-clk@vger.kernel.org, "Wim Van Sebroeck" <wim@iguana.be>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Jiri Slaby" <jslaby@suse.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Ohad Ben-Cohen" <ohad@wizery.com>,
linux-pm@vger.kernel.org, "Thomas Gleixner" <tglx@linutronix.de>,
"Vincent Abriou" <vincent.abriou@st.com>,
"Bin Liu" <b-liu@ti.com>,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ralf Baechle" <ralf@linux-mips.org>,
linux-spi@vger.kernel.org, linux-crypto@vger.kernel.org,
"Tejun Heo" <tj@kernel.org>,
alsa-devel@alsa-project.org, linux-doc@vger.kernel.org,
"David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org,
"Philippe Cornu" <philippe.cornu@st.com>,
"Kalle Valo" <kvalo@qca.qualcomm.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Corentin Labbe" <clabbe.montjoie@gmail.com>,
linux-i2c@vger.kernel.org, linux-watchdog@vger.kernel.org,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Emilio López" <emilio@elopez.com.ar>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Jon Hunter" <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
linux-media@vger.kernel.org, "Richard Zhu" <hongxing.zhu@nxp.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
linux-arm-msm@vger.kernel.org,
"Joachim Eastwood" <manabian@gmail.com>,
linux-gpio@vger.kernel.org, linux-mips@linux-mips.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
linux-arm-kernel@lists.infradead.org,
"Patrice Chotard" <patrice.chotard@st.com>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Jonathan Cameron" <jic23@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
linux-iio@vger.kernel.org, linux-pci@vger.kernel.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
linux-tegra@vger.kernel.org, linux-mtd@lists.infradead.org,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
ath10k@lists.infradead.org,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Chen-Yu Tsai" <wens@csie.org>,
linux-input@vger.kernel.org, linux-pwm@vger.kernel.org,
"Chen Feng" <puck.chen@hisilicon.com>,
"Mark Brown" <broonie@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Felipe Balbi" <balbi@kernel.org>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-mmc@vger.kernel.org, "Liam Girdwood" <lgirdwood@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-remoteproc@vger.kernel.org,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
linux-ide@vger.kernel.org, "Lee Jones" <lee.jones@linaro.org>,
devel@driverdev.osuosl.org,
"Yannick Fertre" <yannick.fertre@st.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Richard Weinberger" <richard@nod.at>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
linux-serial@vger.kernel.org, "Zhang Rui" <rui.zhang@intel.com>,
"Alan Tull" <atull@kernel.org>,
"John Youn" <johnyoun@synopsys.com>,
"Eduardo Valentin" <edubezval@gmail.com>,
dmaengine@vger.kernel.org, linux-mediatek@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mark Yao" <mark.yao@rock-chips.com>,
"Moritz Fischer" <moritz.fischer@ettus.com>,
"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Stephen Boyd" <sboyd@codeaurora.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Vinod Koul" <vinod.koul@intel.com>,
"Rongrong Zou" <zourongrong@gmail.com>,
linux-fpga@vger.kernel.org,
"David Woodhouse" <dwmw2@infradead.org>,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH 000/102] Convert drivers to explicit reset API
Date: Thu, 20 Jul 2017 10:11:57 +0200 [thread overview]
Message-ID: <20170720081157.GA11630@kroah.com> (raw)
In-Reply-To: <20170719152646.25903-1-p.zabel@pengutronix.de>
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Emilio López" <emilio@elopez.com.ar>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Alan Tull" <atull@kernel.org>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Ben Skeggs" <bskeggs@redhat.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Bin Liu" <b-liu@ti.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Chen Feng" <puck.chen@hisilicon.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Corentin Labbe" <clabbe.montjoie@gmail.com>,
"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
"Dan Williams" <dan.j.williams@intel.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"David Airlie" <airlied@linux.ie>,
"David Woodhouse" <dwmw2@infradead.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Eduardo Valentin" <edubezval@gmail.com>,
"Felipe Balbi" <balbi@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Heiko Stuebner" <heiko@sntech.de>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Jiri Slaby" <jslaby@suse.com>,
"Joachim Eastwood" <manabian@gmail.com>,
"John Youn" <johnyoun@synopsys.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Kalle Valo" <kvalo@qca.qualcomm.com>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Marc Dietrich" <marvin24@gmx.de>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Mark Yao" <mark.yao@rock-chips.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Moritz Fischer" <moritz.fischer@ettus.com>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Ohad Ben-Cohen" <ohad@wizery.com>,
"Patrice Chotard" <patrice.chotard@st.com>,
"Peter Chen" <Peter.Chen@nxp.com>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Philippe Cornu" <philippe.cornu@st.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Rakesh Iyer" <riyer@nvidia.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Richard Weinberger" <richard@nod.at>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Rongrong Zou" <zourongrong@gmail.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Stephen Boyd" <sboyd@codeaurora.org>,
"Tejun Heo" <tj@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Vincent Abriou" <vincent.abriou@st.com>,
"Vinod Koul" <vinod.koul@intel.com>,
"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
"Wim Van Sebroeck" <wim@iguana.be>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Yannick Fertre" <yannick.fertre@st.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Zhang Rui" <rui.zhang@intel.com>,
alsa-devel@alsa-project.org, ath10k@lists.infradead.org,
devel@driverdev.osuosl.org, dmaengine@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-ide@vger.kernel.org,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-mips@linux-mips.org, linux-mmc@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-remoteproc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-serial@vger.kernel.org,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
nouveau@lists.freedesktop.org
Subject: Re: [PATCH 000/102] Convert drivers to explicit reset API
Date: Thu, 20 Jul 2017 10:11:57 +0200 [thread overview]
Message-ID: <20170720081157.GA11630@kroah.com> (raw)
In-Reply-To: <20170719152646.25903-1-p.zabel@pengutronix.de>
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Peter Chen <Peter.Chen-3arQi8VN3Tc@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>,
Rakesh Iyer <riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Peter Meerwald-Stadler
<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Xinliang Liu
<z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Vincent Abriou <vincent.abriou-qxv4g6HH51o@public.gmane.org>,
Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 000/102] Convert drivers to explicit reset API
Date: Thu, 20 Jul 2017 10:11:57 +0200 [thread overview]
Message-ID: <20170720081157.GA11630@kroah.com> (raw)
In-Reply-To: <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-20 8:11 UTC|newest]
Thread overview: 202+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 15:25 [PATCH 000/102] Convert drivers to explicit reset API Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 001/102] ARM: rockchip: explicitly request exclusive reset control Philipp Zabel
2017-07-20 20:28 ` Heiko Stuebner
2017-07-19 15:25 ` [PATCH 003/102] MIPS: pci-mt7620: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 004/102] ahci: st: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 005/102] ata: sata_gemini: " Philipp Zabel
2017-08-02 9:39 ` Linus Walleij
2017-08-02 15:15 ` Tejun Heo
2017-07-19 15:25 ` [PATCH 006/102] ata: ahci_tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 007/102] bus: sunxi-rsb: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 008/102] bus: tegra-gmi: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 009/102] clk: sunxi: " Philipp Zabel
2017-11-02 5:55 ` Stephen Boyd
2017-07-19 15:25 ` [PATCH 010/102] clk: tegra: " Philipp Zabel
2017-11-02 8:15 ` Stephen Boyd
2017-07-19 15:25 ` [PATCH 011/102] clocksource/drivers/timer-stm32: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 012/102] clocksource/drivers/sun5i: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 013/102] crypto: rockchip: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 014/102] crypto: sun4i-ss - " Philipp Zabel
2017-07-19 15:25 ` [PATCH 015/102] PM / devfreq: tegra: explicitly " Philipp Zabel
2017-07-19 15:25 ` [PATCH 018/102] dmaengine: tegra-apb: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 019/102] drm: kirin: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 020/102] drm/nouveau/tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 021/102] drm/rockchip: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 022/102] drm/sti: " Philipp Zabel
2017-07-20 10:09 ` Benjamin Gaignard
2017-07-19 15:25 ` [PATCH 023/102] drm/stm: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 024/102] drm/sun4i: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 025/102] drm/tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 026/102] gpu: host1x: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 027/102] i2c: mv64xxx: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 028/102] i2c: stm32f4: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 029/102] i2c: sun6i-pw2i: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 030/102] i2c: tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 031/102] iio: adc: rockchip_saradc: " Philipp Zabel
2017-08-20 11:09 ` Jonathan Cameron
2017-07-19 15:25 ` [PATCH 032/102] iio: dac: stm32-dac-core: " Philipp Zabel
2017-08-20 11:07 ` Jonathan Cameron
2017-07-19 15:25 ` [PATCH 038/102] mmc: dw_mmc: " Philipp Zabel
2017-07-22 13:13 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 039/102] mmc: sdhci-st: " Philipp Zabel
2017-07-27 14:49 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 040/102] mmc: sunxi: " Philipp Zabel
2017-07-27 14:48 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 041/102] mmc: tegra: " Philipp Zabel
2017-07-27 14:49 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 042/102] mtd: nand: sunxi: " Philipp Zabel
2017-07-20 7:00 ` Boris Brezillon
2017-07-20 9:27 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 043/102] mtd: spi-nor: stm32-quadspi: " Philipp Zabel
2018-05-18 20:03 ` Boris Brezillon
2017-07-19 15:25 ` [PATCH 049/102] ath10k: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-08-03 11:38 ` [049/102] " Kalle Valo
2017-08-03 11:38 ` Kalle Valo
2017-07-19 15:25 ` [PATCH 050/102] nvmem: lpc18xx-eeprom: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 051/102] PCI: dwc: pcie-qcom: " Philipp Zabel
2017-08-03 21:40 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 052/102] PCI: imx6: " Philipp Zabel
2017-08-03 21:41 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 053/102] PCI: tegra: " Philipp Zabel
2017-08-03 21:42 ` Bjorn Helgaas
2017-08-03 21:42 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 054/102] PCI: rockchip: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-22 13:12 ` Shawn Lin
2017-07-24 8:35 ` Philipp Zabel
2017-08-03 0:31 ` Shawn Lin
2017-08-03 21:43 ` Bjorn Helgaas
2017-07-19 15:26 ` [PATCH 061/102] phy: sun4i-usb: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 062/102] phy: sun9i-usb: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 063/102] phy: tegra: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 066/102] pinctrl: stm32: " Philipp Zabel
2017-08-02 11:43 ` Linus Walleij
2017-07-19 15:26 ` [PATCH 067/102] pinctrl: sunxi: " Philipp Zabel
2017-08-02 11:44 ` Linus Walleij
2017-07-19 15:26 ` [PATCH 068/102] pinctrl: tegra: " Philipp Zabel
[not found] ` <20170719152646.25903-69-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-08-02 11:45 ` Linus Walleij
2017-07-19 15:26 ` [PATCH 069/102] pwm: hibvt: " Philipp Zabel
2017-08-21 6:54 ` Thierry Reding
2017-07-19 15:26 ` [PATCH 071/102] remoteproc/keystone: " Philipp Zabel
2017-07-19 16:59 ` Suman Anna
2017-08-24 21:58 ` Suman Anna
2017-07-19 15:26 ` [PATCH 072/102] remoteproc: qcom: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 073/102] remoteproc: st: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 074/102] soc: mediatek: PMIC wrap: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 075/102] soc/tegra: pmc: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 076/102] spi: stm32: " Philipp Zabel
2017-07-19 16:08 ` Applied "spi: stm32: explicitly request exclusive reset control" to the spi tree Mark Brown
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-19 15:25 ` [PATCH 033/102] Input: tegra-kbc - request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` [PATCH 056/102] PCI: mediatek: explicitly " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-08-03 21:45 ` Bjorn Helgaas
2017-07-19 15:26 ` [PATCH 058/102] phy: rockchip-pcie: " Philipp Zabel
2017-07-22 13:09 ` Shawn Lin
2017-08-03 0:37 ` Shawn Lin
2017-07-19 15:26 ` [PATCH 059/102] phy: rockchip-typec: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 060/102] phy: rockchip-usb: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 070/102] pwm: tegra: " Philipp Zabel
2017-08-21 6:54 ` Thierry Reding
2017-07-19 15:26 ` [PATCH 077/102] spi: sun6i: " Philipp Zabel
2017-07-19 16:08 ` Applied "spi: sun6i: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 15:26 ` [PATCH 078/102] spi: tegra20-slink: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "spi: tegra20-slink: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 079/102] spi: tegra114: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "spi: tegra114: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 080/102] spi: tegra20-sflash: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "spi: tegra20-sflash: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 085/102] serial: tegra: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` [PATCH 088/102] usb: host: ehci-tegra: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 100/102] ASoC: tegra: " Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: tegra: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 19:15 ` [PATCH 000/102] Convert drivers to explicit reset API Thomas Petazzoni
2017-07-19 19:15 ` Thomas Petazzoni
2017-07-19 19:15 ` Thomas Petazzoni
2017-07-19 19:15 ` Thomas Petazzoni
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 9:36 ` Philipp Zabel
[not found] ` <1500543415.2354.37.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-23 18:41 ` Linus Walleij
2017-07-23 18:41 ` Linus Walleij
2017-07-23 18:41 ` Linus Walleij
2017-07-23 18:41 ` Linus Walleij
2017-07-24 8:33 ` Philipp Zabel
2017-07-24 8:33 ` Philipp Zabel
2017-07-24 8:33 ` Philipp Zabel
2017-07-24 8:33 ` Philipp Zabel
[not found] ` <1500885221.2391.50.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-08-12 11:43 ` Wolfram Sang
2017-08-12 11:43 ` Wolfram Sang
2017-08-12 11:43 ` Wolfram Sang
2017-08-12 11:43 ` Wolfram Sang
2017-08-14 7:36 ` Philipp Zabel
2017-08-14 7:36 ` Philipp Zabel
2017-08-14 7:36 ` Philipp Zabel
2017-08-14 7:36 ` Philipp Zabel
2017-07-20 6:56 ` Maxime Ripard
2017-07-20 6:56 ` Maxime Ripard
2017-07-20 6:56 ` Maxime Ripard
2017-07-20 8:11 ` Greg Kroah-Hartman [this message]
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-19 15:26 ` [PATCH 081/102] staging: nvec: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` [PATCH 082/102] thermal: rockchip: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 083/102] thermal: tegra: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 084/102] serial: 8250_dw: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 089/102] usb: host: xhci-tegra: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 093/102] watchdog: asm9260: " Philipp Zabel
2017-07-19 17:35 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 094/102] watchdog: mt7621: " Philipp Zabel
2017-07-19 17:35 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 095/102] watchdog: rt2880: " Philipp Zabel
2017-07-19 17:36 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 096/102] watchdog: zx2967: " Philipp Zabel
2017-07-19 17:36 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 097/102] ASoC: img: " Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: img: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 15:26 ` [PATCH 098/102] ASoC: stm32: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: stm32: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 15:26 ` [PATCH 099/102] ASoC: sun4i: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: sun4i: explicitly request exclusive reset control" to the asoc tree Mark Brown
[not found] ` <20170719152646.25903-3-p.zabel@pengutronix.de>
2017-07-19 16:12 ` [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control Moritz Fischer
2017-07-27 18:49 ` Alan Tull
2017-07-20 20:32 ` [PATCH 000/102] Convert drivers to explicit reset API Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:36 ` (no subject) Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` [PATCH 000/102] Convert drivers to explicit reset API Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
-- strict thread matches above, loose matches on Subject: below --
2017-07-19 15:25 Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720081157.GA11630@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=Peter.Chen-3arQi8VN3Tc@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=b-liu-l0cyMroinI0@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=jslaby-IBi9RG/b67k@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vincent.abriou-qxv4g6HH51o@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
--cc=z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.