From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver
Date: Thu, 20 Jul 2017 14:14:06 +0100 [thread overview]
Message-ID: <20170720131406.GC16356@arm.com> (raw)
In-Reply-To: <20170720130847.GB16356@arm.com>
On Thu, Jul 20, 2017 at 02:08:47PM +0100, Will Deacon wrote:
> On Thu, Jul 20, 2017 at 08:54:36PM +0800, Zhangshaokun wrote:
> > On 2017/7/19 17:17, Jonathan Cameron wrote:
> > >> +Super CPU cluster (SCCL) and is made up of 6 CCLs. Each SCCL has two HHAs
> > >> +(0 - 1) and four DDRCs (0 - 3), respectively.
> > >> +
> > >> +HiSilicon SoC uncore PMU driver
> > >> +---------------------------------------
> > >> +Each device PMU has separate registers for event counting, control and
> > >> +interrupt, and the PMU driver shall register perf PMU drivers like L3C,
> > >> +HHA and DDRC etc. The available events and configuration options shall
> > >> +be described in the sysfs, see /sys/devices/hisi_*.
> > > Is there not a subsystem directory that would make more sense to
> > > refer to than the full device list?
> > >
> >
> > For uncore devices, it is more reasonable to list in /sys/devices/***.
>
> The usual place for these things is /sys/bus/event_source/devices/<pmu name>.
... which are symlinks to directories under /sys/devices/! I didn't realise
that, so I suspect you're ok. Still worth getting the format of things
correct though, so perf can read/parse them with minimal effort.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Zhangshaokun <zhangshaokun@hisilicon.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
mark.rutland@arm.com, linuxarm@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver
Date: Thu, 20 Jul 2017 14:14:06 +0100 [thread overview]
Message-ID: <20170720131406.GC16356@arm.com> (raw)
In-Reply-To: <20170720130847.GB16356@arm.com>
On Thu, Jul 20, 2017 at 02:08:47PM +0100, Will Deacon wrote:
> On Thu, Jul 20, 2017 at 08:54:36PM +0800, Zhangshaokun wrote:
> > On 2017/7/19 17:17, Jonathan Cameron wrote:
> > >> +Super CPU cluster (SCCL) and is made up of 6 CCLs. Each SCCL has two HHAs
> > >> +(0 - 1) and four DDRCs (0 - 3), respectively.
> > >> +
> > >> +HiSilicon SoC uncore PMU driver
> > >> +---------------------------------------
> > >> +Each device PMU has separate registers for event counting, control and
> > >> +interrupt, and the PMU driver shall register perf PMU drivers like L3C,
> > >> +HHA and DDRC etc. The available events and configuration options shall
> > >> +be described in the sysfs, see /sys/devices/hisi_*.
> > > Is there not a subsystem directory that would make more sense to
> > > refer to than the full device list?
> > >
> >
> > For uncore devices, it is more reasonable to list in /sys/devices/***.
>
> The usual place for these things is /sys/bus/event_source/devices/<pmu name>.
... which are symlinks to directories under /sys/devices/! I didn't realise
that, so I suspect you're ok. Still worth getting the format of things
correct though, so perf can read/parse them with minimal effort.
Will
next prev parent reply other threads:[~2017-07-20 13:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 7:59 [PATCH v3 0/6] Add HiSilicon SoC uncore Performance Monitoring Unit driver Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
2017-07-18 7:59 ` [PATCH v3 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
2017-07-19 9:17 ` Jonathan Cameron
2017-07-19 9:17 ` Jonathan Cameron
2017-07-20 12:54 ` Zhangshaokun
2017-07-20 12:54 ` Zhangshaokun
2017-07-20 13:08 ` Will Deacon
2017-07-20 13:08 ` Will Deacon
2017-07-20 13:14 ` Will Deacon [this message]
2017-07-20 13:14 ` Will Deacon
2017-07-18 7:59 ` [PATCH v3 2/6] perf: hisi: Add support for HiSilicon SoC uncore " Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
2017-07-19 9:19 ` Jonathan Cameron
2017-07-19 9:19 ` Jonathan Cameron
2017-07-20 13:03 ` Zhangshaokun
2017-07-20 13:03 ` Zhangshaokun
2017-07-20 13:49 ` Jonathan Cameron
2017-07-20 13:49 ` Jonathan Cameron
2017-07-20 14:16 ` Zhangshaokun
2017-07-20 14:16 ` Zhangshaokun
2017-07-18 7:59 ` [PATCH v3 3/6] perf: hisi: Add support for HiSilicon SoC L3C " Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
2017-07-19 9:28 ` Jonathan Cameron
2017-07-19 9:28 ` Jonathan Cameron
2017-07-20 14:06 ` Zhangshaokun
2017-07-20 14:06 ` Zhangshaokun
2017-07-18 7:59 ` [PATCH v3 4/6] perf: hisi: Add support for HiSilicon SoC HHA " Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
2017-07-18 7:59 ` [PATCH v3 5/6] perf: hisi: Add support for HiSilicon SoC DDRC " Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
2017-07-18 7:59 ` [PATCH v3 6/6] arm64: MAINTAINERS: hisi: Add HiSilicon SoC PMU support Shaokun Zhang
2017-07-18 7:59 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720131406.GC16356@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.