From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes
Date: Thu, 20 Jul 2017 16:11:40 -0400 [thread overview]
Message-ID: <20170720201140.GE1202@localhost.localdomain> (raw)
In-Reply-To: <20170720163402.17793-4-mwilck@suse.com>
On Thu, Jul 20, 2017@06:34:02PM +0200, Martin Wilck wrote:
> Some broken targets (such as the current Linux target) pad
> model or serial fields with 0-bytes rather than spaces. The
> NVME spec disallows 0 bytes in "ASCII" fields.
> Thus strip trailing 0-bytes, too. Also make sure that we get no
> underflow for pathological input.
>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> Reviewed-by: Hannes Reinecke <hare at suse.de>
> Acked-by: Christoph Hellwig <hch at lst.de>
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Martin Wilck <mwilck@suse.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Martin Wilck <mwilck@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
joe@perches.com
Subject: Re: [PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes
Date: Thu, 20 Jul 2017 16:11:40 -0400 [thread overview]
Message-ID: <20170720201140.GE1202@localhost.localdomain> (raw)
In-Reply-To: <20170720163402.17793-4-mwilck@suse.com>
On Thu, Jul 20, 2017 at 06:34:02PM +0200, Martin Wilck wrote:
> Some broken targets (such as the current Linux target) pad
> model or serial fields with 0-bytes rather than spaces. The
> NVME spec disallows 0 bytes in "ASCII" fields.
> Thus strip trailing 0-bytes, too. Also make sure that we get no
> underflow for pathological input.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Acked-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2017-07-20 20:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 16:33 [PATCH v3 0/3] Improve readbility of NVME "wwid" attribute Martin Wilck
2017-07-20 16:33 ` Martin Wilck
2017-07-20 16:34 ` [PATCH v3 1/3] string.h: add memcpy_and_pad() Martin Wilck
2017-07-20 16:34 ` Martin Wilck
2017-07-22 3:45 ` kbuild test robot
2017-07-22 3:45 ` kbuild test robot
2017-07-23 18:18 ` kbuild test robot
2017-07-23 18:18 ` kbuild test robot
2017-07-20 16:34 ` [PATCH v3 2/3] nvmet: identify controller: improve standard compliance Martin Wilck
2017-07-20 16:34 ` Martin Wilck
2017-07-20 16:34 ` [PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes Martin Wilck
2017-07-20 16:34 ` Martin Wilck
2017-07-20 20:11 ` Keith Busch [this message]
2017-07-20 20:11 ` Keith Busch
2017-08-10 8:45 ` Christoph Hellwig
2017-08-10 8:45 ` Christoph Hellwig
2017-08-14 20:12 ` [PATCH v4 0/3] Improve readbility of NVME "wwid" attribute (target side) Martin Wilck
2017-08-14 20:12 ` Martin Wilck
2017-08-14 20:12 ` [PATCH v4 1/3] nvmet_execute_identify_ctrl: don't overwrite with 0-bytes Martin Wilck
2017-08-14 20:12 ` Martin Wilck
2017-08-14 20:12 ` [PATCH v4 2/3] string.h: add memcpy_and_pad() Martin Wilck
2017-08-14 20:12 ` Martin Wilck
2017-09-05 7:28 ` Arnd Bergmann
2017-09-05 7:28 ` Arnd Bergmann
2017-09-05 18:18 ` Martin Wilck
2017-09-05 18:18 ` Martin Wilck
2017-09-05 18:23 ` [PATCH] string.h: un-fortify memcpy_and_pad Martin Wilck
2017-09-05 18:23 ` Martin Wilck
2017-09-05 19:26 ` Arnd Bergmann
2017-09-05 19:26 ` Arnd Bergmann
2017-09-06 13:02 ` Arnd Bergmann
2017-09-06 13:02 ` Arnd Bergmann
2017-08-14 20:12 ` [PATCH v4 3/3] nvmet_execute_identify_ctrl: use memcpy_and_pad() Martin Wilck
2017-08-14 20:12 ` Martin Wilck
2017-08-15 9:10 ` [PATCH v4 0/3] Improve readbility of NVME "wwid" attribute (target side) Sagi Grimberg
2017-08-15 9:10 ` Sagi Grimberg
2017-08-16 8:12 ` Christoph Hellwig
2017-08-16 8:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720201140.GE1202@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.