Test Unit Ready translation seems wrong in latest driver

Test Unit Ready translation seems wrong in latest driver

[Sathya Prakash Veerichetty]

The TUR translation returns LUN not ready when the controller is ready in
the latest code whereas in the old code it returns LUN not ready only when
the controller is not ready (proper behavior).

The patch  [PATCH 11/47] nvme: split a new struct nvme_ctrl out of struct
nvme_dev seeded the issue by missing the !.

@@ -2295,9 +2288,7 @@ static int nvme_trans_test_unit_ready(struct nvme_ns
*ns,
 					struct sg_io_hdr *hdr,
 					u8 *cmd)
 {
-	struct nvme_dev *dev = ns->dev;
-
-	if (!(readl(dev->bar + NVME_REG_CSTS) & NVME_CSTS_RDY))
+	if (nvme_ctrl_ready(ns->ctrl))
 		return nvme_trans_completion(hdr,
SAM_STAT_CHECK_CONDITION,
 					    NOT_READY,
SCSI_ASC_LUN_NOT_READY,

SCSI_ASCQ_CAUSE_NOT_REPORTABLE);

Thanks
Sathya

Test Unit Ready translation seems wrong in latest driver

[Keith Busch]

On Mon, Jul 24, 2017@03:52:16PM -0600, Sathya Prakash Veerichetty wrote:
> The TUR translation returns LUN not ready when the controller is ready in
> the latest code whereas in the old code it returns LUN not ready only when
> the controller is not ready (proper behavior).

The latest code doesn't have a translation for TUR at all.

Test Unit Ready translation seems wrong in latest driver

[Sathya Prakash Veerichetty]

My bad, I was referring to 4.12.  So there will not be any support to SCSI
translation at all or is there a different interface?

Thanks
Sathya

-----Original Message-----
From: Keith Busch [mailto:keith.busch@intel.com]
Sent: Monday, July 24, 2017 4:02 PM
To: Sathya Prakash Veerichetty
Cc: linux-nvme at lists.infradead.org; hch at lst.de
Subject: Re: Test Unit Ready translation seems wrong in latest driver

On Mon, Jul 24, 2017 at 03:52:16PM -0600, Sathya Prakash Veerichetty
wrote:
> The TUR translation returns LUN not ready when the controller is ready
> in the latest code whereas in the old code it returns LUN not ready
> only when the controller is not ready (proper behavior).

The latest code doesn't have a translation for TUR at all.

Test Unit Ready translation seems wrong in latest driver

[Keith Busch]

On Mon, Jul 24, 2017@04:21:36PM -0600, Sathya Prakash Veerichetty wrote:
> My bad, I was referring to 4.12.  So there will not be any support to SCSI
> translation at all or is there a different interface?

Correct, no support for SCSI when using NVMe. The NVMe interface is the
one to use for managing NVMe devices.