All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
Date: Wed, 26 Jul 2017 10:36:54 +0800	[thread overview]
Message-ID: <20170726023653.GA30888@dragon> (raw)
In-Reply-To: <1500828552-16237-1-git-send-email-akurz@blala.de>

On Sun, Jul 23, 2017 at 06:49:12PM +0200, Alexander Kurz wrote:
> Enable USB OTG (dual-role) on the Wandboard.
> Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
> in the power line. Hence, the overcurrent signal of 1A will never be
> triggered on this board.
> 
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---

When sending a version, it's helpful to have a change log here.

>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index b4fa7f1..f1abde8 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -34,6 +34,16 @@
>  			regulator-max-microvolt = <3300000>;
>  			regulator-always-on;
>  		};
> +
> +		reg_usb_otg_vbus: usb_otg_vbus {

You are trying to add a fixed regulator under regulators bus node
without sticking to the existing convention.  I understand that it's
now preferred to put fixed regulator node directly under root node, but
mixing two styles is not good either.

I suggest you order a patch to remove regulators bus node and name node
like below:

	reg_xxx: regulator-xxx {
		...
	};

And then add your changes on top of that.

Shawn

> +			compatible = "regulator-fixed";
> +			regulator-name = "usb_otg_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_usbotgvbus>;
> +			gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> +		};
>  	};
>  
>  	sound {
> @@ -170,6 +180,12 @@
>  			>;
>  		};
>  
> +		pinctrl_usbotgvbus: usbotgvbusgrp {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
> +			>;
> +		};
> +
>  		pinctrl_usdhc1: usdhc1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_SD1_CMD__SD1_CMD		0x17059
> @@ -244,10 +260,11 @@
>  };
>  
>  &usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usbotg>;
>  	disable-over-current;
> -	dr_mode = "peripheral";
> +	dr_mode = "otg";
>  	status = "okay";
>  };
>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Alexander Kurz <akurz-3EoFODjbY6Q@public.gmane.org>
Cc: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
Date: Wed, 26 Jul 2017 10:36:54 +0800	[thread overview]
Message-ID: <20170726023653.GA30888@dragon> (raw)
In-Reply-To: <1500828552-16237-1-git-send-email-akurz-3EoFODjbY6Q@public.gmane.org>

On Sun, Jul 23, 2017 at 06:49:12PM +0200, Alexander Kurz wrote:
> Enable USB OTG (dual-role) on the Wandboard.
> Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
> in the power line. Hence, the overcurrent signal of 1A will never be
> triggered on this board.
> 
> Signed-off-by: Alexander Kurz <akurz-3EoFODjbY6Q@public.gmane.org>
> ---

When sending a version, it's helpful to have a change log here.

>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index b4fa7f1..f1abde8 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -34,6 +34,16 @@
>  			regulator-max-microvolt = <3300000>;
>  			regulator-always-on;
>  		};
> +
> +		reg_usb_otg_vbus: usb_otg_vbus {

You are trying to add a fixed regulator under regulators bus node
without sticking to the existing convention.  I understand that it's
now preferred to put fixed regulator node directly under root node, but
mixing two styles is not good either.

I suggest you order a patch to remove regulators bus node and name node
like below:

	reg_xxx: regulator-xxx {
		...
	};

And then add your changes on top of that.

Shawn

> +			compatible = "regulator-fixed";
> +			regulator-name = "usb_otg_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_usbotgvbus>;
> +			gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> +		};
>  	};
>  
>  	sound {
> @@ -170,6 +180,12 @@
>  			>;
>  		};
>  
> +		pinctrl_usbotgvbus: usbotgvbusgrp {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
> +			>;
> +		};
> +
>  		pinctrl_usdhc1: usdhc1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_SD1_CMD__SD1_CMD		0x17059
> @@ -244,10 +260,11 @@
>  };
>  
>  &usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usbotg>;
>  	disable-over-current;
> -	dr_mode = "peripheral";
> +	dr_mode = "otg";
>  	status = "okay";
>  };
>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-07-26  2:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-23 16:49 [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG Alexander Kurz
2017-07-23 16:49 ` Alexander Kurz
2017-07-23 20:29 ` Fabio Estevam
2017-07-23 20:29   ` Fabio Estevam
2017-07-26  2:36 ` Shawn Guo [this message]
2017-07-26  2:36   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726023653.GA30888@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.