All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Johan Hovold <johan@kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Dave Gerlach <d-gerlach@ti.com>,
	Kevin Hilman <khilman@baylibre.com>, Nishanth Menon <nm@ti.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq
Date: Wed, 26 Jul 2017 10:35:21 +0200	[thread overview]
Message-ID: <20170726083521.GE27516@localhost> (raw)
In-Reply-To: <20170726081716.GB10026@atomide.com>

On Wed, Jul 26, 2017 at 01:17:17AM -0700, Tony Lindgren wrote: > * Johan Hovold <johan@kernel.org> [170726 00:51]:
> > On Tue, Jul 25, 2017 at 12:48:40PM -0500, Grygorii Strashko wrote:
> > > So, thank you for your patches and sorry for the noise.
> > > 
> > > Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > 
> > Thanks for testing.
> 
> So does the patch description need updating?

I don't think so.

I did notice that I left out a "would" in the final sentence

	"and either way, any such calls *would* have been causing
	crashes since 4.10"
	
which perhaps you could add when applying?

> And this is needed as a fix for the -rc cycle in addition to your musb
> patch?

Unlike the musb patch, this one is not critical and could possibly wait
for 4.14. But since all it does is to get rid of a (since 4.10) broken
state update, and thereby those warning messages on suspend, I'd say
it's -rc material.

Thanks,
Johan

WARNING: multiple messages have this Message-ID (diff)
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq
Date: Wed, 26 Jul 2017 10:35:21 +0200	[thread overview]
Message-ID: <20170726083521.GE27516@localhost> (raw)
In-Reply-To: <20170726081716.GB10026@atomide.com>

On Wed, Jul 26, 2017 at 01:17:17AM -0700, Tony Lindgren wrote: > * Johan Hovold <johan@kernel.org> [170726 00:51]:
> > On Tue, Jul 25, 2017 at 12:48:40PM -0500, Grygorii Strashko wrote:
> > > So, thank you for your patches and sorry for the noise.
> > > 
> > > Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > 
> > Thanks for testing.
> 
> So does the patch description need updating?

I don't think so.

I did notice that I left out a "would" in the final sentence

	"and either way, any such calls *would* have been causing
	crashes since 4.10"
	
which perhaps you could add when applying?

> And this is needed as a fix for the -rc cycle in addition to your musb
> patch?

Unlike the musb patch, this one is not critical and could possibly wait
for 4.14. But since all it does is to get rid of a (since 4.10) broken
state update, and thereby those warning messages on suspend, I'd say
it's -rc material.

Thanks,
Johan

  reply	other threads:[~2017-07-26  8:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24  9:52 [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq Johan Hovold
2017-07-24  9:52 ` Johan Hovold
2017-07-24 22:16 ` Grygorii Strashko
2017-07-24 22:16   ` Grygorii Strashko
2017-07-24 22:16   ` Grygorii Strashko
2017-07-25  7:10   ` Tony Lindgren
2017-07-25  7:10     ` Tony Lindgren
2017-07-25  8:56     ` Tony Lindgren
2017-07-25  8:56       ` Tony Lindgren
2017-07-25 17:41       ` Grygorii Strashko
2017-07-25 17:41         ` Grygorii Strashko
2017-07-25 17:41         ` Grygorii Strashko
2017-07-25  8:24   ` Johan Hovold
2017-07-25  8:24     ` Johan Hovold
2017-07-25 17:48     ` Grygorii Strashko
2017-07-25 17:48       ` Grygorii Strashko
2017-07-25 17:48       ` Grygorii Strashko
2017-07-26  7:50       ` Johan Hovold
2017-07-26  7:50         ` Johan Hovold
2017-07-26  8:17         ` Tony Lindgren
2017-07-26  8:17           ` Tony Lindgren
2017-07-26  8:35           ` Johan Hovold [this message]
2017-07-26  8:35             ` Johan Hovold
2017-08-10 15:08             ` Tony Lindgren
2017-08-10 15:08               ` Tony Lindgren
2017-07-25  8:55 ` Tony Lindgren
2017-07-25  8:55   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726083521.GE27516@localhost \
    --to=johan@kernel.org \
    --cc=d-gerlach@ti.com \
    --cc=grygorii.strashko@ti.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.