From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Tony Lindgren <tony@atomide.com>,
Sebastian Reichel <sre@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCHv1 02/14] drm/omap: drop incorrect comment
Date: Wed, 26 Jul 2017 12:40:00 +0200 [thread overview]
Message-ID: <20170726104000.GB3598@amd> (raw)
In-Reply-To: <20170724173311.27170-3-sebastian.reichel@collabora.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1235 bytes --]
On Mon 2017-07-24 19:32:59, Sebastian Reichel wrote:
> The wrappers have been removed in commit 5a35876e2830
> (drm: omapdrm: Remove manual update display support)
> and will not be reintroduced, since the normal sys
> functions properly call the dirty callback.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index daf81a0a2899..929a3ef0fba0 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -84,9 +84,6 @@ static struct fb_ops omap_fb_ops = {
> .owner = THIS_MODULE,
> DRM_FB_HELPER_DEFAULT_OPS,
>
> - /* Note: to properly handle manual update displays, we wrap the
> - * basic fbdev ops which write to the framebuffer
> - */
> .fb_read = drm_fb_helper_sys_read,
> .fb_write = drm_fb_helper_sys_write,
> .fb_fillrect = drm_fb_helper_sys_fillrect,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv1 02/14] drm/omap: drop incorrect comment
Date: Wed, 26 Jul 2017 12:40:00 +0200 [thread overview]
Message-ID: <20170726104000.GB3598@amd> (raw)
In-Reply-To: <20170724173311.27170-3-sebastian.reichel@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
On Mon 2017-07-24 19:32:59, Sebastian Reichel wrote:
> The wrappers have been removed in commit 5a35876e2830
> (drm: omapdrm: Remove manual update display support)
> and will not be reintroduced, since the normal sys
> functions properly call the dirty callback.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index daf81a0a2899..929a3ef0fba0 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -84,9 +84,6 @@ static struct fb_ops omap_fb_ops = {
> .owner = THIS_MODULE,
> DRM_FB_HELPER_DEFAULT_OPS,
>
> - /* Note: to properly handle manual update displays, we wrap the
> - * basic fbdev ops which write to the framebuffer
> - */
> .fb_read = drm_fb_helper_sys_read,
> .fb_write = drm_fb_helper_sys_write,
> .fb_fillrect = drm_fb_helper_sys_fillrect,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-07-26 10:40 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 17:32 [PATCHv1 00/14] omapdrm: DSI command mode panel support Sebastian Reichel
2017-07-24 17:32 ` [PATCHv1 01/14] drm/omap: remove unused function defines Sebastian Reichel
2017-07-26 10:39 ` Pavel Machek
2017-12-01 12:30 ` Tomi Valkeinen
2017-12-01 12:30 ` Tomi Valkeinen
2017-07-24 17:32 ` [PATCHv1 02/14] drm/omap: drop incorrect comment Sebastian Reichel
2017-07-26 10:40 ` Pavel Machek [this message]
2017-07-26 10:40 ` Pavel Machek
2017-07-24 17:33 ` [PATCHv1 03/14] drm/omap: plane: update fifo size on ovl setup Sebastian Reichel
2017-12-01 12:10 ` Tomi Valkeinen
2017-12-01 12:10 ` Tomi Valkeinen
2017-12-01 12:25 ` Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 04/14] drm/omap: add framedone interrupt support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 05/14] drm/omap: add manual update detection helper Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 06/14] drm/omap: add support for manually updated displays Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 07/14] drm/omap: add support for physical size hints from display drivers Sebastian Reichel
2017-07-26 10:41 ` Pavel Machek
2017-07-26 10:41 ` Pavel Machek
2017-07-24 17:33 ` [PATCHv1 08/14] drm/omap: panel-dsi-cm: fix driver Sebastian Reichel
2017-12-01 12:28 ` Tomi Valkeinen
2017-12-01 12:28 ` Tomi Valkeinen
2017-07-24 17:33 ` [PATCHv1 09/14] drm/omap: panel-dsi-cm: add regulator support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 10/14] drm/omap: panel-dsi-cm: add physical size support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 11/14] drm/omap: panel-dsi-cm: add external backlight support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 12/14] drm/omap: panel-dsi-cm: switch to gpiod Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 13/14] ARM: dts: omap4-droid4: improve LCD description Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 14/14] ARM: dts: n950: add display support Sebastian Reichel
2017-07-26 10:41 ` Pavel Machek
2017-07-27 12:02 ` [PATCHv1 00/14] omapdrm: DSI command mode panel support Tony Lindgren
2017-09-29 13:26 ` Sebastian Reichel
2017-10-12 8:45 ` Tomi Valkeinen
2017-10-12 8:45 ` Tomi Valkeinen
2017-10-13 17:12 ` Tony Lindgren
2017-10-23 22:01 ` Sebastian Reichel
2017-10-26 11:59 ` Tomi Valkeinen
2017-10-26 11:59 ` Tomi Valkeinen
2017-10-27 18:00 ` Sebastian Reichel
2017-11-06 10:29 ` Pavel Machek
2017-12-01 12:58 ` Tomi Valkeinen
2017-12-01 12:58 ` Tomi Valkeinen
2017-12-08 18:01 ` Sebastian Reichel
2017-12-11 8:30 ` Tomi Valkeinen
2017-12-11 8:30 ` Tomi Valkeinen
2018-02-08 9:41 ` Pavel Machek
2018-02-08 10:53 ` Tomi Valkeinen
2018-02-08 10:53 ` Tomi Valkeinen
2018-02-08 18:30 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726104000.GB3598@amd \
--to=pavel@ucw.cz \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.