All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH][V2] dm, dax: Make sure dm_dax_flush() is called if device supports it
Date: Wed, 26 Jul 2017 10:46:39 -0400	[thread overview]
Message-ID: <20170726144639.GA32510@redhat.com> (raw)
In-Reply-To: <20170726133509.GA5416-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Wed, Jul 26 2017 at  9:35am -0400,
Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:

> Right now, dm_dax_flush() is not being called and I think it is not being
> called becuase DAXDEV_WRITE_CACHE is not set on dm dax device.
> 
> If underlying dax device supports write cache, set DAXDEV_WRITE_CACHE on
> dm dax device. This will get dm_dax_flush() being called.
> 
> Acked-by: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

I tweaked the header a bit and staged for 4.13-rc3 here:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-4.13/dm&id=325ab51b81ca2a84ffd434652273eb5d8a8a5750

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: dm-devel@redhat.com, linux-nvdimm@lists.01.org
Subject: Re: [PATCH][V2] dm, dax: Make sure dm_dax_flush() is called if device supports it
Date: Wed, 26 Jul 2017 10:46:39 -0400	[thread overview]
Message-ID: <20170726144639.GA32510@redhat.com> (raw)
In-Reply-To: <20170726133509.GA5416@redhat.com>

On Wed, Jul 26 2017 at  9:35am -0400,
Vivek Goyal <vgoyal@redhat.com> wrote:

> Right now, dm_dax_flush() is not being called and I think it is not being
> called becuase DAXDEV_WRITE_CACHE is not set on dm dax device.
> 
> If underlying dax device supports write cache, set DAXDEV_WRITE_CACHE on
> dm dax device. This will get dm_dax_flush() being called.
> 
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

I tweaked the header a bit and staged for 4.13-rc3 here:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-4.13/dm&id=325ab51b81ca2a84ffd434652273eb5d8a8a5750

Thanks!
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2017-07-26 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 13:35 [PATCH][V2] dm, dax: Make sure dm_dax_flush() is called if device supports it Vivek Goyal
2017-07-26 13:35 ` [PATCH][V2] dm,dax: " Vivek Goyal
     [not found] ` <20170726133509.GA5416-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-26 14:46   ` Mike Snitzer [this message]
2017-07-26 14:46     ` [PATCH][V2] dm, dax: " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726144639.GA32510@redhat.com \
    --to=snitzer-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.