From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Jason Wang" <jasowang@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH for 2.10 v2 07/20] net/eth: fix incorrect check of iov_to_buf() return value
Date: Wed, 26 Jul 2017 23:42:12 -0300 [thread overview]
Message-ID: <20170727024224.22900-8-f4bug@amsat.org> (raw)
In-Reply-To: <20170727024224.22900-1-f4bug@amsat.org>
So we have sizeof(struct in6_address) != sizeof(uintptr_t)
and Clang > Coverity on this, see 4555ca6816c :)
net/eth.c:426:30: warning: The code calls sizeof() on a pointer type. This can produce an unexpected result
return bytes_read == sizeof(dst_addr);
^ ~~~~~~~~~~
net/eth.c:475:34: warning: The code calls sizeof() on a pointer type. This can produce an unexpected result
return bytes_read == sizeof(src_addr);
^ ~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
---
net/eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 5b9ba26a56..ae5d881aae 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -423,7 +423,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags,
rthdr_offset + sizeof(*ext_hdr),
dst_addr, sizeof(*dst_addr));
- return bytes_read == sizeof(dst_addr);
+ return bytes_read == sizeof(*dst_addr);
}
return false;
@@ -472,7 +472,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags,
opt_offset + sizeof(opthdr),
src_addr, sizeof(*src_addr));
- return bytes_read == sizeof(src_addr);
+ return bytes_read == sizeof(*src_addr);
}
opt_offset += optlen;
--
2.13.3
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Jason Wang" <jasowang@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH for 2.10 v2 07/20] net/eth: fix incorrect check of iov_to_buf() return value
Date: Wed, 26 Jul 2017 23:42:12 -0300 [thread overview]
Message-ID: <20170727024224.22900-8-f4bug@amsat.org> (raw)
In-Reply-To: <20170727024224.22900-1-f4bug@amsat.org>
So we have sizeof(struct in6_address) != sizeof(uintptr_t)
and Clang > Coverity on this, see 4555ca6816c :)
net/eth.c:426:30: warning: The code calls sizeof() on a pointer type. This can produce an unexpected result
return bytes_read == sizeof(dst_addr);
^ ~~~~~~~~~~
net/eth.c:475:34: warning: The code calls sizeof() on a pointer type. This can produce an unexpected result
return bytes_read == sizeof(src_addr);
^ ~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
---
net/eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 5b9ba26a56..ae5d881aae 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -423,7 +423,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags,
rthdr_offset + sizeof(*ext_hdr),
dst_addr, sizeof(*dst_addr));
- return bytes_read == sizeof(dst_addr);
+ return bytes_read == sizeof(*dst_addr);
}
return false;
@@ -472,7 +472,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags,
opt_offset + sizeof(opthdr),
src_addr, sizeof(*src_addr));
- return bytes_read == sizeof(src_addr);
+ return bytes_read == sizeof(*src_addr);
}
opt_offset += optlen;
--
2.13.3
next prev parent reply other threads:[~2017-07-27 2:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 2:42 [Qemu-trivial] [PATCH for 2.10 v2 00/20] fix bugs reported by Clang Static Analyzer Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 01/20] tests: add missing dependency to build QTEST_QEMU_BINARY Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 02/20] loader: check get_image_size() return value Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 03/20] ivshmem: fix incorrect error handling in ivshmem_recv_msg() Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 04/20] nbd: fix memory leak in nbd_opt_go() Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 11:25 ` [Qemu-trivial] " Eric Blake
2017-07-27 11:25 ` [Qemu-devel] " Eric Blake
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 05/20] qcow2: fix null pointer dereference Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 06/20] ui/vnc: fix leak of SocketAddress ** Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` Philippe Mathieu-Daudé [this message]
2017-07-27 2:42 ` [Qemu-devel] [PATCH for 2.10 v2 07/20] net/eth: fix incorrect check of iov_to_buf() return value Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 08/20] vfio/platform: fix use of freed memory Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 09/20] vfio/pci: " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 10/20] m68k/translate: fix incorrect copy/paste Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 4:55 ` [Qemu-trivial] " Richard Henderson
2017-07-27 4:55 ` [Qemu-devel] " Richard Henderson
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 11/20] linux-user/sh4: fix incorrect memory write Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 12/20] syscall: fix dereference of undefined pointer Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 6:39 ` [Qemu-trivial] " Laurent Vivier
2017-07-27 6:39 ` [Qemu-devel] " Laurent Vivier
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 13/20] syscall: fix use of uninitialized values Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 14/20] syscall: check inotify() and eventfd() return value Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 6:39 ` [Qemu-trivial] " Laurent Vivier
2017-07-27 6:39 ` [Qemu-devel] " Laurent Vivier
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 15/20] thunk: assert nb_fields is valid Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 17/20] bt-sdp: fix memory leak in sdp_service_record_build() Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 14:54 ` [Qemu-trivial] " Paolo Bonzini
2017-07-27 14:54 ` Paolo Bonzini
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 18/20] 9pfs: avoid sign conversion error simplifying the code Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 11:40 ` [Qemu-trivial] " Greg Kurz
2017-07-27 11:40 ` [Qemu-devel] " Greg Kurz
2017-07-27 19:18 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2017-07-27 19:18 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-28 7:49 ` Greg Kurz
2017-07-28 7:49 ` [Qemu-devel] " Greg Kurz
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 19/20] spapr_vio: fix overflow of qdevs in spapr_dt_vdevice() Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 3:43 ` [Qemu-trivial] " David Gibson
2017-07-27 3:43 ` [Qemu-devel] " David Gibson
2017-07-27 4:35 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2017-07-27 4:35 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-trivial] [PATCH for 2.10 v2 20/20] i2c/exynos4210: fix write to I2CADD register, bit 0 is not mapped Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-07-27 2:42 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-07-28 11:44 ` [Qemu-trivial] " Michael Tokarev
2017-07-28 11:44 ` [Qemu-devel] " Michael Tokarev
2017-07-28 11:44 ` [Qemu-arm] " Michael Tokarev
2017-07-28 11:45 ` [Qemu-trivial] [PATCH for 2.10 v2 00/20] fix bugs reported by Clang Static Analyzer Michael Tokarev
2017-07-28 11:45 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727024224.22900-8-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=dmitry@daynix.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.