From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [-next] rtlwifi: kfree entry until after entry->bssid has been accessed
Date: Thu, 27 Jul 2017 10:58:35 +0000 [thread overview]
Message-ID: <20170727105836.02AB5607C8@smtp.codeaurora.org> (raw)
In-Reply-To: <20170630100843.9188-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current code kfree's entry and then dereferences it by accessing
> entry->bssid. Avoid the dereference-after-free by moving the kfree
> after the access to entry->bssid.
>
> Detected by CoverityScan, CID#1448600 ("Read from pointer after free")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
d0116f6f7b30 rtlwifi: kfree entry until after entry->bssid has been accessed
--
https://patchwork.kernel.org/patch/9819083/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [-next] rtlwifi: kfree entry until after entry->bssid has been accessed
Date: Thu, 27 Jul 2017 10:58:35 +0000 (UTC) [thread overview]
Message-ID: <20170727105836.02AB5607C8@smtp.codeaurora.org> (raw)
In-Reply-To: <20170630100843.9188-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current code kfree's entry and then dereferences it by accessing
> entry->bssid. Avoid the dereference-after-free by moving the kfree
> after the access to entry->bssid.
>
> Detected by CoverityScan, CID#1448600 ("Read from pointer after free")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
d0116f6f7b30 rtlwifi: kfree entry until after entry->bssid has been accessed
--
https://patchwork.kernel.org/patch/9819083/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-07-27 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 10:08 [PATCH][-next] rtlwifi: kfree entry until after entry->bssid has been accessed Colin King
2017-06-30 10:08 ` Colin King
2017-07-27 10:58 ` Kalle Valo [this message]
2017-07-27 10:58 ` [-next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727105836.02AB5607C8@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.