From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"willy@infradead.org" <willy@infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"hirofumi@mail.parknet.co.jp" <hirofumi@mail.parknet.co.jp>
Subject: Re: FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305!
Date: Thu, 27 Jul 2017 12:03:55 -0600 [thread overview]
Message-ID: <20170727180355.GB26633@linux.intel.com> (raw)
In-Reply-To: <1501171371.2042.83.camel@hpe.com>
On Thu, Jul 27, 2017 at 04:12:18PM +0000, Kani, Toshimitsu wrote:
> On Wed, 2017-07-26 at 10:11 -0700, Matthew Wilcox wrote:
> > On Wed, Jul 26, 2017 at 06:23:08PM +0900, OGAWA Hirofumi wrote:
> > > The locking of this path seems to be broken. The guy familiar to
> > > bdev_write_page() path will made real fix though, The following
> > > patch should be explaining enough what is wrong.
> > >
> > > In short, clean_buffers() must be called before unlocking
> > > lock_page().
> >
> > Thanks for that. This should fix the problem while not leaking the
> > unlock_page call outside bdev_write_page.
> >
> > --- 8< ---
> >
> > Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>
> Thanks Willy and Hirofumi for the quick fix! I've tested the change,
> and it works fine.
>
> Tested-by: Toshi Kani <toshi.kani@hpe.com>
>
> Out of curiosity, I am still wondering about the following:
> - Why is this issue exposed with FAT FS, but not with other FSs?
> - Why did I not see this issue with BTT?
I also didn't see it with FAT + BRD, so I think the answer to both of the
above is just that the timings were different.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>
Cc: "hirofumi@mail.parknet.co.jp" <hirofumi@mail.parknet.co.jp>,
"willy@infradead.org" <willy@infradead.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305!
Date: Thu, 27 Jul 2017 12:03:55 -0600 [thread overview]
Message-ID: <20170727180355.GB26633@linux.intel.com> (raw)
In-Reply-To: <1501171371.2042.83.camel@hpe.com>
On Thu, Jul 27, 2017 at 04:12:18PM +0000, Kani, Toshimitsu wrote:
> On Wed, 2017-07-26 at 10:11 -0700, Matthew Wilcox wrote:
> > On Wed, Jul 26, 2017 at 06:23:08PM +0900, OGAWA Hirofumi wrote:
> > > The locking of this path seems to be broken. The guy familiar to
> > > bdev_write_page() path will made real fix though, The following
> > > patch should be explaining enough what is wrong.
> > >
> > > In short, clean_buffers() must be called before unlocking
> > > lock_page().
> >
> > Thanks for that.��This should fix the problem while not leaking the
> > unlock_page call outside bdev_write_page.
> >
> > --- 8< ---
> >
> > Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>
> Thanks Willy and Hirofumi for the quick fix! I've tested the change,
> and it works fine.
>
> Tested-by: Toshi Kani <toshi.kani@hpe.com>
>
> Out of curiosity, I am still wondering about the following:�
> - Why is this issue exposed with FAT FS, but not with other FSs?
> - Why did I not see this issue with BTT?
I also didn't see it with FAT + BRD, so I think the answer to both of the
above is just that the timings were different.
next prev parent reply other threads:[~2017-07-27 18:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 21:37 FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305! Kani, Toshimitsu
2017-07-25 21:37 ` Kani, Toshimitsu
2017-07-25 22:22 ` Ross Zwisler
2017-07-25 22:22 ` Ross Zwisler
2017-07-25 22:27 ` Kani, Toshimitsu
2017-07-25 22:27 ` Kani, Toshimitsu
2017-07-26 8:21 ` Johannes Thumshirn
2017-07-26 8:21 ` Johannes Thumshirn
2017-07-26 9:23 ` OGAWA Hirofumi
2017-07-26 9:23 ` OGAWA Hirofumi
2017-07-26 14:23 ` Ross Zwisler
2017-07-26 14:23 ` Ross Zwisler
2017-07-26 16:08 ` Dan Williams
2017-07-26 16:08 ` Dan Williams
2017-07-26 17:03 ` Christoph Hellwig
2017-07-26 17:03 ` Christoph Hellwig
2017-07-26 17:11 ` Matthew Wilcox
2017-07-26 17:11 ` Matthew Wilcox
2017-07-27 16:12 ` Kani, Toshimitsu
2017-07-27 16:12 ` Kani, Toshimitsu
2017-07-27 18:03 ` Ross Zwisler [this message]
2017-07-27 18:03 ` Ross Zwisler
2017-07-27 18:20 ` Kani, Toshimitsu
2017-07-27 18:20 ` Kani, Toshimitsu
2017-09-20 21:04 ` Kani, Toshimitsu
2017-09-20 21:04 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727180355.GB26633@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=toshi.kani@hpe.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.