All of lore.kernel.org
 help / color / mirror / Atom feed
From: jnair@caviumnetworks.com (Jayachandran C)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: cavium: fix PCI bus dtc warnings
Date: Fri, 28 Jul 2017 01:43:05 +0000	[thread overview]
Message-ID: <20170728014304.GA6857@localhost> (raw)
In-Reply-To: <20170726210943.6875-7-robh@kernel.org>

On Wed, Jul 26, 2017 at 04:09:43PM -0500, Rob Herring wrote:
> dtc recently added PCI bus checks. Fix these warnings:
> 
> arch/arm64/boot/dts/cavium/thunder2-99xx.dtb: Warning (pci_bridge): Node /pci missing bus-range for PCI bridge
> arch/arm64/boot/dts/cavium/thunder2-99xx.dtb: Warning (unit_address_vs_reg): Node /pci has a reg or ranges property, but no unit name
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Jayachandran C <jnair@caviumnetworks.com>
> ---
> v2:
> - Reapply broadcom vulkan changes to thunder2.
> 
>  arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> index 4220fbdcb24a..ea50c1320bf7 100644
> --- a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> +++ b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> @@ -98,7 +98,7 @@
>  		clock-output-names = "clk125mhz";
>  	};
>  
> -	pci {
> +	pci at 30000000 {
>  		compatible = "pci-host-ecam-generic";
>  		device_type = "pci";
>  		#interrupt-cells = <1>;
> @@ -118,6 +118,7 @@
>  		ranges =
>  		  <0x02000000    0 0x40000000    0 0x40000000    0 0x20000000
>  		   0x43000000 0x40 0x00000000 0x40 0x00000000 0x20 0x00000000>;
> +		bus-range = <0 0xff>;
>  		interrupt-map-mask = <0 0 0 7>;
>  		interrupt-map =
>  		      /* addr  pin  ic   icaddr  icintr */

Thanks for fixing this up.

Acked-by: Jayachandran C <jnair@caviumnetworks.com>

The unit name issue is there with memory node on thunder2-99xx.dts as well, I can fix
this up if you are not planning to.

JC

WARNING: multiple messages have this Message-ID (diff)
From: Jayachandran C <jnair-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v2] arm64: dts: cavium: fix PCI bus dtc warnings
Date: Fri, 28 Jul 2017 01:43:05 +0000	[thread overview]
Message-ID: <20170728014304.GA6857@localhost> (raw)
In-Reply-To: <20170726210943.6875-7-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On Wed, Jul 26, 2017 at 04:09:43PM -0500, Rob Herring wrote:
> dtc recently added PCI bus checks. Fix these warnings:
> 
> arch/arm64/boot/dts/cavium/thunder2-99xx.dtb: Warning (pci_bridge): Node /pci missing bus-range for PCI bridge
> arch/arm64/boot/dts/cavium/thunder2-99xx.dtb: Warning (unit_address_vs_reg): Node /pci has a reg or ranges property, but no unit name
> 
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Jayachandran C <jnair-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
> ---
> v2:
> - Reapply broadcom vulkan changes to thunder2.
> 
>  arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> index 4220fbdcb24a..ea50c1320bf7 100644
> --- a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> +++ b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> @@ -98,7 +98,7 @@
>  		clock-output-names = "clk125mhz";
>  	};
>  
> -	pci {
> +	pci@30000000 {
>  		compatible = "pci-host-ecam-generic";
>  		device_type = "pci";
>  		#interrupt-cells = <1>;
> @@ -118,6 +118,7 @@
>  		ranges =
>  		  <0x02000000    0 0x40000000    0 0x40000000    0 0x20000000
>  		   0x43000000 0x40 0x00000000 0x40 0x00000000 0x20 0x00000000>;
> +		bus-range = <0 0xff>;
>  		interrupt-map-mask = <0 0 0 7>;
>  		interrupt-map =
>  		      /* addr  pin  ic   icaddr  icintr */

Thanks for fixing this up.

Acked-by: Jayachandran C <jnair-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>

The unit name issue is there with memory node on thunder2-99xx.dts as well, I can fix
this up if you are not planning to.

JC
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-07-28  1:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 21:09 [PATCH v2] ARM: dts: marvell: fix PCI bus dtc warnings Rob Herring
2017-07-26 21:09 ` Rob Herring
     [not found] ` <20170726210943.6875-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-26 21:09   ` [PATCH v2] ARM: dts: exynos: " Rob Herring
2017-07-26 21:09     ` Rob Herring
2017-07-28  5:53     ` Krzysztof Kozlowski
2017-07-28  5:53       ` Krzysztof Kozlowski
2017-07-26 21:09 ` [PATCH v2] ARM: dts: spear13xx: " Rob Herring
2017-07-26 21:09   ` Rob Herring
2017-08-18 21:16   ` Arnd Bergmann
2017-08-18 21:16     ` Arnd Bergmann
2017-07-26 21:09 ` [PATCH v2] ARM: dts: versatile: " Rob Herring
2017-07-26 21:09   ` Rob Herring
2017-08-18 21:17   ` Arnd Bergmann
2017-08-18 21:17     ` Arnd Bergmann
2017-07-26 21:09 ` [PATCH v2] arm64: dts: apm: " Rob Herring
2017-07-26 21:09   ` Rob Herring
2017-08-18 21:18   ` Arnd Bergmann
2017-08-18 21:18     ` Arnd Bergmann
2017-07-26 21:09 ` [PATCH v2] arm64: dts: xilinx: " Rob Herring
2017-07-26 21:09   ` Rob Herring
2017-07-27  6:22   ` Michal Simek
2017-07-27  6:22     ` Michal Simek
2017-07-26 21:09 ` [PATCH v2] arm64: dts: cavium: " Rob Herring
2017-07-26 21:09   ` Rob Herring
2017-07-28  1:43   ` Jayachandran C [this message]
2017-07-28  1:43     ` Jayachandran C
2017-07-28  2:15     ` Rob Herring
2017-07-28  2:15       ` Rob Herring
2017-07-29 20:35       ` [PATCH] arm64: dts: cavium: fix memory node " Jayachandran C
2017-07-29 20:35         ` Jayachandran C
2017-08-03 13:14 ` [PATCH v2] ARM: dts: marvell: fix PCI bus " Gregory CLEMENT
2017-08-03 13:14   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728014304.GA6857@localhost \
    --to=jnair@caviumnetworks.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.