All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
Date: Fri, 28 Jul 2017 15:55:44 +0200	[thread overview]
Message-ID: <20170728135544.GD32230@lunn.ch> (raw)
In-Reply-To: <20170728092818.23419-1-clabbe.montjoie@gmail.com>

On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
> Hello
> 
> The current way to find if the phy is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the internal one.
> 
> This patchs series adds a new way to find if the PHY is internal, via its
> compatible.

http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144

Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
warning. But still, your device tree gives the wrong idea.

I've probably asked this before: Does the internal PHY use a different
PHY ID in registers 2 and 3?

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
	alexandre.torgue-qxv4g6HH51o@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	icenowy-h8G6r0blFSE@public.gmane.org
Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
Date: Fri, 28 Jul 2017 15:55:44 +0200	[thread overview]
Message-ID: <20170728135544.GD32230@lunn.ch> (raw)
In-Reply-To: <20170728092818.23419-1-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
> Hello
> 
> The current way to find if the phy is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the internal one.
> 
> This patchs series adds a new way to find if the PHY is internal, via its
> compatible.

http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144

Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
warning. But still, your device tree gives the wrong idea.

I've probably asked this before: Does the internal PHY use a different
PHY ID in registers 2 and 3?

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	maxime.ripard@free-electrons.com, wens@csie.org,
	linux@armlinux.org.uk, peppe.cavallaro@st.com,
	alexandre.torgue@st.com, devicetree@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com,
	linux-arm-kernel@lists.infradead.org, icenowy@aosc.io
Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
Date: Fri, 28 Jul 2017 15:55:44 +0200	[thread overview]
Message-ID: <20170728135544.GD32230@lunn.ch> (raw)
In-Reply-To: <20170728092818.23419-1-clabbe.montjoie@gmail.com>

On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
> Hello
> 
> The current way to find if the phy is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the internal one.
> 
> This patchs series adds a new way to find if the PHY is internal, via its
> compatible.

http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144

Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
warning. But still, your device tree gives the wrong idea.

I've probably asked this before: Does the internal PHY use a different
PHY ID in registers 2 and 3?

    Andrew

  parent reply	other threads:[~2017-07-28 13:55 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28  9:28 [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Corentin Labbe
2017-07-28  9:28 ` Corentin Labbe
2017-07-28  9:28 ` Corentin Labbe
2017-07-28  9:28 ` [PATCH 1/3] dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs Corentin Labbe
2017-07-28  9:28   ` Corentin Labbe
2017-07-28  9:28   ` Corentin Labbe
2017-07-28  9:28 ` [PATCH 2/3] ARM: sunxi: h3/h5: Add sun8i-h3-ephy compatible Corentin Labbe
2017-07-28  9:28   ` Corentin Labbe
2017-07-28  9:28   ` Corentin Labbe
2017-07-28  9:44   ` Chen-Yu Tsai
2017-07-28  9:44     ` Chen-Yu Tsai
2017-07-28  9:46     ` Icenowy Zheng
2017-07-28  9:46       ` Icenowy Zheng
2017-07-28  9:46       ` Icenowy Zheng
2017-07-28  9:28 ` [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Corentin Labbe
2017-07-28  9:28   ` Corentin Labbe
2017-07-28  9:28   ` Corentin Labbe
2017-07-28  9:49   ` Chen-Yu Tsai
2017-07-28  9:49     ` Chen-Yu Tsai
2017-07-28  9:49     ` Chen-Yu Tsai
2017-07-28  9:54     ` Corentin Labbe
2017-07-28  9:54       ` Corentin Labbe
2017-07-28  9:54       ` Corentin Labbe
2017-07-28  9:53 ` [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Chen-Yu Tsai
2017-07-28  9:53   ` Chen-Yu Tsai
2017-07-28  9:53   ` Chen-Yu Tsai
2017-07-28 13:47   ` Andrew Lunn
2017-07-28 13:47     ` Andrew Lunn
2017-07-28 13:47     ` Andrew Lunn
2017-07-28 13:55 ` Andrew Lunn [this message]
2017-07-28 13:55   ` Andrew Lunn
2017-07-28 13:55   ` Andrew Lunn
2017-07-28 14:25   ` Corentin Labbe
2017-07-28 14:25     ` Corentin Labbe
2017-07-28 14:25     ` Corentin Labbe
2017-07-28 14:36     ` Andrew Lunn
2017-07-28 14:36       ` Andrew Lunn
2017-07-28 14:36       ` Andrew Lunn
2017-07-28 14:44       ` Corentin Labbe
2017-07-28 14:44         ` Corentin Labbe
2017-07-28 14:44         ` Corentin Labbe
2017-07-28 14:51         ` Andrew Lunn
2017-07-28 14:51           ` Andrew Lunn
2017-07-28 14:51           ` Andrew Lunn
2017-07-28 17:54         ` Florian Fainelli
2017-07-28 17:54           ` Florian Fainelli
2017-07-28 17:54           ` Florian Fainelli
2017-07-29  6:48           ` Corentin Labbe
2017-07-29  6:48             ` Corentin Labbe
2017-07-29  6:48             ` Corentin Labbe
2017-07-31 12:19             ` Chen-Yu Tsai
2017-07-31 12:19               ` Chen-Yu Tsai
2017-07-31 12:19               ` Chen-Yu Tsai
2017-07-31 12:26               ` Corentin Labbe
2017-07-31 12:26                 ` Corentin Labbe
2017-07-31 12:26                 ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728135544.GD32230@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.