All of lore.kernel.org
 help / color / mirror / Atom feed
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org,
	Marcus Cooper
	<codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v3 11/12] ASoC: sun4i-i2s: Update global enable with bitmask
Date: Sat, 29 Jul 2017 16:17:52 +0200	[thread overview]
Message-ID: <20170729141753.20174-12-codekipper@gmail.com> (raw)
In-Reply-To: <20170729141753.20174-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

The default value of the config register is different on newer
SoCs and therefore enabling/disabling with a register write
will clear bits used to set the direction of the clock and frame
pins.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 sound/soc/sunxi/sun4i-i2s.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 1c4d763e3a8e..d8bcd3d9c2b6 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -527,8 +527,8 @@ static int sun4i_i2s_startup(struct snd_pcm_substream *substream,
 	struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
 	/* Enable the whole hardware block */
-	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
-		     SUN4I_I2S_CTRL_GL_EN);
+	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+			   SUN4I_I2S_CTRL_GL_EN, SUN4I_I2S_CTRL_GL_EN);
 
 	/* Enable the first output line */
 	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
@@ -551,7 +551,8 @@ static void sun4i_i2s_shutdown(struct snd_pcm_substream *substream,
 			   SUN4I_I2S_CTRL_SDO_EN_MASK, 0);
 
 	/* Disable the whole hardware block */
-	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG, 0);
+	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+			   SUN4I_I2S_CTRL_GL_EN, 0);
 }
 
 static int sun4i_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
-- 
2.13.3

WARNING: multiple messages have this Message-ID (diff)
From: codekipper@gmail.com (codekipper at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 11/12] ASoC: sun4i-i2s: Update global enable with bitmask
Date: Sat, 29 Jul 2017 16:17:52 +0200	[thread overview]
Message-ID: <20170729141753.20174-12-codekipper@gmail.com> (raw)
In-Reply-To: <20170729141753.20174-1-codekipper@gmail.com>

From: Marcus Cooper <codekipper@gmail.com>

The default value of the config register is different on newer
SoCs and therefore enabling/disabling with a register write
will clear bits used to set the direction of the clock and frame
pins.

Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
 sound/soc/sunxi/sun4i-i2s.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 1c4d763e3a8e..d8bcd3d9c2b6 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -527,8 +527,8 @@ static int sun4i_i2s_startup(struct snd_pcm_substream *substream,
 	struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
 	/* Enable the whole hardware block */
-	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
-		     SUN4I_I2S_CTRL_GL_EN);
+	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+			   SUN4I_I2S_CTRL_GL_EN, SUN4I_I2S_CTRL_GL_EN);
 
 	/* Enable the first output line */
 	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
@@ -551,7 +551,8 @@ static void sun4i_i2s_shutdown(struct snd_pcm_substream *substream,
 			   SUN4I_I2S_CTRL_SDO_EN_MASK, 0);
 
 	/* Disable the whole hardware block */
-	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG, 0);
+	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+			   SUN4I_I2S_CTRL_GL_EN, 0);
 }
 
 static int sun4i_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
-- 
2.13.3

WARNING: multiple messages have this Message-ID (diff)
From: codekipper@gmail.com
To: maxime.ripard@free-electrons.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, lgirdwood@gmail.com,
	broonie@kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, be17068@iperbole.bo.it,
	Marcus Cooper <codekipper@gmail.com>
Subject: [PATCH v3 11/12] ASoC: sun4i-i2s: Update global enable with bitmask
Date: Sat, 29 Jul 2017 16:17:52 +0200	[thread overview]
Message-ID: <20170729141753.20174-12-codekipper@gmail.com> (raw)
In-Reply-To: <20170729141753.20174-1-codekipper@gmail.com>

From: Marcus Cooper <codekipper@gmail.com>

The default value of the config register is different on newer
SoCs and therefore enabling/disabling with a register write
will clear bits used to set the direction of the clock and frame
pins.

Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
 sound/soc/sunxi/sun4i-i2s.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 1c4d763e3a8e..d8bcd3d9c2b6 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -527,8 +527,8 @@ static int sun4i_i2s_startup(struct snd_pcm_substream *substream,
 	struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 
 	/* Enable the whole hardware block */
-	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
-		     SUN4I_I2S_CTRL_GL_EN);
+	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+			   SUN4I_I2S_CTRL_GL_EN, SUN4I_I2S_CTRL_GL_EN);
 
 	/* Enable the first output line */
 	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
@@ -551,7 +551,8 @@ static void sun4i_i2s_shutdown(struct snd_pcm_substream *substream,
 			   SUN4I_I2S_CTRL_SDO_EN_MASK, 0);
 
 	/* Disable the whole hardware block */
-	regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG, 0);
+	regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
+			   SUN4I_I2S_CTRL_GL_EN, 0);
 }
 
 static int sun4i_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
-- 
2.13.3

  parent reply	other threads:[~2017-07-29 14:17 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-29 14:17 [PATCH v3 00/12] ASoC: Add I2S support for Allwinner H3 SoCs codekipper
2017-07-29 14:17 ` codekipper
2017-07-29 14:17 ` codekipper at gmail.com
     [not found] ` <20170729141753.20174-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-29 14:17   ` [PATCH v3 01/12] ASoC: sun4i-i2s: Extend quirks scope codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-01  2:50       ` Chen-Yu Tsai
2017-08-01  2:50         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-01  2:50         ` Chen-Yu Tsai
2017-08-01 14:16     ` Applied "ASoC: sun4i-i2s: Extend quirks scope" to the asoc tree Mark Brown
2017-08-01 14:16       ` Mark Brown
2017-08-01 14:16       ` Mark Brown
2017-07-29 14:17   ` [PATCH v3 02/12] ASoC: sun4i-i2s: Add clkdiv offsets to quirks codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-01  2:55       ` Chen-Yu Tsai
2017-08-01  2:55         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-01  2:55         ` Chen-Yu Tsai
2017-08-07  6:20         ` Code Kipper
2017-08-07  6:20           ` Code Kipper
2017-07-29 14:17   ` [PATCH v3 03/12] ASoC: sun4i-i2s: Add regmap config " codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-01  8:10       ` Chen-Yu Tsai
2017-08-01  8:10         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-01  8:10         ` Chen-Yu Tsai
2017-08-14 16:43     ` Applied "ASoC: sun4i-i2s: Add regmap config to quirks" to the asoc tree Mark Brown
2017-08-14 16:43       ` Mark Brown
2017-08-14 16:43       ` Mark Brown
2017-07-29 14:17   ` [PATCH v3 04/12] ASoC: sun4i-i2s: Add TX FIFO offset to quirks codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
2017-08-01  8:18     ` [linux-sunxi] " Chen-Yu Tsai
2017-08-01  8:18       ` Chen-Yu Tsai
2017-08-01  8:18       ` Chen-Yu Tsai
2017-08-14 16:43     ` Applied "ASoC: sun4i-i2s: Add TX FIFO offset to quirks" to the asoc tree Mark Brown
2017-08-14 16:43       ` Mark Brown
2017-08-14 16:43       ` Mark Brown
2017-07-29 14:17   ` [PATCH v3 05/12] ASoC: sun4i-i2s: Add regmap fields for channels codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-30 16:43       ` [alsa-devel] " kbuild test robot
2017-07-30 16:43         ` kbuild test robot
2017-07-30 16:43         ` kbuild test robot
2017-07-30 16:43       ` [PATCH] ASoC: sun4i-i2s: fix ptr_ret.cocci warnings kbuild test robot
2017-07-30 16:43         ` kbuild test robot
2017-07-30 16:43         ` kbuild test robot
2017-08-01  8:31       ` [PATCH v3 05/12] ASoC: sun4i-i2s: Add regmap fields for channels Chen-Yu Tsai
2017-08-01  8:31         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-01  8:31         ` Chen-Yu Tsai
     [not found]         ` <CAGb2v640QLn4oDWoFeT51xJqSN7FSBP9KRNdpRB4MuATSE2rVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-07  7:39           ` Code Kipper
2017-08-07  7:39             ` [linux-sunxi] " Code Kipper
2017-08-07  7:39             ` Code Kipper
2017-07-29 14:17   ` [PATCH v3 06/12] ASoC: sun4i-i2s: Add changes for wss and sr codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-7-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-01  8:49       ` Chen-Yu Tsai
2017-08-01  8:49         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-01  8:49         ` Chen-Yu Tsai
2017-08-02  3:06       ` Chen-Yu Tsai
2017-08-02  3:06         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  3:06         ` Chen-Yu Tsai
2017-07-29 14:17   ` [PATCH v3 07/12] ASoC: sun4i-i2s: bclk and lrclk polarity tidyup codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-8-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-02  3:09       ` Chen-Yu Tsai
2017-08-02  3:09         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  3:09         ` Chen-Yu Tsai
2017-07-29 14:17   ` [PATCH v3 08/12] ASoC: sun4i-i2s: Add mclk enable regmap field codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
2017-08-02  3:20     ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  3:20       ` Chen-Yu Tsai
2017-08-02  3:20       ` Chen-Yu Tsai
2017-07-29 14:17   ` [PATCH v3 09/12] ASoC: sun4i-i2s: Add regmap field to set format codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-10-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-02  3:32       ` Chen-Yu Tsai
2017-08-02  3:32         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  3:32         ` Chen-Yu Tsai
2017-07-29 14:17   ` [PATCH v3 10/12] ASoC: sun4i-i2s: Check for slave select bit codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
2017-08-02  3:50     ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  3:50       ` Chen-Yu Tsai
2017-07-29 14:17   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w [this message]
2017-07-29 14:17     ` [PATCH v3 11/12] ASoC: sun4i-i2s: Update global enable with bitmask codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-12-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-02  3:55       ` Chen-Yu Tsai
2017-08-02  3:55         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  3:55         ` Chen-Yu Tsai
2017-07-29 14:17   ` [PATCH v3 12/12] ASoC: sun4i-i2s: Add support for H3 codekipper-Re5JQEeQqe8AvxtiuMwx3w
2017-07-29 14:17     ` codekipper
2017-07-29 14:17     ` codekipper at gmail.com
     [not found]     ` <20170729141753.20174-13-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-02  4:37       ` Chen-Yu Tsai
2017-08-02  4:37         ` [linux-sunxi] " Chen-Yu Tsai
2017-08-02  4:37         ` Chen-Yu Tsai
2017-07-31  7:05   ` [PATCH v3 00/12] ASoC: Add I2S support for Allwinner H3 SoCs Olliver Schinagl
2017-07-31  7:05     ` [linux-sunxi] " Olliver Schinagl
2017-07-31  7:05     ` Olliver Schinagl
     [not found]     ` <5a66679c-cb98-9baa-a73b-9bacd943537b-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2017-07-31 14:22       ` Code Kipper
2017-07-31 14:22         ` [linux-sunxi] " Code Kipper
2017-07-31 14:22         ` Code Kipper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170729141753.20174-12-codekipper@gmail.com \
    --to=codekipper-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.