All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Brown <matthew.brown.dev@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v4 5/5] powerpc/lib/sstep: Add isel instruction emulation
Date: Mon, 31 Jul 2017 10:58:26 +1000	[thread overview]
Message-ID: <20170731005826.32044-5-matthew.brown.dev@gmail.com> (raw)
In-Reply-To: <20170731005826.32044-1-matthew.brown.dev@gmail.com>

This adds emulation for the isel instruction.
Tested for correctness against the isel instruction and its extended
mnemonics (lt, gt, eq) on ppc64le.

Signed-off-by: Matt Brown <matthew.brown.dev@gmail.com>
---
v4:
	- simplify if statement to ternary op
	(same as isel emulation in kernel/traps.c)
v2:
	- fixed opcode
	- fixed definition to include the 'if RA=0, a=0' clause
	- fixed ccr bitshifting error
---
 arch/powerpc/lib/sstep.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
index af4eef9..473bab5 100644
--- a/arch/powerpc/lib/sstep.c
+++ b/arch/powerpc/lib/sstep.c
@@ -1240,6 +1240,14 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
 /*
  * Logical instructions
  */
+		case 15:	/* isel */
+			mb = (instr >> 6) & 0x1f; /* bc */
+			val = (regs->ccr >> (31 - mb)) & 1;
+			val2 = (ra) ? regs->gpr[ra] : 0;
+
+			regs->gpr[rd] = (val) ? val2 : regs->gpr[rb];
+			goto logical_done;
+
 		case 26:	/* cntlzw */
 			asm("cntlzw %0,%1" : "=r" (regs->gpr[ra]) :
 			    "r" (regs->gpr[rd]));
-- 
2.9.3

  parent reply	other threads:[~2017-07-31  0:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31  0:58 [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation Matt Brown
2017-07-31  0:58 ` [PATCH v4 2/5] powerpc/lib/sstep: Add popcnt " Matt Brown
2017-07-31  4:15   ` Cyril Bur
2017-07-31  0:58 ` [PATCH v4 3/5] powerpc/lib/sstep: Add bpermd " Matt Brown
2017-07-31  3:42   ` Cyril Bur
2017-07-31  0:58 ` [PATCH v4 4/5] powerpc/lib/sstep: Add prty " Matt Brown
2017-07-31  3:55   ` Cyril Bur
2017-07-31  0:58 ` Matt Brown [this message]
2017-07-31  4:11   ` [PATCH v4 5/5] powerpc/lib/sstep: Add isel " Cyril Bur
2017-07-31  1:42 ` [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb " Cyril Bur
2017-08-01 12:44 ` Segher Boessenkool
2017-08-02  1:23   ` Matt Brown
2017-08-11 12:19 ` [v4,1/5] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731005826.32044-5-matthew.brown.dev@gmail.com \
    --to=matthew.brown.dev@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.