All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Matt Brown <matthew.brown.dev@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation
Date: Tue, 1 Aug 2017 07:44:33 -0500	[thread overview]
Message-ID: <20170801124433.GI13471@gate.crashing.org> (raw)
In-Reply-To: <20170731005826.32044-1-matthew.brown.dev@gmail.com>

Hi!

On Mon, Jul 31, 2017 at 10:58:22AM +1000, Matt Brown wrote:
> @@ -1049,6 +1065,10 @@ int analyse_instr(struct instruction_op *op, struct pt_regs *regs,
>  			do_cmp_unsigned(regs, val, val2, rd >> 2);
>  			goto instr_done;
>  
> +		case 508: /* cmpb */
> +			do_cmpb(regs, regs->gpr[rd], regs->gpr[rb], ra);
> +			goto instr_done;

Should this then be under an ifdef for 64-bit?


Segher

  parent reply	other threads:[~2017-08-01 12:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31  0:58 [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation Matt Brown
2017-07-31  0:58 ` [PATCH v4 2/5] powerpc/lib/sstep: Add popcnt " Matt Brown
2017-07-31  4:15   ` Cyril Bur
2017-07-31  0:58 ` [PATCH v4 3/5] powerpc/lib/sstep: Add bpermd " Matt Brown
2017-07-31  3:42   ` Cyril Bur
2017-07-31  0:58 ` [PATCH v4 4/5] powerpc/lib/sstep: Add prty " Matt Brown
2017-07-31  3:55   ` Cyril Bur
2017-07-31  0:58 ` [PATCH v4 5/5] powerpc/lib/sstep: Add isel " Matt Brown
2017-07-31  4:11   ` Cyril Bur
2017-07-31  1:42 ` [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb " Cyril Bur
2017-08-01 12:44 ` Segher Boessenkool [this message]
2017-08-02  1:23   ` Matt Brown
2017-08-11 12:19 ` [v4,1/5] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801124433.GI13471@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=matthew.brown.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.