From: Eric Biggers <ebiggers3@gmail.com>
To: keyrings@vger.kernel.org
Subject: Re: [LTP] [PATCH] syscalls/keyctl04: new test for thread keyring memory leak
Date: Mon, 31 Jul 2017 20:57:04 +0000 [thread overview]
Message-ID: <20170731205704.GA41369@gmail.com> (raw)
In-Reply-To: <87mv7lghr8.fsf@our.domain.is.not.set>
Hi Richard, thanks for reviewing!
On Mon, Jul 31, 2017 at 09:58:19AM +0200, Richard Palethorpe wrote:
>
> Thanks for contributing this test! We now have a directory
> (testcases/cve) and runtest file dedicated to CVE regression tests. So
> please atleast add it to the CVE runtest file.
>
I'll add it to 'runtest/cve' but will leave it in the syscalls/keyctl directory.
I don't like the idea of putting "CVE regression tests" in a separate directory
because then it will be harder to find all the tests for a given syscall or
feature.
> > +#include "config.h"
> > +#ifdef HAVE_LINUX_KEYCTL_H
> > +# include <linux/keyctl.h>
> > +#endif
>
> Please just include the definitions for keyctl in the test like:
> https://github.com/richiejp/ltp/blob/cve/testcases/cve/cve-2016-7042.c
> The vulnerability is still exploitable on systems without this header.
>
> On a related note; we should create a fallback header in include/lapi
> for keyutils as there are a few tests which use it.
>
It's including the Linux UAPI header (from include/uapi/linux/keyctl.h), not
even the libkeyutils header. Is using UAPI headers really not allowed in LTP?
I see tons of other tests that include <linux/${foo}.h>.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/keyctl04: new test for thread keyring memory leak
Date: Mon, 31 Jul 2017 13:57:04 -0700 [thread overview]
Message-ID: <20170731205704.GA41369@gmail.com> (raw)
In-Reply-To: <87mv7lghr8.fsf@our.domain.is.not.set>
Hi Richard, thanks for reviewing!
On Mon, Jul 31, 2017 at 09:58:19AM +0200, Richard Palethorpe wrote:
>
> Thanks for contributing this test! We now have a directory
> (testcases/cve) and runtest file dedicated to CVE regression tests. So
> please atleast add it to the CVE runtest file.
>
I'll add it to 'runtest/cve' but will leave it in the syscalls/keyctl directory.
I don't like the idea of putting "CVE regression tests" in a separate directory
because then it will be harder to find all the tests for a given syscall or
feature.
> > +#include "config.h"
> > +#ifdef HAVE_LINUX_KEYCTL_H
> > +# include <linux/keyctl.h>
> > +#endif
>
> Please just include the definitions for keyctl in the test like:
> https://github.com/richiejp/ltp/blob/cve/testcases/cve/cve-2016-7042.c
> The vulnerability is still exploitable on systems without this header.
>
> On a related note; we should create a fallback header in include/lapi
> for keyutils as there are a few tests which use it.
>
It's including the Linux UAPI header (from include/uapi/linux/keyctl.h), not
even the libkeyutils header. Is using UAPI headers really not allowed in LTP?
I see tons of other tests that include <linux/${foo}.h>.
Eric
next prev parent reply other threads:[~2017-07-31 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 7:58 [LTP] [PATCH] syscalls/keyctl04: new test for thread keyring memory leak Richard Palethorpe
2017-07-31 7:58 ` Richard Palethorpe
2017-07-31 20:57 ` Eric Biggers [this message]
2017-07-31 20:57 ` Eric Biggers
2017-08-01 7:42 ` Richard Palethorpe
2017-08-01 7:42 ` Richard Palethorpe
-- strict thread matches above, loose matches on Subject: below --
2017-07-28 21:13 Eric Biggers
2017-07-28 21:13 ` [LTP] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731205704.GA41369@gmail.com \
--to=ebiggers3@gmail.com \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.