[PATCH v1 0/1] xen/arm: zynqmp: Disable PCIe

[PATCH v1 0/1] xen/arm: zynqmp: Disable PCIe

[Edgar E. Iglesias]

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Hi,

We're seeing panics in dom0 with PCIe enabled due to what seems
to be wrongly created mappings by Xen. With older kernels we
didn't see the panics but PCIe wasn't functional in dom0.

This disables the PCIe nodes on the ZynqMP until Xen/ARM gets
more PCIe support.

Can we get this into stable-4.8 and 4.9?

Cheers,
Edgar

Edgar E. Iglesias (1):
  xen/arm: Disable PCIe on the ZynqMP

 xen/arch/arm/platforms/xilinx-zynqmp.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH v1 1/1] xen/arm: Disable PCIe on the ZynqMP

[Edgar E. Iglesias]

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Disable PCIe on the ZynqMP. Xen does not yet know how to map the
controller and dom0 fails to boot with the node enabled.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 xen/arch/arm/platforms/xilinx-zynqmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/platforms/xilinx-zynqmp.c b/xen/arch/arm/platforms/xilinx-zynqmp.c
index 2adee91..822287b 100644
--- a/xen/arch/arm/platforms/xilinx-zynqmp.c
+++ b/xen/arch/arm/platforms/xilinx-zynqmp.c
@@ -29,6 +29,7 @@ static const struct dt_device_match zynqmp_blacklist_dev[] __initconst =
 {
     /* Power management is not yet supported.  */
     DT_MATCH_COMPATIBLE("xlnx,zynqmp-pm"),
+    DT_MATCH_COMPATIBLE("xlnx,nwl-pcie-2.11"),
     { /* sentinel */ },
 };
 
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 0/1] xen/arm: zynqmp: Disable PCIe

[Julien Grall]

On 31/07/2017 20:37, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Hi,

Hi Edgar,


> We're seeing panics in dom0 with PCIe enabled due to what seems
> to be wrongly created mappings by Xen. With older kernels we
> didn't see the panics but PCIe wasn't functional in dom0.
>
> This disables the PCIe nodes on the ZynqMP until Xen/ARM gets
> more PCIe support.

I feel a bit sad to ack a patch disabling PCIe in the ZynqMP.

Before doing that. Can you describe what is the exact problem with Xen? 
It might be possible that we don't parse correctly the device-tree.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 0/1] xen/arm: zynqmp: Disable PCIe

[Edgar E. Iglesias]

On Mon, Jul 31, 2017 at 11:11:39PM +0100, Julien Grall wrote:
> 
> 
> On 31/07/2017 20:37, Edgar E. Iglesias wrote:
> >From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> >Hi,
> 
> Hi Edgar,
> 
> 
> >We're seeing panics in dom0 with PCIe enabled due to what seems
> >to be wrongly created mappings by Xen. With older kernels we
> >didn't see the panics but PCIe wasn't functional in dom0.
> >
> >This disables the PCIe nodes on the ZynqMP until Xen/ARM gets
> >more PCIe support.
> 
> I feel a bit sad to ack a patch disabling PCIe in the ZynqMP.
> 
> Before doing that. Can you describe what is the exact problem with Xen? It
> might be possible that we don't parse correctly the device-tree.

Yes, it was related to the DTB since we had a workaround with a modified
DTB.

Anyway, I was to quick with sending out the patch.

We've been carrying this for a while and your questions prompted me
to have a look again and dig out the details. Turns out I can't reproduce it
with our latest kernel and the latest Xen. I don't know what fixed
it yet but PCIe works ATM both on QEMU models and on real HW.

I don't think it ever has before without modified DTBs.

So please ignore this patch for now :-)

Cheers,
Edgar


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 0/1] xen/arm: zynqmp: Disable PCIe

[Stefano Stabellini]

On Tue, 1 Aug 2017, Edgar E. Iglesias wrote:
> On Mon, Jul 31, 2017 at 11:11:39PM +0100, Julien Grall wrote:
> > 
> > 
> > On 31/07/2017 20:37, Edgar E. Iglesias wrote:
> > >From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > >
> > >Hi,
> > 
> > Hi Edgar,
> > 
> > 
> > >We're seeing panics in dom0 with PCIe enabled due to what seems
> > >to be wrongly created mappings by Xen. With older kernels we
> > >didn't see the panics but PCIe wasn't functional in dom0.
> > >
> > >This disables the PCIe nodes on the ZynqMP until Xen/ARM gets
> > >more PCIe support.
> > 
> > I feel a bit sad to ack a patch disabling PCIe in the ZynqMP.
> > 
> > Before doing that. Can you describe what is the exact problem with Xen? It
> > might be possible that we don't parse correctly the device-tree.
> 
> Yes, it was related to the DTB since we had a workaround with a modified
> DTB.
> 
> Anyway, I was to quick with sending out the patch.
> 
> We've been carrying this for a while and your questions prompted me
> to have a look again and dig out the details. Turns out I can't reproduce it
> with our latest kernel and the latest Xen. I don't know what fixed
> it yet but PCIe works ATM both on QEMU models and on real HW.
> 
> I don't think it ever has before without modified DTBs.

Fantastic!!


> So please ignore this patch for now :-)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel