From: Vinod Koul <vinod.koul@intel.com>
To: Cheng-Yi Chiang <cychiang@chromium.org>, Jie Yang <yang.jie@intel.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Mark Brown <broonie@kernel.org>,
"U . Artie Eoff" <ullysses.a.eoff@intel.com>
Subject: Re: [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger
Date: Tue, 1 Aug 2017 09:00:06 +0530 [thread overview]
Message-ID: <20170801033006.GL3053@localhost> (raw)
In-Reply-To: <20170731104734.5776-1-cychiang@chromium.org>
On Mon, Jul 31, 2017 at 06:47:34PM +0800, Cheng-Yi Chiang wrote:
> From: "U. Artie Eoff" <ullysses.a.eoff@intel.com>
>
> Reset the hw_ptr before queuing the restore_stream_context
> work to eradicate a nasty white audio noise on resume.
Liam, Jie? This on legacy BYT driver..
>
> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
> Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> ---
> sound/soc/intel/baytrail/sst-baytrail-pcm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> index 4765ad474544..e0db7070cd42 100644
> --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> @@ -187,8 +187,10 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
> sst_byt_stream_start(byt, pcm_data->stream, 0);
> break;
> case SNDRV_PCM_TRIGGER_RESUME:
> - if (pdata->restore_stream == true)
> + if (pdata->restore_stream == true) {
> + pcm_data->hw_ptr = 0;
> schedule_work(&pcm_data->work);
> + }
> else
> sst_byt_stream_resume(byt, pcm_data->stream);
> break;
> --
> 2.12.2
>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Cheng-Yi Chiang <cychiang@chromium.org>, Jie Yang <yang.jie@intel.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"U . Artie Eoff" <ullysses.a.eoff@intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger
Date: Tue, 1 Aug 2017 09:00:06 +0530 [thread overview]
Message-ID: <20170801033006.GL3053@localhost> (raw)
In-Reply-To: <20170731104734.5776-1-cychiang@chromium.org>
On Mon, Jul 31, 2017 at 06:47:34PM +0800, Cheng-Yi Chiang wrote:
> From: "U. Artie Eoff" <ullysses.a.eoff@intel.com>
>
> Reset the hw_ptr before queuing the restore_stream_context
> work to eradicate a nasty white audio noise on resume.
Liam, Jie? This on legacy BYT driver..
>
> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
> Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> ---
> sound/soc/intel/baytrail/sst-baytrail-pcm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> index 4765ad474544..e0db7070cd42 100644
> --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
> @@ -187,8 +187,10 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
> sst_byt_stream_start(byt, pcm_data->stream, 0);
> break;
> case SNDRV_PCM_TRIGGER_RESUME:
> - if (pdata->restore_stream == true)
> + if (pdata->restore_stream == true) {
> + pcm_data->hw_ptr = 0;
> schedule_work(&pcm_data->work);
> + }
> else
> sst_byt_stream_resume(byt, pcm_data->stream);
> break;
> --
> 2.12.2
>
--
~Vinod
next prev parent reply other threads:[~2017-08-01 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 10:47 [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger Cheng-Yi Chiang
2017-08-01 3:30 ` Vinod Koul [this message]
2017-08-01 3:30 ` Vinod Koul
2017-08-01 4:32 ` Eoff, Ullysses A
2017-08-01 4:42 ` Cheng-yi Chiang
2017-08-01 5:04 ` Keyon Jie
2017-08-01 5:04 ` [alsa-devel] " Keyon Jie
2017-08-03 13:47 ` Cheng-yi Chiang
2017-08-03 13:47 ` [alsa-devel] " Cheng-yi Chiang
2017-08-07 6:36 ` Keyon Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801033006.GL3053@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=ullysses.a.eoff@intel.com \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.