From: Olaf Hering <olaf@aepfle.de>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Quan Xu <quan.xu0@gmail.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] vtpmmgr: make inline functions static
Date: Tue, 1 Aug 2017 17:13:21 +0200 [thread overview]
Message-ID: <20170801151321.GC1646@aepfle.de> (raw)
In-Reply-To: <20170623173504.11785-1-olaf@aepfle.de>
[-- Attachment #1.1: Type: text/plain, Size: 1045 bytes --]
Ping
On Fri, Jun 23, Olaf Hering wrote:
> gcc7 is more strict with functions marked as inline. They are not
> automatically inlined. Instead a function call is generated, but the
> actual code is not visible by the linker.
>
> Do a mechanical change and mark every 'inline' as 'static inline'. For
> simpler review the static goes into an extra line.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> stubdom/vtpmmgr/marshal.h | 76 ++++++++++++++++++++++++++++++++++++++++++
> stubdom/vtpmmgr/tcg.h | 14 ++++++++
> stubdom/vtpmmgr/tpm2_marshal.h | 58 ++++++++++++++++++++++++++++++++
> stubdom/vtpmmgr/tpmrsa.h | 1 +
> 4 files changed, 149 insertions(+)
>
> diff --git a/stubdom/vtpmmgr/marshal.h b/stubdom/vtpmmgr/marshal.h
> index d826f19d89..dce19c6439 100644
> --- a/stubdom/vtpmmgr/marshal.h
> +++ b/stubdom/vtpmmgr/marshal.h
> @@ -47,16 +47,19 @@ typedef enum UnpackPtr {
> UNPACK_ALLOC
> } UnpackPtr;
>
> +static
> inline BYTE* pack_BYTE(BYTE* ptr, BYTE t) {
...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-01 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 17:35 [PATCH] vtpmmgr: make inline functions static Olaf Hering
2017-08-01 15:13 ` Olaf Hering [this message]
2017-08-09 12:18 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801151321.GC1646@aepfle.de \
--to=olaf@aepfle.de \
--cc=dgdegra@tycho.nsa.gov \
--cc=quan.xu0@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.