* Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference [not found] <1501631202-11656-1-git-send-email-cakturk@gmail.com> @ 2017-08-02 12:38 ` Daniel Vetter 2017-08-02 13:47 ` Cihangir Akturk 0 siblings, 1 reply; 4+ messages in thread From: Daniel Vetter @ 2017-08-02 12:38 UTC (permalink / raw) To: Cihangir Akturk, Linux Kernel Mailing List Cc: Greg KH, Hans de Goede, Michael Thayer, devel On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@gmail.com> wrote: > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should > not be used by new code. > > This patch fixes the following warning reported by coccinelle: > > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put > helpers to reference and dereference obj > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> Care to do this for all the drm drivers, not just the single one in staging? Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches also go to dri-devel? Thanks, Daniel > --- > drivers/staging/vboxvideo/vbox_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c > index d0c6ec7..1addeac 100644 > --- a/drivers/staging/vboxvideo/vbox_main.c > +++ b/drivers/staging/vboxvideo/vbox_main.c > @@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file, > bo = gem_to_vbox_bo(obj); > *offset = vbox_bo_mmap_offset(bo); > > - drm_gem_object_unreference(obj); > + drm_gem_object_put(obj); > ret = 0; > > out_unlock: > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference 2017-08-02 12:38 ` [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference Daniel Vetter @ 2017-08-02 13:47 ` Cihangir Akturk 2017-08-02 14:17 ` Daniel Vetter 0 siblings, 1 reply; 4+ messages in thread From: Cihangir Akturk @ 2017-08-02 13:47 UTC (permalink / raw) To: Daniel Vetter Cc: Linux Kernel Mailing List, Greg KH, Hans de Goede, Michael Thayer, devel On Wed, Aug 02, 2017 at 02:38:50PM +0200, Daniel Vetter wrote: > On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@gmail.com> wrote: > > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should > > not be used by new code. > > > > This patch fixes the following warning reported by coccinelle: > > > > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put > > helpers to reference and dereference obj > > > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> > > Care to do this for all the drm drivers, not just the single one in staging? Sure, I'll send a v2 shortly as you suggested. Thanks. > > Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches > also go to dri-devel? > > Thanks, Daniel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference 2017-08-02 13:47 ` Cihangir Akturk @ 2017-08-02 14:17 ` Daniel Vetter 0 siblings, 0 replies; 4+ messages in thread From: Daniel Vetter @ 2017-08-02 14:17 UTC (permalink / raw) To: Cihangir Akturk, dri-devel Cc: devel, Greg KH, Michael Thayer, Linux Kernel Mailing List, Hans de Goede On Wed, Aug 2, 2017 at 3:47 PM, Cihangir Akturk <cakturk@gmail.com> wrote: > On Wed, Aug 02, 2017 at 02:38:50PM +0200, Daniel Vetter wrote: >> On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@gmail.com> wrote: >> > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should >> > not be used by new code. >> > >> > This patch fixes the following warning reported by coccinelle: >> > >> > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put >> > helpers to reference and dereference obj >> > >> > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> >> >> Care to do this for all the drm drivers, not just the single one in staging? > > Sure, I'll send a v2 shortly as you suggested. Patch per driver would be better I think, there's probably going to be a _lot_ of hits. Thanks, Daniel > > Thanks. > >> >> Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches >> also go to dri-devel? >> >> Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference @ 2017-08-02 14:17 ` Daniel Vetter 0 siblings, 0 replies; 4+ messages in thread From: Daniel Vetter @ 2017-08-02 14:17 UTC (permalink / raw) To: Cihangir Akturk, dri-devel Cc: Linux Kernel Mailing List, Greg KH, Hans de Goede, Michael Thayer, devel On Wed, Aug 2, 2017 at 3:47 PM, Cihangir Akturk <cakturk@gmail.com> wrote: > On Wed, Aug 02, 2017 at 02:38:50PM +0200, Daniel Vetter wrote: >> On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@gmail.com> wrote: >> > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should >> > not be used by new code. >> > >> > This patch fixes the following warning reported by coccinelle: >> > >> > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put >> > helpers to reference and dereference obj >> > >> > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> >> >> Care to do this for all the drm drivers, not just the single one in staging? > > Sure, I'll send a v2 shortly as you suggested. Patch per driver would be better I think, there's probably going to be a _lot_ of hits. Thanks, Daniel > > Thanks. > >> >> Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches >> also go to dri-devel? >> >> Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-02 14:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1501631202-11656-1-git-send-email-cakturk@gmail.com>
2017-08-02 12:38 ` [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference Daniel Vetter
2017-08-02 13:47 ` Cihangir Akturk
2017-08-02 14:17 ` Daniel Vetter
2017-08-02 14:17 ` Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.