From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: i.MX25: add ranges to tscadc
Date: Thu, 3 Aug 2017 10:20:09 +0800 [thread overview]
Message-ID: <20170803022007.GI31819@dragon> (raw)
In-Reply-To: <1501704371-28151-1-git-send-email-martin@kaiser.cx>
On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> the addresses used by tscadc and those in its child nodes (adc, tsc).
>
> Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> drivers will then fail since there's no IORESOURCE_MEM.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Do we need the following Fixes tag?
Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
@Markus, we didn't the changes when we were submitting?
Shawn
> ---
> arch/arm/boot/dts/imx25.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 0d2f3a1..1e37bd3 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -297,6 +297,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> status = "disabled";
> + ranges;
>
> adc: adc at 50030800 {
> compatible = "fsl,imx25-gcq";
> --
> 2.1.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
Cc: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc
Date: Thu, 3 Aug 2017 10:20:09 +0800 [thread overview]
Message-ID: <20170803022007.GI31819@dragon> (raw)
In-Reply-To: <1501704371-28151-1-git-send-email-martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> the addresses used by tscadc and those in its child nodes (adc, tsc).
>
> Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> drivers will then fail since there's no IORESOURCE_MEM.
>
> Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
Do we need the following Fixes tag?
Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
@Markus, we didn't the changes when we were submitting?
Shawn
> ---
> arch/arm/boot/dts/imx25.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 0d2f3a1..1e37bd3 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -297,6 +297,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> status = "disabled";
> + ranges;
>
> adc: adc@50030800 {
> compatible = "fsl,imx25-gcq";
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Markus Pargmann <mpa@pengutronix.de>,
Denis Carikli <denis@eukrea.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc
Date: Thu, 3 Aug 2017 10:20:09 +0800 [thread overview]
Message-ID: <20170803022007.GI31819@dragon> (raw)
In-Reply-To: <1501704371-28151-1-git-send-email-martin@kaiser.cx>
On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> the addresses used by tscadc and those in its child nodes (adc, tsc).
>
> Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> drivers will then fail since there's no IORESOURCE_MEM.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Do we need the following Fixes tag?
Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
@Markus, we didn't the changes when we were submitting?
Shawn
> ---
> arch/arm/boot/dts/imx25.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 0d2f3a1..1e37bd3 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -297,6 +297,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> status = "disabled";
> + ranges;
>
> adc: adc@50030800 {
> compatible = "fsl,imx25-gcq";
> --
> 2.1.4
>
next prev parent reply other threads:[~2017-08-03 2:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 20:06 [PATCH] ARM: dts: i.MX25: add ranges to tscadc Martin Kaiser
2017-08-02 20:06 ` Martin Kaiser
2017-08-02 20:06 ` Martin Kaiser
2017-08-03 2:20 ` Shawn Guo [this message]
2017-08-03 2:20 ` Shawn Guo
2017-08-03 2:20 ` Shawn Guo
2017-08-03 16:29 ` Martin Kaiser
2017-08-03 16:29 ` Martin Kaiser
2017-08-03 16:29 ` Martin Kaiser
2017-08-05 5:31 ` Shawn Guo
2017-08-05 5:31 ` Shawn Guo
2017-08-05 5:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803022007.GI31819@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.