From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: imx: gpcv2: fix regulator deferred probe
Date: Thu, 3 Aug 2017 10:50:18 +0800 [thread overview]
Message-ID: <20170803025017.GJ31819@dragon> (raw)
In-Reply-To: <20170802195129.20442-1-stefan@agner.ch>
On Wed, Aug 02, 2017 at 12:51:29PM -0700, Stefan Agner wrote:
> If a regulator requests a deferred probe, the power domain gets
> initialized twice. This leads to a list double add (without
> list debugging the kernel hangs due to the double add later):
>
> WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4
> list_add double add: new=c1229754, prev=c12383b4, next=c1229754.
>
> Initialize the power domain after we get the regulator. Also do
> not print an error in case the regulator defers probing.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Shawn,
>
> Since this leads to a Kernel hang in v4.13-rc3, can you get this
> into v4.13 still?
Sure. But before doing that, I would like to get an ACK from Andrey on
this fix.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe
Date: Thu, 3 Aug 2017 10:50:18 +0800 [thread overview]
Message-ID: <20170803025017.GJ31819@dragon> (raw)
In-Reply-To: <20170802195129.20442-1-stefan@agner.ch>
On Wed, Aug 02, 2017 at 12:51:29PM -0700, Stefan Agner wrote:
> If a regulator requests a deferred probe, the power domain gets
> initialized twice. This leads to a list double add (without
> list debugging the kernel hangs due to the double add later):
>
> WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4
> list_add double add: new=c1229754, prev=c12383b4, next=c1229754.
>
> Initialize the power domain after we get the regulator. Also do
> not print an error in case the regulator defers probing.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Shawn,
>
> Since this leads to a Kernel hang in v4.13-rc3, can you get this
> into v4.13 still?
Sure. But before doing that, I would like to get an ACK from Andrey on
this fix.
Shawn
next prev parent reply other threads:[~2017-08-03 2:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 19:51 [PATCH] soc: imx: gpcv2: fix regulator deferred probe Stefan Agner
2017-08-02 19:51 ` Stefan Agner
2017-08-03 2:50 ` Shawn Guo [this message]
2017-08-03 2:50 ` Shawn Guo
2017-08-03 7:08 ` Andrey Smirnov
2017-08-03 7:08 ` Andrey Smirnov
2017-08-05 3:13 ` Shawn Guo
2017-08-05 3:13 ` Shawn Guo
2017-08-14 5:12 ` Stefan Agner
2017-08-14 5:12 ` Stefan Agner
2017-08-14 5:35 ` Shawn Guo
2017-08-14 5:35 ` Shawn Guo
2017-08-15 15:36 ` Arnd Bergmann
2017-08-15 15:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803025017.GJ31819@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.