From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-xtensa@linux-xtensa.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-arch <linux-arch@vger.kernel.org>,
linux-s390@vger.kernel.org, linux-am33-list@redhat.com,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chris Zankel <chris@zankel.net>, Tony Luck <tony.luck@intel.com>,
Linux Kernel Mailing List <linux-kernel@vg>
Subject: Re: [PATCH] uapi: fix another asm/shmbuf.h userspace compilation error
Date: Fri, 4 Aug 2017 16:22:04 +0100 [thread overview]
Message-ID: <20170804152203.GA31455@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <CAK8P3a1=-Q=gVRyk+PwqxTeTPXa4yrmqWKG7SyZng2d7bcbG=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Thu, Mar 02, 2017 at 02:07:20PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 2, 2017 at 1:46 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > Replace size_t with __kernel_size_t to fix asm/shmbuf.h userspace
> > compilation errors like this:
> >
> > /usr/include/asm-generic/shmbuf.h:28:2: error: unknown type name 'size_t'
> > size_t shm_segsz; /* size of segment (bytes) */
> >
> > x32 is the only architecture where sizeof(size_t) is less than
> > sizeof(__kernel_size_t), but as the kernel treats shm_segsz field as
> > __kernel_size_t anyway, UAPI should follow. Thanks to little-endiannes
> > of x32 and 64-bit alignment of the field following shm_segsz, this
> > change doesn't break ABI, and the difference doesn't manifest itself
> > easily.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Out of interest, is there a plan for merging these patches from Dmitry?
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-xtensa@linux-xtensa.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-arch <linux-arch@vger.kernel.org>,
linux-s390@vger.kernel.org, linux-am33-list@redhat.com,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chris Zankel <chris@zankel.net>, Tony Luck <tony.luck@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-alpha@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] uapi: fix another asm/shmbuf.h userspace compilation error
Date: Fri, 4 Aug 2017 16:22:04 +0100 [thread overview]
Message-ID: <20170804152203.GA31455@jhogan-linux.le.imgtec.org> (raw)
Message-ID: <20170804152204.5BEE-tbGKj093P3wy1fhJUSCgqHn_VZHbaOcX9Pd8a0@z> (raw)
In-Reply-To: <CAK8P3a1=-Q=gVRyk+PwqxTeTPXa4yrmqWKG7SyZng2d7bcbG=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Thu, Mar 02, 2017 at 02:07:20PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 2, 2017 at 1:46 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > Replace size_t with __kernel_size_t to fix asm/shmbuf.h userspace
> > compilation errors like this:
> >
> > /usr/include/asm-generic/shmbuf.h:28:2: error: unknown type name 'size_t'
> > size_t shm_segsz; /* size of segment (bytes) */
> >
> > x32 is the only architecture where sizeof(size_t) is less than
> > sizeof(__kernel_size_t), but as the kernel treats shm_segsz field as
> > __kernel_size_t anyway, UAPI should follow. Thanks to little-endiannes
> > of x32 and 64-bit alignment of the field following shm_segsz, this
> > change doesn't break ABI, and the difference doesn't manifest itself
> > easily.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Out of interest, is there a plan for merging these patches from Dmitry?
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-xtensa@linux-xtensa.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-arch <linux-arch@vger.kernel.org>,
linux-s390@vger.kernel.org, linux-am33-list@redhat.com,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chris Zankel <chris@zankel.net>, Tony Luck <tony.luck@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-alpha@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] uapi: fix another asm/shmbuf.h userspace compilation error
Date: Fri, 04 Aug 2017 15:22:04 +0000 [thread overview]
Message-ID: <20170804152203.GA31455@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <CAK8P3a1=-Q=gVRyk+PwqxTeTPXa4yrmqWKG7SyZng2d7bcbG=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Thu, Mar 02, 2017 at 02:07:20PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 2, 2017 at 1:46 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > Replace size_t with __kernel_size_t to fix asm/shmbuf.h userspace
> > compilation errors like this:
> >
> > /usr/include/asm-generic/shmbuf.h:28:2: error: unknown type name 'size_t'
> > size_t shm_segsz; /* size of segment (bytes) */
> >
> > x32 is the only architecture where sizeof(size_t) is less than
> > sizeof(__kernel_size_t), but as the kernel treats shm_segsz field as
> > __kernel_size_t anyway, UAPI should follow. Thanks to little-endiannes
> > of x32 and 64-bit alignment of the field following shm_segsz, this
> > change doesn't break ABI, and the difference doesn't manifest itself
> > easily.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Out of interest, is there a plan for merging these patches from Dmitry?
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>, <linux-mips@linux-mips.org>,
<linux-ia64@vger.kernel.org>, <linux-xtensa@linux-xtensa.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>, <sparclinux@vger.kernel.org>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-arch <linux-arch@vger.kernel.org>,
<linux-s390@vger.kernel.org>, <linux-am33-list@redhat.com>,
<x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chris Zankel <chris@zankel.net>, Tony Luck <tony.luck@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>, <linux-alpha@vger.kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
<linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] uapi: fix another asm/shmbuf.h userspace compilation error
Date: Fri, 4 Aug 2017 16:22:04 +0100 [thread overview]
Message-ID: <20170804152203.GA31455@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <CAK8P3a1=-Q=gVRyk+PwqxTeTPXa4yrmqWKG7SyZng2d7bcbG=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Thu, Mar 02, 2017 at 02:07:20PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 2, 2017 at 1:46 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > Replace size_t with __kernel_size_t to fix asm/shmbuf.h userspace
> > compilation errors like this:
> >
> > /usr/include/asm-generic/shmbuf.h:28:2: error: unknown type name 'size_t'
> > size_t shm_segsz; /* size of segment (bytes) */
> >
> > x32 is the only architecture where sizeof(size_t) is less than
> > sizeof(__kernel_size_t), but as the kernel treats shm_segsz field as
> > __kernel_size_t anyway, UAPI should follow. Thanks to little-endiannes
> > of x32 and 64-bit alignment of the field following shm_segsz, this
> > change doesn't break ABI, and the difference doesn't manifest itself
> > easily.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Out of interest, is there a plan for merging these patches from Dmitry?
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-xtensa@linux-xtensa.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
linux-arch <linux-arch@vger.kernel.org>,
linux-s390@vger.kernel.org, linux-am33-list@redhat.com,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chris Zankel <chris@zankel.net>, Tony Luck <tony.luck@intel.com>,
Linux Kernel Mailing List <linux-kernel@vg>
Subject: Re: [PATCH] uapi: fix another asm/shmbuf.h userspace compilation error
Date: Fri, 04 Aug 2017 15:22:04 +0000 [thread overview]
Message-ID: <20170804152203.GA31455@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <CAK8P3a1=-Q=gVRyk+PwqxTeTPXa4yrmqWKG7SyZng2d7bcbG=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Thu, Mar 02, 2017 at 02:07:20PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 2, 2017 at 1:46 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > Replace size_t with __kernel_size_t to fix asm/shmbuf.h userspace
> > compilation errors like this:
> >
> > /usr/include/asm-generic/shmbuf.h:28:2: error: unknown type name 'size_t'
> > size_t shm_segsz; /* size of segment (bytes) */
> >
> > x32 is the only architecture where sizeof(size_t) is less than
> > sizeof(__kernel_size_t), but as the kernel treats shm_segsz field as
> > __kernel_size_t anyway, UAPI should follow. Thanks to little-endiannes
> > of x32 and 64-bit alignment of the field following shm_segsz, this
> > change doesn't break ABI, and the difference doesn't manifest itself
> > easily.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Out of interest, is there a plan for merging these patches from Dmitry?
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-04 15:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 0:46 [PATCH] uapi: fix another asm/shmbuf.h userspace compilation error Dmitry V. Levin
2017-03-02 0:46 ` Dmitry V. Levin
2017-03-02 0:46 ` Dmitry V. Levin
2017-03-02 0:46 ` Dmitry V. Levin
2017-03-02 13:07 ` Arnd Bergmann
2017-03-02 13:07 ` Arnd Bergmann
2017-03-02 13:07 ` Arnd Bergmann
2017-03-02 13:07 ` Arnd Bergmann
2017-03-26 3:27 ` [PATCH 0/5] uapi: fix userspace compilation of asm/ ipc headers Dmitry V. Levin
2017-03-26 3:30 ` [PATCH 1/5] uapi: fix asm/ipcbuf.h userspace compilation errors Dmitry V. Levin
2017-03-26 3:30 ` [PATCH 2/5] uapi: fix asm/msgbuf.h " Dmitry V. Levin
2017-03-26 3:30 ` [PATCH 3/5] uapi: fix asm/sembuf.h " Dmitry V. Levin
2017-03-26 3:30 ` [PATCH 4/5] uapi: fix asm/shmbuf.h " Dmitry V. Levin
2017-03-26 3:30 ` [PATCH 5/5] uapi: fix another asm/shmbuf.h userspace compilation error Dmitry V. Levin
2017-08-04 15:22 ` James Hogan [this message]
2017-08-04 15:22 ` [PATCH] " James Hogan
2017-08-04 15:22 ` James Hogan
2017-08-04 15:22 ` James Hogan
2017-08-04 15:22 ` James Hogan
-- strict thread matches above, loose matches on Subject: below --
2017-02-26 18:29 [PATCH] uapi: fix asm/ipcbuf.h userspace compilation errors Dmitry V. Levin
2017-02-26 18:29 ` Dmitry V. Levin
2017-03-01 16:23 ` Arnd Bergmann
2017-03-01 16:23 ` Arnd Bergmann
2017-03-02 0:22 ` [PATCH 1/3] uapi: fix asm/msgbuf.h " Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 0:22 ` [PATCH 2/3] uapi: fix asm/sembuf.h " Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 0:22 ` [PATCH 3/3] uapi: fix asm/shmbuf.h " Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 0:22 ` Dmitry V. Levin
2017-03-02 13:14 ` Arnd Bergmann
2017-03-02 13:14 ` Arnd Bergmann
2017-03-02 13:14 ` Arnd Bergmann
2021-12-27 10:53 ` [PATCH v2] " Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804152203.GA31455@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=hskinnemoen@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=ldv@altlinux.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vg \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.