* [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL
@ 2017-08-04 22:23 Roopa Prabhu
2017-08-04 22:25 ` Andrew Lunn
2017-08-05 13:41 ` kbuild test robot
0 siblings, 2 replies; 4+ messages in thread
From: Roopa Prabhu @ 2017-08-04 22:23 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
net/core/lwtunnel.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index d9cb353..8693ff8 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -65,7 +65,7 @@ struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
return lws;
}
-EXPORT_SYMBOL(lwtunnel_state_alloc);
+EXPORT_SYMBOL_GPL_GPL(lwtunnel_state_alloc);
static const struct lwtunnel_encap_ops __rcu *
lwtun_encaps[LWTUNNEL_ENCAP_MAX + 1] __read_mostly;
@@ -80,7 +80,7 @@ int lwtunnel_encap_add_ops(const struct lwtunnel_encap_ops *ops,
&lwtun_encaps[num],
NULL, ops) ? 0 : -1;
}
-EXPORT_SYMBOL(lwtunnel_encap_add_ops);
+EXPORT_SYMBOL_GPL(lwtunnel_encap_add_ops);
int lwtunnel_encap_del_ops(const struct lwtunnel_encap_ops *ops,
unsigned int encap_type)
@@ -99,7 +99,7 @@ int lwtunnel_encap_del_ops(const struct lwtunnel_encap_ops *ops,
return ret;
}
-EXPORT_SYMBOL(lwtunnel_encap_del_ops);
+EXPORT_SYMBOL_GPL(lwtunnel_encap_del_ops);
int lwtunnel_build_state(u16 encap_type,
struct nlattr *encap, unsigned int family,
@@ -138,7 +138,7 @@ int lwtunnel_build_state(u16 encap_type,
return ret;
}
-EXPORT_SYMBOL(lwtunnel_build_state);
+EXPORT_SYMBOL_GPL(lwtunnel_build_state);
int lwtunnel_valid_encap_type(u16 encap_type, struct netlink_ext_ack *extack)
{
@@ -175,7 +175,7 @@ int lwtunnel_valid_encap_type(u16 encap_type, struct netlink_ext_ack *extack)
return ret;
}
-EXPORT_SYMBOL(lwtunnel_valid_encap_type);
+EXPORT_SYMBOL_GPL(lwtunnel_valid_encap_type);
int lwtunnel_valid_encap_type_attr(struct nlattr *attr, int remaining,
struct netlink_ext_ack *extack)
@@ -205,7 +205,7 @@ int lwtunnel_valid_encap_type_attr(struct nlattr *attr, int remaining,
return 0;
}
-EXPORT_SYMBOL(lwtunnel_valid_encap_type_attr);
+EXPORT_SYMBOL_GPL(lwtunnel_valid_encap_type_attr);
void lwtstate_free(struct lwtunnel_state *lws)
{
@@ -219,7 +219,7 @@ void lwtstate_free(struct lwtunnel_state *lws)
}
module_put(ops->owner);
}
-EXPORT_SYMBOL(lwtstate_free);
+EXPORT_SYMBOL_GPL(lwtstate_free);
int lwtunnel_fill_encap(struct sk_buff *skb, struct lwtunnel_state *lwtstate)
{
@@ -259,7 +259,7 @@ int lwtunnel_fill_encap(struct sk_buff *skb, struct lwtunnel_state *lwtstate)
return (ret == -EOPNOTSUPP ? 0 : ret);
}
-EXPORT_SYMBOL(lwtunnel_fill_encap);
+EXPORT_SYMBOL_GPL(lwtunnel_fill_encap);
int lwtunnel_get_encap_size(struct lwtunnel_state *lwtstate)
{
@@ -281,7 +281,7 @@ int lwtunnel_get_encap_size(struct lwtunnel_state *lwtstate)
return ret;
}
-EXPORT_SYMBOL(lwtunnel_get_encap_size);
+EXPORT_SYMBOL_GPL(lwtunnel_get_encap_size);
int lwtunnel_cmp_encap(struct lwtunnel_state *a, struct lwtunnel_state *b)
{
@@ -309,7 +309,7 @@ int lwtunnel_cmp_encap(struct lwtunnel_state *a, struct lwtunnel_state *b)
return ret;
}
-EXPORT_SYMBOL(lwtunnel_cmp_encap);
+EXPORT_SYMBOL_GPL(lwtunnel_cmp_encap);
int lwtunnel_output(struct net *net, struct sock *sk, struct sk_buff *skb)
{
@@ -343,7 +343,7 @@ int lwtunnel_output(struct net *net, struct sock *sk, struct sk_buff *skb)
return ret;
}
-EXPORT_SYMBOL(lwtunnel_output);
+EXPORT_SYMBOL_GPL(lwtunnel_output);
int lwtunnel_xmit(struct sk_buff *skb)
{
@@ -378,7 +378,7 @@ int lwtunnel_xmit(struct sk_buff *skb)
return ret;
}
-EXPORT_SYMBOL(lwtunnel_xmit);
+EXPORT_SYMBOL_GPL(lwtunnel_xmit);
int lwtunnel_input(struct sk_buff *skb)
{
@@ -412,4 +412,4 @@ int lwtunnel_input(struct sk_buff *skb)
return ret;
}
-EXPORT_SYMBOL(lwtunnel_input);
+EXPORT_SYMBOL_GPL(lwtunnel_input);
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL
2017-08-04 22:23 [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL Roopa Prabhu
@ 2017-08-04 22:25 ` Andrew Lunn
2017-08-04 22:36 ` Roopa Prabhu
2017-08-05 13:41 ` kbuild test robot
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2017-08-04 22:25 UTC (permalink / raw)
To: Roopa Prabhu; +Cc: davem, netdev
On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> net/core/lwtunnel.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
> index d9cb353..8693ff8 100644
> --- a/net/core/lwtunnel.c
> +++ b/net/core/lwtunnel.c
> @@ -65,7 +65,7 @@ struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
>
> return lws;
> }
> -EXPORT_SYMBOL(lwtunnel_state_alloc);
> +EXPORT_SYMBOL_GPL_GPL(lwtunnel_state_alloc);
Hi Roopa
GPL_GPL?
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL
2017-08-04 22:25 ` Andrew Lunn
@ 2017-08-04 22:36 ` Roopa Prabhu
0 siblings, 0 replies; 4+ messages in thread
From: Roopa Prabhu @ 2017-08-04 22:36 UTC (permalink / raw)
To: Andrew Lunn; +Cc: davem@davemloft.net, netdev@vger.kernel.org
On Fri, Aug 4, 2017 at 3:25 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> ---
>> net/core/lwtunnel.c | 26 +++++++++++++-------------
>> 1 file changed, 13 insertions(+), 13 deletions(-)
>>
>> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
>> index d9cb353..8693ff8 100644
>> --- a/net/core/lwtunnel.c
>> +++ b/net/core/lwtunnel.c
>> @@ -65,7 +65,7 @@ struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
>>
>> return lws;
>> }
>> -EXPORT_SYMBOL(lwtunnel_state_alloc);
>> +EXPORT_SYMBOL_GPL_GPL(lwtunnel_state_alloc);
>
> Hi Roopa
>
> GPL_GPL?
>
oops, i had fixed it but sent the wrong version. thx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL
2017-08-04 22:23 [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL Roopa Prabhu
2017-08-04 22:25 ` Andrew Lunn
@ 2017-08-05 13:41 ` kbuild test robot
1 sibling, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2017-08-05 13:41 UTC (permalink / raw)
To: Roopa Prabhu; +Cc: kbuild-all, davem, netdev
[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]
Hi Roopa,
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/lwtunnel-replace-EXPORT_SYMBOL-with-EXPORT_SYMBOL_GPL/20170805-212202
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=blackfin
All error/warnings (new ones prefixed by >>):
>> net//core/lwtunnel.c:68:1: warning: data definition has no type or storage class
EXPORT_SYMBOL_GPL_GPL(lwtunnel_state_alloc);
^~~~~~~~~~~~~~~~~~~~~
>> net//core/lwtunnel.c:68:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL_GPL' [-Werror=implicit-int]
>> net//core/lwtunnel.c:68:1: warning: parameter names (without types) in function declaration
cc1: some warnings being treated as errors
vim +68 net//core/lwtunnel.c
59
60 struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
61 {
62 struct lwtunnel_state *lws;
63
64 lws = kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
65
66 return lws;
67 }
> 68 EXPORT_SYMBOL_GPL_GPL(lwtunnel_state_alloc);
69
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45667 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-05 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 22:23 [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL Roopa Prabhu
2017-08-04 22:25 ` Andrew Lunn
2017-08-04 22:36 ` Roopa Prabhu
2017-08-05 13:41 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.