From: Greg KH <greg@kroah.com>
To: Eyal Reizer <eyalreizer@gmail.com>
Cc: eyalr@ti.com, "# 4 . 9+" <stable@vger.kernel.org>
Subject: Re: [v6] wlcore: add missing nvs file name info for wilink8
Date: Wed, 9 Aug 2017 08:21:53 -0700 [thread overview]
Message-ID: <20170809152153.GC26708@kroah.com> (raw)
In-Reply-To: <1502264840-10569-1-git-send-email-eyalr@ti.com>
On Wed, Aug 09, 2017 at 10:47:20AM +0300, Eyal Reizer wrote:
> The following commits:
> commit c815fdebef44 ("wlcore: spi: Populate config firmware data")
> commit d776fc86b82f ("wlcore: sdio: Populate config firmware data")
>
> Populated the nvs entry for wilink6 and wilink7 only while it is
> still needed for wilink8 as well.
> This broke user space backward compatibility when upgrading from older
> kernels, as the alternate mac address would not be read from the nvs that
> is present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin)
> causing mac address change of the wlan interface.
>
> This patch fix this and update the structure field with the same default
> nvs file name that has been used before.
>
> In addition, some distros hold a default wl1271-nvs.bin in the file
> system with a bogus mac address (deadbeef...) that overrides the mac
> address that is stored inside the device.
> Warn users about this bogus mac address and use the internal mac address
>
> Fixes: c815fdebef44 ("wlcore: spi: Populate config firmware data")
> Fixes: d776fc86b82f ("wlcore: sdio: Populate config firmware data")
> Cc: <stable@vger.kernel.org> # 4.9+
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> ---
> v2->v3: add a check for default deadbeef... mac address and warn about it
> v3->v4: use a random TI mac address instead of the bogus one
> v4->v5: add constant definition for TI oui address
> v5->v6: after also verifying on wilink6/7 Use mac internal mac address
> instead of a random one
> ---
> drivers/net/wireless/ti/wlcore/main.c | 15 +++++++++++++++
> drivers/net/wireless/ti/wlcore/sdio.c | 1 +
> drivers/net/wireless/ti/wlcore/spi.c | 1 +
> 3 files changed, 17 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
prev parent reply other threads:[~2017-08-09 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 7:47 [v6] wlcore: add missing nvs file name info for wilink8 Eyal Reizer
2017-08-09 7:53 ` Reizer, Eyal
2017-08-09 7:53 ` Reizer, Eyal
2017-08-09 17:26 ` Tony Lindgren
2017-08-09 17:28 ` Tony Lindgren
[not found] ` <ngx9scofrw0qb2vkesion8v9.1502300336052@email.android.com>
2017-08-09 21:16 ` Tony Lindgren
2017-08-10 6:35 ` Reizer, Eyal
2017-08-10 6:35 ` Reizer, Eyal
2017-08-10 7:46 ` Kalle Valo
2017-08-10 7:59 ` Reizer, Eyal
2017-08-10 7:59 ` Reizer, Eyal
2017-08-10 7:52 ` Julian Calaby
2017-08-10 7:56 ` Reizer, Eyal
2017-08-10 7:56 ` Reizer, Eyal
2017-08-10 14:23 ` Reizer, Eyal
2017-08-10 14:23 ` Reizer, Eyal
2017-08-10 17:26 ` Tony Lindgren
2017-08-13 13:07 ` Reizer, Eyal
2017-08-13 13:07 ` Reizer, Eyal
2017-08-09 15:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809152153.GC26708@kroah.com \
--to=greg@kroah.com \
--cc=eyalr@ti.com \
--cc=eyalreizer@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.