All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Reizer, Eyal" <eyalr@ti.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sebastian.reichel@collabora.co.uk"
	<sebastian.reichel@collabora.co.uk>,
	Julian Calaby <julian.calaby@gmail.com>
Subject: Re: [v6] wlcore: add missing nvs file name info for wilink8
Date: Wed, 9 Aug 2017 10:28:26 -0700	[thread overview]
Message-ID: <20170809172826.GB3934@atomide.com> (raw)
In-Reply-To: <20170809172651.GA3934@atomide.com>

* Tony Lindgren <tony@atomide.com> [170809 10:26]:
> * Reizer, Eyal <eyalr@ti.com> [170809 00:55]:
> > --- a/drivers/net/wireless/ti/wlcore/main.c
> > +++ b/drivers/net/wireless/ti/wlcore/main.c
> > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl)
> >  		nic_addr = wl->fuse_nic_addr + 1;
> >  	}
> >  
> > +	if (oui_addr == 0xdeadbe && nic_addr == 0xef0000) {
> > +		wl1271_warning("Detected unconfigured mac address in nvs.\n"
> > +				"derive from fuse instead.\n"
> > +				"in case of using a wl12xx device, your "
> > +				"device performance may not be optimized.\n"
> > +				"Please use the calibrator tool to configure "
> > +				"your device.\n"
> > +				"When using a wl18xx device this default nvs "
> > +				"file can be removed from the file system\n");
> > +
> > +		oui_addr = wl->fuse_oui_addr;
> > +		/* fuse has the BD_ADDR, the WLAN addresses are the next two */
> > +		nic_addr = wl->fuse_nic_addr + 1;
> > +	}
> > +
> >  	wl12xx_derive_mac_addresses(wl, oui_addr, nic_addr);
> 
> I just gave this a quick try on omap3-evm with wl1271, now I get
> mac address of 00:00:00:00:00:01 :) So looks like at least wl1271 needs
> to use the random mac address here.
> 
> Note that we should now have struct wilink_family_data available
> so maybe that can be used to check if the hardware mac address
> exists?

Or actually, in the case where no hardawre mac address exists,
the mac is all zeroes at this point it seems. So maybe that
can be used to determine if a random mac address should be used
here.

Regards,

Tony

  reply	other threads:[~2017-08-09 17:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  7:47 [v6] wlcore: add missing nvs file name info for wilink8 Eyal Reizer
2017-08-09  7:53 ` Reizer, Eyal
2017-08-09  7:53   ` Reizer, Eyal
2017-08-09 17:26   ` Tony Lindgren
2017-08-09 17:28     ` Tony Lindgren [this message]
     [not found]     ` <ngx9scofrw0qb2vkesion8v9.1502300336052@email.android.com>
2017-08-09 21:16       ` Tony Lindgren
2017-08-10  6:35         ` Reizer, Eyal
2017-08-10  6:35           ` Reizer, Eyal
2017-08-10  7:46           ` Kalle Valo
2017-08-10  7:59             ` Reizer, Eyal
2017-08-10  7:59               ` Reizer, Eyal
2017-08-10  7:52           ` Julian Calaby
2017-08-10  7:56             ` Reizer, Eyal
2017-08-10  7:56               ` Reizer, Eyal
2017-08-10 14:23         ` Reizer, Eyal
2017-08-10 14:23           ` Reizer, Eyal
2017-08-10 17:26           ` Tony Lindgren
2017-08-13 13:07             ` Reizer, Eyal
2017-08-13 13:07               ` Reizer, Eyal
2017-08-09 15:21 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809172826.GB3934@atomide.com \
    --to=tony@atomide.com \
    --cc=eyalr@ti.com \
    --cc=julian.calaby@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sebastian.reichel@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.