From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jiri Kosina <jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Srinivas Pandruvada
<srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] hid-sensor-hub: Force logical minimum to 1 for power and report state
Date: Wed, 9 Aug 2017 15:34:09 +0100 [thread overview]
Message-ID: <20170809153349.57ab4d9f@archlinux> (raw)
In-Reply-To: <alpine.LSU.2.20.1708081026200.30597-YHPUNQjx9ReKbouaWp301Q@public.gmane.org>
On Tue, 8 Aug 2017 10:26:58 +0200 (CEST)
Jiri Kosina <jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Sun, 6 Aug 2017, Srinivas Pandruvada wrote:
>
> > In the reference HID sensor hub firmware all Named array enums were
> > 0-based. There is no description of the default base of enums in HID
> > sensor hub specification as logical minimum should have set this base
> > value.
> >
> > Every sensor hub implemented enum as 1-based, without explicitly setting
> > logical minimum to 1, because of the implementation by one of the major
> > OS vendor. In Linux we used logical minimum to decide the enum base.
> >
> > Some sensor hub FWs already changed logical minimum from 0 to 1. We hoped
> > that every other vendor will follow. But that didn't happen and we had to
> > fix the report header for every sensor hub to change logical minimum to 1
> > by using .report_fixup() callback. So for every new sensor hub we had to
> > modify source code by adding this quirk based on the vendor and device id.
> > This is becoming a maintenance burden.
> >
> > This patch hardcodes the logical minimum of power and report state
> > attributes to 1. In this way we can remove the existing quirks and also
> > we don't have to add more quirks.
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> Jonathan, are you ok with me taking this through hid.git? Thanks,
>
Sure,
Acked-by: Jonathan Cameron <Jonathan.Cameron-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] hid-sensor-hub: Force logical minimum to 1 for power and report state
Date: Wed, 9 Aug 2017 15:34:09 +0100 [thread overview]
Message-ID: <20170809153349.57ab4d9f@archlinux> (raw)
In-Reply-To: <alpine.LSU.2.20.1708081026200.30597@cbobk.fhfr.pm>
On Tue, 8 Aug 2017 10:26:58 +0200 (CEST)
Jiri Kosina <jikos@kernel.org> wrote:
> On Sun, 6 Aug 2017, Srinivas Pandruvada wrote:
>
> > In the reference HID sensor hub firmware all Named array enums were
> > 0-based. There is no description of the default base of enums in HID
> > sensor hub specification as logical minimum should have set this base
> > value.
> >
> > Every sensor hub implemented enum as 1-based, without explicitly setting
> > logical minimum to 1, because of the implementation by one of the major
> > OS vendor. In Linux we used logical minimum to decide the enum base.
> >
> > Some sensor hub FWs already changed logical minimum from 0 to 1. We hoped
> > that every other vendor will follow. But that didn't happen and we had to
> > fix the report header for every sensor hub to change logical minimum to 1
> > by using .report_fixup() callback. So for every new sensor hub we had to
> > modify source code by adding this quirk based on the vendor and device id.
> > This is becoming a maintenance burden.
> >
> > This patch hardcodes the logical minimum of power and report state
> > attributes to 1. In this way we can remove the existing quirks and also
> > we don't have to add more quirks.
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> Jonathan, are you ok with me taking this through hid.git? Thanks,
>
Sure,
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2017-08-09 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 4:52 [PATCH] hid-sensor-hub: Force logical minimum to 1 for power and report state Srinivas Pandruvada
[not found] ` <20170807045201.3286-1-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-08 8:26 ` Jiri Kosina
2017-08-08 8:26 ` Jiri Kosina
[not found] ` <alpine.LSU.2.20.1708081026200.30597-YHPUNQjx9ReKbouaWp301Q@public.gmane.org>
2017-08-09 14:34 ` Jonathan Cameron [this message]
2017-08-09 14:34 ` Jonathan Cameron
2017-08-09 20:17 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809153349.57ab4d9f@archlinux \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.