From: Brian Norris <briannorris@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Jeffy Chen <jeffy.chen@rock-chips.com>
Subject: Re: [PATCH] drm/rockchip: Skip suspend/resume if no display is attached
Date: Wed, 9 Aug 2017 16:50:43 -0700 [thread overview]
Message-ID: <20170809235041.GA32566@google.com> (raw)
In-Reply-To: <20170809230724.113819-1-mka@chromium.org>
On Wed, Aug 09, 2017 at 04:07:24PM -0700, Matthias Kaehlcke wrote:
> rockchip_drm_sys_suspend/resume() obains a struct drm_device pointer
> from drvdata, the pointer is then dereferenced to obtain private data.
> drvdata is set when a display is bound, on systems without a
> (successfully probed) display drvdata is NULL and the PM functions
> try to dereference a NULL pointer.
>
> The suspend/resume code relies on a valid drm_device object, skip it if
> the pointer is NULL.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
For the record (I believe you found this already), Jeffy sent the same
patch out (to the wrong mailing lists), but it got applied a bit ago:
https://cgit.freedesktop.org/drm/drm-misc/log/?h=drm-misc-fixes
commit 0fa375e6bc9023211eead30a6a79963c45a563da
drm/rockchip: Fix suspend crash when drm is not bound
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=0fa375e6bc9023211eead30a6a79963c45a563da
Thanks,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: Skip suspend/resume if no display is attached
Date: Wed, 9 Aug 2017 16:50:43 -0700 [thread overview]
Message-ID: <20170809235041.GA32566@google.com> (raw)
In-Reply-To: <20170809230724.113819-1-mka@chromium.org>
On Wed, Aug 09, 2017 at 04:07:24PM -0700, Matthias Kaehlcke wrote:
> rockchip_drm_sys_suspend/resume() obains a struct drm_device pointer
> from drvdata, the pointer is then dereferenced to obtain private data.
> drvdata is set when a display is bound, on systems without a
> (successfully probed) display drvdata is NULL and the PM functions
> try to dereference a NULL pointer.
>
> The suspend/resume code relies on a valid drm_device object, skip it if
> the pointer is NULL.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
For the record (I believe you found this already), Jeffy sent the same
patch out (to the wrong mailing lists), but it got applied a bit ago:
https://cgit.freedesktop.org/drm/drm-misc/log/?h=drm-misc-fixes
commit 0fa375e6bc9023211eead30a6a79963c45a563da
drm/rockchip: Fix suspend crash when drm is not bound
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=0fa375e6bc9023211eead30a6a79963c45a563da
Thanks,
Brian
next prev parent reply other threads:[~2017-08-09 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 23:07 [PATCH] drm/rockchip: Skip suspend/resume if no display is attached Matthias Kaehlcke
2017-08-09 23:07 ` Matthias Kaehlcke
2017-08-09 23:07 ` Matthias Kaehlcke
2017-08-09 23:50 ` Brian Norris [this message]
2017-08-09 23:50 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809235041.GA32566@google.com \
--to=briannorris@chromium.org \
--cc=airlied@linux.ie \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.