From: Will Deacon <will.deacon at arm.com>
To: devel@acpica.org
Subject: Re: [Devel] [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801
Date: Thu, 10 Aug 2017 18:27:23 +0100 [thread overview]
Message-ID: <20170810172723.GD9980@arm.com> (raw)
In-Reply-To: 20170809100715.870516-4-shameerali.kolothum.thodi@huawei.com
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On Wed, Aug 09, 2017 at 11:07:15AM +0100, Shameer Kolothum wrote:
> The HiSilicon erratum 161010801 describes the limitation of HiSilicon
> platforms Hip06/Hip07 to support the SMMU mappings for MSI transactions.
>
> On these platforms GICv3 ITS translator is presented with the deviceID
> by extending the MSI payload data to 64 bits to include the deviceID.
> Hence, the PCIe controller on this platforms has to differentiate the
> MSI payload against other DMA payload and has to modify the MSI payload.
> This basically makes it difficult for this platforms to have a SMMU
> translation for MSI.
>
> This patch implements a ACPI table based quirk to reserve the hw msi
> regions in the smmu-v3 driver which means these address regions will
> not be translated and will be excluded from iova allocations.
>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi(a)huawei.com>
> ---
> drivers/iommu/arm-smmu-v3.c | 27 ++++++++++++++++++++++-----
> 1 file changed, 22 insertions(+), 5 deletions(-)
Please can you also add a devicetree binding with corresponding
documentation to enable this workaround on non-ACPI based systems too? It
should be straightforward if you update the arm_smmu_options table.
Thanks,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Shameer Kolothum
<shameerali.kolothum.thodi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: gabriele.paoloni-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
marc.zyngier-5wv7dgnIgG8@public.gmane.org,
guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
sudeep.holla-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devel-E0kO6a4B6psdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801
Date: Thu, 10 Aug 2017 18:27:23 +0100 [thread overview]
Message-ID: <20170810172723.GD9980@arm.com> (raw)
In-Reply-To: <20170809100715.870516-4-shameerali.kolothum.thodi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Wed, Aug 09, 2017 at 11:07:15AM +0100, Shameer Kolothum wrote:
> The HiSilicon erratum 161010801 describes the limitation of HiSilicon
> platforms Hip06/Hip07 to support the SMMU mappings for MSI transactions.
>
> On these platforms GICv3 ITS translator is presented with the deviceID
> by extending the MSI payload data to 64 bits to include the deviceID.
> Hence, the PCIe controller on this platforms has to differentiate the
> MSI payload against other DMA payload and has to modify the MSI payload.
> This basically makes it difficult for this platforms to have a SMMU
> translation for MSI.
>
> This patch implements a ACPI table based quirk to reserve the hw msi
> regions in the smmu-v3 driver which means these address regions will
> not be translated and will be excluded from iova allocations.
>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/iommu/arm-smmu-v3.c | 27 ++++++++++++++++++++++-----
> 1 file changed, 22 insertions(+), 5 deletions(-)
Please can you also add a devicetree binding with corresponding
documentation to enable this workaround on non-ACPI based systems too? It
should be straightforward if you update the arm_smmu_options table.
Thanks,
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801
Date: Thu, 10 Aug 2017 18:27:23 +0100 [thread overview]
Message-ID: <20170810172723.GD9980@arm.com> (raw)
In-Reply-To: <20170809100715.870516-4-shameerali.kolothum.thodi@huawei.com>
On Wed, Aug 09, 2017 at 11:07:15AM +0100, Shameer Kolothum wrote:
> The HiSilicon erratum 161010801 describes the limitation of HiSilicon
> platforms Hip06/Hip07 to support the SMMU mappings for MSI transactions.
>
> On these platforms GICv3 ITS translator is presented with the deviceID
> by extending the MSI payload data to 64 bits to include the deviceID.
> Hence, the PCIe controller on this platforms has to differentiate the
> MSI payload against other DMA payload and has to modify the MSI payload.
> This basically makes it difficult for this platforms to have a SMMU
> translation for MSI.
>
> This patch implements a ACPI table based quirk to reserve the hw msi
> regions in the smmu-v3 driver which means these address regions will
> not be translated and will be excluded from iova allocations.
>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> ---
> drivers/iommu/arm-smmu-v3.c | 27 ++++++++++++++++++++++-----
> 1 file changed, 22 insertions(+), 5 deletions(-)
Please can you also add a devicetree binding with corresponding
documentation to enable this workaround on non-ACPI based systems too? It
should be straightforward if you update the arm_smmu_options table.
Thanks,
Will
next reply other threads:[~2017-08-10 17:27 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:27 Will Deacon [this message]
2017-08-10 17:27 ` [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801 Will Deacon
2017-08-10 17:27 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2017-09-07 9:54 [Devel] " Lorenzo Pieralisi
2017-09-07 9:54 ` Lorenzo Pieralisi
2017-09-07 9:54 ` Lorenzo Pieralisi
2017-09-05 11:07 [Devel] " John Garry
2017-09-05 11:07 ` John Garry
2017-09-05 11:07 ` John Garry
2017-09-04 17:09 [Devel] " Lorenzo Pieralisi
2017-09-04 17:09 ` Lorenzo Pieralisi
2017-09-04 17:09 ` Lorenzo Pieralisi
2017-09-01 8:46 [Devel] " John Garry
2017-09-01 8:46 ` John Garry
2017-09-01 8:46 ` John Garry
2017-08-24 15:01 [Devel] " John Garry
2017-08-24 15:01 ` John Garry
2017-08-24 15:01 ` John Garry
2017-08-24 14:35 [Devel] " Will Deacon
2017-08-24 14:35 ` Will Deacon
2017-08-24 14:35 ` Will Deacon
2017-08-23 16:55 [Devel] " John Garry
2017-08-23 16:55 ` John Garry
2017-08-23 16:55 ` John Garry
2017-08-23 16:43 [Devel] " Will Deacon
2017-08-23 16:43 ` Will Deacon
2017-08-23 16:43 ` Will Deacon
2017-08-23 14:29 [Devel] " John Garry
2017-08-23 14:29 ` John Garry
2017-08-23 14:29 ` John Garry
2017-08-23 13:24 [Devel] " Will Deacon
2017-08-23 13:24 ` Will Deacon
2017-08-23 13:24 ` Will Deacon
2017-08-23 13:17 [Devel] " John Garry
2017-08-23 13:17 ` John Garry
2017-08-23 13:17 ` John Garry
2017-08-10 17:52 [Devel] " Shameerali Kolothum Thodi
2017-08-10 17:52 ` Shameerali Kolothum Thodi
2017-08-10 17:52 ` Shameerali Kolothum Thodi
2017-08-09 10:07 [Devel] " Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 [Devel] [PATCH v6 2/3] iommu/dma: Add a helper function to reserve HW MSI address regions for IOMMU drivers Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 [Devel] [PATCH v6 1/3] ACPI/IORT: Add ITS address regions reservation helper Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 [Devel] [PATCH v6 0/3] iommu/smmu-v3: Workaround for hisilicon 161010801 erratum(reserve HW MSI) Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
2017-08-09 10:07 ` Shameer Kolothum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810172723.GD9980@arm.com \
--to=devel@acpica.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.