* [RESEND] arm64: dts: ls1088a: Added dcfg node in ls1088a dtsi
@ 2017-08-11 9:19 Ashish Kumar
[not found] ` <1502443177-15479-1-git-send-email-Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
2017-08-14 1:37 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Ashish Kumar @ 2017-08-11 9:19 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: leoyang.li-3arQi8VN3Tc,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Ashish Kumar,
Amrita Kumari
Add debug configuration node(DCFG) in dtsi, helps guts driver to
print the following information in kernel boot log
[ 0.526649] Machine: LS1088A RDB Board
[ 0.530430] SoC family: QorIQ LS1088A
[ 0.534115] SoC ID: svr:0x87030010, Revision: 1.0
Signed-off-by: Amrita Kumari <amrita.kumari-3arQi8VN3Tc@public.gmane.org>
Signed-off-by: Ashish Kumar <Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 6 ++++++
drivers/soc/fsl/guts.c | 1 +
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index c144d06..b5f2372 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -156,6 +156,12 @@
clocks = <&sysclk>;
};
+ dcfg: dcfg@1e00000 {
+ compatible = "fsl,ls1088a-dcfg", "syscon";
+ reg = <0x0 0x1e00000 0x0 0x10000>;
+ little-endian;
+ };
+
tmu: tmu@1f80000 {
compatible = "fsl,qoriq-tmu";
reg = <0x0 0x1f80000 0x0 0x10000>;
diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
index 6af7a11..d89a6a8 100644
--- a/drivers/soc/fsl/guts.c
+++ b/drivers/soc/fsl/guts.c
@@ -213,6 +213,7 @@ static int fsl_guts_remove(struct platform_device *dev)
{ .compatible = "fsl,ls1021a-dcfg", },
{ .compatible = "fsl,ls1043a-dcfg", },
{ .compatible = "fsl,ls2080a-dcfg", },
+ { .compatible = "fsl,ls1088a-dcfg", },
{}
};
MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
--
1.7.6.GIT
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND] arm64: dts: ls1088: Correction in Board name from "L1088A" to "LS1088A"
[not found] ` <1502443177-15479-1-git-send-email-Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
@ 2017-08-11 9:19 ` Ashish Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Ashish Kumar @ 2017-08-11 9:19 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: leoyang.li-3arQi8VN3Tc,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Ashish Kumar
Signed-off-by: Ashish Kumar <Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
index 213abb7..0f6fcda 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
@@ -49,7 +49,7 @@
#include "fsl-ls1088a.dtsi"
/ {
- model = "L1088A RDB Board";
+ model = "LS1088A RDB Board";
compatible = "fsl,ls1088a-rdb", "fsl,ls1088a";
};
--
1.7.6.GIT
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND] arm64: dts: ls1088a: Added dcfg node in ls1088a dtsi
[not found] ` <1502443177-15479-1-git-send-email-Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
@ 2017-08-14 1:37 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2017-08-14 1:37 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 11, 2017 at 02:49:36PM +0530, Ashish Kumar wrote:
> Add debug configuration node(DCFG) in dtsi, helps guts driver to
> print the following information in kernel boot log
>
> [ 0.526649] Machine: LS1088A RDB Board
> [ 0.530430] SoC family: QorIQ LS1088A
> [ 0.534115] SoC ID: svr:0x87030010, Revision: 1.0
>
> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
Why resend?
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 6 ++++++
> drivers/soc/fsl/guts.c | 1 +
Do not mix driver code with dts changes. Instead, they should be
separate patches going through different subsystem tree and maintainers.
Send me dts patch only after driver counterpart lands on mainline.
Shawn
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index c144d06..b5f2372 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -156,6 +156,12 @@
> clocks = <&sysclk>;
> };
>
> + dcfg: dcfg at 1e00000 {
> + compatible = "fsl,ls1088a-dcfg", "syscon";
> + reg = <0x0 0x1e00000 0x0 0x10000>;
> + little-endian;
> + };
> +
> tmu: tmu at 1f80000 {
> compatible = "fsl,qoriq-tmu";
> reg = <0x0 0x1f80000 0x0 0x10000>;
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
> index 6af7a11..d89a6a8 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -213,6 +213,7 @@ static int fsl_guts_remove(struct platform_device *dev)
> { .compatible = "fsl,ls1021a-dcfg", },
> { .compatible = "fsl,ls1043a-dcfg", },
> { .compatible = "fsl,ls2080a-dcfg", },
> + { .compatible = "fsl,ls1088a-dcfg", },
> {}
> };
> MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
> --
> 1.7.6.GIT
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND] arm64: dts: ls1088a: Added dcfg node in ls1088a dtsi
@ 2017-08-14 1:37 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2017-08-14 1:37 UTC (permalink / raw)
To: Ashish Kumar
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, leoyang.li-3arQi8VN3Tc,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Amrita Kumari
On Fri, Aug 11, 2017 at 02:49:36PM +0530, Ashish Kumar wrote:
> Add debug configuration node(DCFG) in dtsi, helps guts driver to
> print the following information in kernel boot log
>
> [ 0.526649] Machine: LS1088A RDB Board
> [ 0.530430] SoC family: QorIQ LS1088A
> [ 0.534115] SoC ID: svr:0x87030010, Revision: 1.0
>
> Signed-off-by: Amrita Kumari <amrita.kumari-3arQi8VN3Tc@public.gmane.org>
> Signed-off-by: Ashish Kumar <Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
Why resend?
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 6 ++++++
> drivers/soc/fsl/guts.c | 1 +
Do not mix driver code with dts changes. Instead, they should be
separate patches going through different subsystem tree and maintainers.
Send me dts patch only after driver counterpart lands on mainline.
Shawn
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index c144d06..b5f2372 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -156,6 +156,12 @@
> clocks = <&sysclk>;
> };
>
> + dcfg: dcfg@1e00000 {
> + compatible = "fsl,ls1088a-dcfg", "syscon";
> + reg = <0x0 0x1e00000 0x0 0x10000>;
> + little-endian;
> + };
> +
> tmu: tmu@1f80000 {
> compatible = "fsl,qoriq-tmu";
> reg = <0x0 0x1f80000 0x0 0x10000>;
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
> index 6af7a11..d89a6a8 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -213,6 +213,7 @@ static int fsl_guts_remove(struct platform_device *dev)
> { .compatible = "fsl,ls1021a-dcfg", },
> { .compatible = "fsl,ls1043a-dcfg", },
> { .compatible = "fsl,ls2080a-dcfg", },
> + { .compatible = "fsl,ls1088a-dcfg", },
> {}
> };
> MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
> --
> 1.7.6.GIT
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-14 1:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 9:19 [RESEND] arm64: dts: ls1088a: Added dcfg node in ls1088a dtsi Ashish Kumar
[not found] ` <1502443177-15479-1-git-send-email-Ashish.Kumar-3arQi8VN3Tc@public.gmane.org>
2017-08-11 9:19 ` [RESEND] arm64: dts: ls1088: Correction in Board name from "L1088A" to "LS1088A" Ashish Kumar
2017-08-14 1:37 ` [RESEND] arm64: dts: ls1088a: Added dcfg node in ls1088a dtsi Shawn Guo
2017-08-14 1:37 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.