All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.vnet.ibm.com>
To: cohuck@redhat.com, thuth@redhat.com
Cc: borntraeger@de.ibm.com, agraf@suse.de, qemu-devel@nongnu.org,
	Eric Farman <farman@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 1/1] pc-bios/s390-ccw: Use rm command during make clean
Date: Mon, 14 Aug 2017 22:44:50 +0200	[thread overview]
Message-ID: <20170814204450.24118-2-farman@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170814204450.24118-1-farman@linux.vnet.ibm.com>

This reverts what I think was an accidental change that replaced
the "rm -f" command with an undefined variable RM, and causes the
"make clean" command to fail for a s390 target:

make[1]: Entering directory '/usr/src/qemu/build/pc-bios/s390-ccw'
rm -f *.timestamp
*.o *.d *.img *.elf *~ *.a
/bin/sh: *.o: command not found
Makefile:39: recipe for target 'clean' failed
make[1]: *** [clean] Error 127
make[1]: Leaving directory '/usr/src/qemu/build/pc-bios/s390-ccw'
Makefile:489: recipe for target 'clean' failed
make: *** [clean] Error 1

Fixes: 3e4415a751d2 ("pc-bios/s390-ccw: Add core files for the network
                      bootloading program")
Signed-off-by: Eric Farman <farman@linux.vnet.ibm.com>
---
 pc-bios/s390-ccw/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
index cbae74522a..6d0c2ee691 100644
--- a/pc-bios/s390-ccw/Makefile
+++ b/pc-bios/s390-ccw/Makefile
@@ -36,4 +36,4 @@ s390-netboot.img:
 endif
 
 clean:
-	$(RM) *.o *.d *.img *.elf *~ *.a
+	rm -f *.o *.d *.img *.elf *~ *.a
-- 
2.11.2

  reply	other threads:[~2017-08-14 20:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 20:44 [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target Eric Farman
2017-08-14 20:44 ` Eric Farman [this message]
2017-08-15  7:23   ` [Qemu-devel] [PATCH 1/1] pc-bios/s390-ccw: Use rm command during make clean Cornelia Huck
2017-08-15  5:02 ` [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target Thomas Huth
2017-08-15  7:03   ` Cornelia Huck
2017-08-15  8:01     ` Thomas Huth
2017-08-15  8:26       ` Thomas Huth
2017-08-15  8:32         ` Cornelia Huck
2017-08-15  8:39           ` Thomas Huth
2017-08-15 10:27         ` Eric Farman
2017-08-15 10:00 ` Peter Maydell
2017-08-15 11:07   ` Cornelia Huck
2017-08-15 11:10     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814204450.24118-2-farman@linux.vnet.ibm.com \
    --to=farman@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.