From: Guenter Roeck <linux@roeck-us.net>
To: linux-aspeed@lists.ozlabs.org
Subject: [1/2] dt-bindings: watchdog: aspeed: External reset signal properties
Date: Mon, 14 Aug 2017 19:20:57 -0700 [thread overview]
Message-ID: <20170815022057.GA2172@roeck-us.net> (raw)
In-Reply-To: <20170802044529.30032-2-andrew@aj.id.au>
On Wed, Aug 02, 2017 at 02:15:28PM +0930, Andrew Jeffery wrote:
> For the AST2500 and compatible watchdog controllers the external reset
> signal can be configured for push-pull or open-drain drive types, and in
> the case of push-pull driving, active low or high.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> index 2b34ce9b60b9..c5077a1f5cb3 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> @@ -33,10 +33,18 @@ Optional properties:
> - none: No reset is performed on timeout. Assumes another watchdog
> engine is responsible for this.
>
> + - aspeed,alt-boot: If property is present then boot from alternate block.
> - aspeed,external-signal: If property is present then signal is sent to
> external reset counter (only WDT1 and WDT2). If not
> specified no external signal is sent.
> - - aspeed,alt-boot: If property is present then boot from alternate block.
> + - aspeed,ext-pulse-duration: External signal pulse duration in microseconds
> +
> +Optional properties for AST2500-compatible watchdogs:
> + - aspeed,ext-push-pull: If aspeed,external-signal is present, set the pin's
> + drive type to push-pull. The default is open-drain.
> + - aspeed,ext-active-high: If aspeed,external-signal is present and and the pin
> + is configured as push-pull, then set the pulse
> + polarity to active-high. The default is active-low.
>
> Example:
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be,
robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org
Subject: Re: [1/2] dt-bindings: watchdog: aspeed: External reset signal properties
Date: Mon, 14 Aug 2017 19:20:57 -0700 [thread overview]
Message-ID: <20170815022057.GA2172@roeck-us.net> (raw)
In-Reply-To: <20170802044529.30032-2-andrew@aj.id.au>
On Wed, Aug 02, 2017 at 02:15:28PM +0930, Andrew Jeffery wrote:
> For the AST2500 and compatible watchdog controllers the external reset
> signal can be configured for push-pull or open-drain drive types, and in
> the case of push-pull driving, active low or high.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> index 2b34ce9b60b9..c5077a1f5cb3 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> @@ -33,10 +33,18 @@ Optional properties:
> - none: No reset is performed on timeout. Assumes another watchdog
> engine is responsible for this.
>
> + - aspeed,alt-boot: If property is present then boot from alternate block.
> - aspeed,external-signal: If property is present then signal is sent to
> external reset counter (only WDT1 and WDT2). If not
> specified no external signal is sent.
> - - aspeed,alt-boot: If property is present then boot from alternate block.
> + - aspeed,ext-pulse-duration: External signal pulse duration in microseconds
> +
> +Optional properties for AST2500-compatible watchdogs:
> + - aspeed,ext-push-pull: If aspeed,external-signal is present, set the pin's
> + drive type to push-pull. The default is open-drain.
> + - aspeed,ext-active-high: If aspeed,external-signal is present and and the pin
> + is configured as push-pull, then set the pulse
> + polarity to active-high. The default is active-low.
>
> Example:
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Andrew Jeffery <andrew-zrmu5oMJ5Fs@public.gmane.org>
Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-aspeed-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [1/2] dt-bindings: watchdog: aspeed: External reset signal properties
Date: Mon, 14 Aug 2017 19:20:57 -0700 [thread overview]
Message-ID: <20170815022057.GA2172@roeck-us.net> (raw)
In-Reply-To: <20170802044529.30032-2-andrew-zrmu5oMJ5Fs@public.gmane.org>
On Wed, Aug 02, 2017 at 02:15:28PM +0930, Andrew Jeffery wrote:
> For the AST2500 and compatible watchdog controllers the external reset
> signal can be configured for push-pull or open-drain drive types, and in
> the case of push-pull driving, active low or high.
>
> Signed-off-by: Andrew Jeffery <andrew-zrmu5oMJ5Fs@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Reviewed-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> index 2b34ce9b60b9..c5077a1f5cb3 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> @@ -33,10 +33,18 @@ Optional properties:
> - none: No reset is performed on timeout. Assumes another watchdog
> engine is responsible for this.
>
> + - aspeed,alt-boot: If property is present then boot from alternate block.
> - aspeed,external-signal: If property is present then signal is sent to
> external reset counter (only WDT1 and WDT2). If not
> specified no external signal is sent.
> - - aspeed,alt-boot: If property is present then boot from alternate block.
> + - aspeed,ext-pulse-duration: External signal pulse duration in microseconds
> +
> +Optional properties for AST2500-compatible watchdogs:
> + - aspeed,ext-push-pull: If aspeed,external-signal is present, set the pin's
> + drive type to push-pull. The default is open-drain.
> + - aspeed,ext-active-high: If aspeed,external-signal is present and and the pin
> + is configured as push-pull, then set the pulse
> + polarity to active-high. The default is active-low.
>
> Example:
>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-15 2:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 4:45 [PATCH 0/2] watchdog: aspeed: External reset signal properties Andrew Jeffery
2017-08-02 4:45 ` Andrew Jeffery
2017-08-02 4:45 ` [PATCH 1/2] dt-bindings: " Andrew Jeffery
2017-08-02 4:45 ` Andrew Jeffery
2017-08-02 4:45 ` Andrew Jeffery
2017-08-10 15:45 ` Rob Herring
2017-08-10 15:45 ` Rob Herring
2017-08-10 15:45 ` Rob Herring
2017-08-15 2:20 ` Guenter Roeck [this message]
2017-08-15 2:20 ` [1/2] " Guenter Roeck
2017-08-15 2:20 ` Guenter Roeck
2017-08-02 4:45 ` [PATCH 2/2] watchdog: aspeed: Support configuration of external " Andrew Jeffery
2017-08-02 4:45 ` Andrew Jeffery
2017-08-02 4:45 ` Andrew Jeffery
2017-08-15 2:21 ` [2/2] " Guenter Roeck
2017-08-15 2:21 ` Guenter Roeck
2017-08-15 2:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815022057.GA2172@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.