From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path()
Date: Thu, 17 Aug 2017 15:47:52 +0000 [thread overview]
Message-ID: <20170817154752.GA18912@kroah.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1708141559060.14369@casper.infradead.org>
On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote:
>
> > We want to concatonate join string one, a '/' character, string two and
> > then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen
> > characters. The strlen() function returns the number of characters not
> > counting the NUL terminator. So we should be adding two extra spaces,
> > one for the foward slash and one for the NUL.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Not tested. Please review this one carefully.
>
> This is a real bug which is impacting users. The bug is being tracked
> at https://jira.hpdd.intel.com/browse/LU-9863. It passed our test suite
> and its being reviewed.
So what am I supposed to do with this patch?
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path()
Date: Thu, 17 Aug 2017 08:47:52 -0700 [thread overview]
Message-ID: <20170817154752.GA18912@kroah.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1708141559060.14369@casper.infradead.org>
On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote:
>
> > We want to concatonate join string one, a '/' character, string two and
> > then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen
> > characters. The strlen() function returns the number of characters not
> > counting the NUL terminator. So we should be adding two extra spaces,
> > one for the foward slash and one for the NUL.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Not tested. Please review this one carefully.
>
> This is a real bug which is impacting users. The bug is being tracked
> at https://jira.hpdd.intel.com/browse/LU-9863. It passed our test suite
> and its being reviewed.
So what am I supposed to do with this patch?
next prev parent reply other threads:[~2017-08-17 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 14:42 [PATCH] staging: lustre: lustre: Off by two in lmv_fid2path() Dan Carpenter
2017-07-28 14:42 ` [lustre-devel] " Dan Carpenter
2017-08-14 15:01 ` James Simmons
2017-08-14 15:01 ` [lustre-devel] " James Simmons
2017-08-17 15:47 ` Greg Kroah-Hartman [this message]
2017-08-17 15:47 ` Greg Kroah-Hartman
2017-08-19 0:07 ` Dilger, Andreas
2017-08-19 0:07 ` [lustre-devel] " Dilger, Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817154752.GA18912@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.