All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devel@driverdev.osuosl.org, laurent.pinchart@ideasonboard.com,
	viresh.kumar@linaro.org, Johan Hovold <johan@kernel.org>,
	greybus-dev@lists.linaro.org, jacek.anaszewski@gmail.com,
	linux-leds@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3.2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators
Date: Thu, 17 Aug 2017 11:13:10 -0700	[thread overview]
Message-ID: <20170817181310.GA4227@kroah.com> (raw)
In-Reply-To: <20170815112811.17212-1-sakari.ailus@linux.intel.com>

On Tue, Aug 15, 2017 at 02:28:11PM +0300, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED specific associations. Essentially, the original assumption of a
> LED driver chip that drives a single flash LED and an indicator LED is no
> longer valid.
> 
> Address the matter by registering one sub-device per LED.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com> (for greybus/light)
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> since v3.2:

"3.2"?

Isn't that just "v5"?  Please don't be cute with version numbering, we
have a hard time telling what is going on, make it obvious...

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	Johan Hovold <johan@kernel.org>,
	greybus-dev@lists.linaro.org, jacek.anaszewski@gmail.com,
	viresh.kumar@linaro.org, linux-leds@vger.kernel.org,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v3.2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators
Date: Thu, 17 Aug 2017 11:13:10 -0700	[thread overview]
Message-ID: <20170817181310.GA4227@kroah.com> (raw)
In-Reply-To: <20170815112811.17212-1-sakari.ailus@linux.intel.com>

On Tue, Aug 15, 2017 at 02:28:11PM +0300, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED specific associations. Essentially, the original assumption of a
> LED driver chip that drives a single flash LED and an indicator LED is no
> longer valid.
> 
> Address the matter by registering one sub-device per LED.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com> (for greybus/light)
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> since v3.2:

"3.2"?

Isn't that just "v5"?  Please don't be cute with version numbering, we
have a hard time telling what is going on, make it obvious...

thanks,

greg k-h

  reply	other threads:[~2017-08-17 18:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 15:49 [PATCH v3 0/3] Create sub-device per LED Sakari Ailus
2017-08-10 15:49 ` [PATCH v3 1/3] staging: greybus: light: fix memory leak in v4l2 register Sakari Ailus
2017-08-17 18:14   ` Greg Kroah-Hartman
2017-08-17 18:14     ` Greg Kroah-Hartman
2017-08-10 15:49 ` [PATCH v3 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators Sakari Ailus
2017-08-10 15:49   ` Sakari Ailus
2017-08-15 10:41   ` [PATCH v3.1 " Sakari Ailus
2017-08-15 11:28   ` [PATCH v3.2 " Sakari Ailus
2017-08-17 18:13     ` Greg Kroah-Hartman [this message]
2017-08-17 18:13       ` Greg Kroah-Hartman
2017-08-10 15:49 ` [PATCH v3 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817181310.GA4227@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=johan@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.