All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-clk@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] usb: dwc3: of-simple: remove include of clk-provider.h
Date: Thu, 17 Aug 2017 14:06:30 -0700	[thread overview]
Message-ID: <20170817210630.GH2146@codeaurora.org> (raw)
In-Reply-To: <1502634071-2266-1-git-send-email-shawnguo@kernel.org>

On 08/13, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
> 
> The header clk-provider.h is there for clock drivers (providers) to
> include, not client drivers (consumers).  That said,
> of_clk_get_parent_count() is a helper function for clock providers, not
> a clk API for consumers.
> 
> Let's replace of_clk_get_parent_count() with of_count_phandle_with_args()
> call, so that we can remove the include of clk-provider.h.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc3: of-simple: remove include of clk-provider.h
Date: Thu, 17 Aug 2017 14:06:30 -0700	[thread overview]
Message-ID: <20170817210630.GH2146@codeaurora.org> (raw)
In-Reply-To: <1502634071-2266-1-git-send-email-shawnguo@kernel.org>

On 08/13, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@linaro.org>
> 
> The header clk-provider.h is there for clock drivers (providers) to
> include, not client drivers (consumers).  That said,
> of_clk_get_parent_count() is a helper function for clock providers, not
> a clk API for consumers.
> 
> Let's replace of_clk_get_parent_count() with of_count_phandle_with_args()
> call, so that we can remove the include of clk-provider.h.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-08-17 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-13 14:21 [PATCH] usb: dwc3: of-simple: remove include of clk-provider.h Shawn Guo
2017-08-13 14:21 ` Shawn Guo
2017-08-17 21:06 ` Stephen Boyd [this message]
2017-08-17 21:06   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817210630.GH2146@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=balbi@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.