From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: ls1088a: Add USB support
Date: Fri, 18 Aug 2017 16:03:57 +0800 [thread overview]
Message-ID: <20170818080355.GK7608@dragon> (raw)
In-Reply-To: <VI1PR04MB1262662395B8CD06BAF074CFE9800@VI1PR04MB1262.eurprd04.prod.outlook.com>
On Fri, Aug 18, 2017 at 07:48:19AM +0000, Yinbo Zhu wrote:
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 3a3be87..0dbff29 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -458,6 +458,24 @@
> > status = "disabled";
> > };
> >
> > + usb0: usb3 at 3100000 {
> > + compatible = "snps,dwc3";
> > + reg = <0x0 0x3100000 0x0 0x10000>;
> > + interrupts = <0 80 0x4>; /* Level high type */
>
> Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment.
>
> > + dr_mode = "host";
> > + configure-gfladj;
>
> What is this? I do not see it in upstream kernel.
>
> > + snps,dis_rxdet_inp3_quirk;
>
> You probably need a "disabled" status.
>
> Shawn
>
> Hi Shawn,
>
> About your description " You probably need a "disabled" status."
> Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it?
> In fact, if remove the property , 1088ardb usb will doesn't detect.
No, that's not what I meant. I meant the USB device should be disabled
by default in <soc>.dtsi by having the following line.
status = "disabled";
And then if your board has the pin-out of this USB device, you have the
line below to turn on the support.
status = "okay";
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yinbo Zhu <yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Harninder Rai <harninder.rai-3arQi8VN3Tc@public.gmane.org>,
Andy Tang <andy.tang-3arQi8VN3Tc@public.gmane.org>,
"open list:" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Ashish Kumar <ashish.kumar-3arQi8VN3Tc@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org"
<linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org>,
Raghav Dogra <raghav.dogra-3arQi8VN3Tc@public.gmane.org>,
"moderated list:"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support
Date: Fri, 18 Aug 2017 16:03:57 +0800 [thread overview]
Message-ID: <20170818080355.GK7608@dragon> (raw)
In-Reply-To: <VI1PR04MB1262662395B8CD06BAF074CFE9800-mr6QIVyDiCGbtYzA8xQqo89NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Fri, Aug 18, 2017 at 07:48:19AM +0000, Yinbo Zhu wrote:
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 3a3be87..0dbff29 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -458,6 +458,24 @@
> > status = "disabled";
> > };
> >
> > + usb0: usb3@3100000 {
> > + compatible = "snps,dwc3";
> > + reg = <0x0 0x3100000 0x0 0x10000>;
> > + interrupts = <0 80 0x4>; /* Level high type */
>
> Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment.
>
> > + dr_mode = "host";
> > + configure-gfladj;
>
> What is this? I do not see it in upstream kernel.
>
> > + snps,dis_rxdet_inp3_quirk;
>
> You probably need a "disabled" status.
>
> Shawn
>
> Hi Shawn,
>
> About your description " You probably need a "disabled" status."
> Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it?
> In fact, if remove the property , 1088ardb usb will doesn't detect.
No, that's not what I meant. I meant the USB device should be disabled
by default in <soc>.dtsi by having the following line.
status = "disabled";
And then if your board has the pin-out of this USB device, you have the
line below to turn on the support.
status = "okay";
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Yinbo Zhu <yinbo.zhu@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Harninder Rai <harninder.rai@nxp.com>,
Andy Tang <andy.tang@nxp.com>,
"open list:" <devicetree@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ashish Kumar <ashish.kumar@nxp.com>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-devel@gforge.freescale.net"
<linux-devel@gforge.freescale.net>,
Raghav Dogra <raghav.dogra@nxp.com>,
"moderated list:" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support
Date: Fri, 18 Aug 2017 16:03:57 +0800 [thread overview]
Message-ID: <20170818080355.GK7608@dragon> (raw)
In-Reply-To: <VI1PR04MB1262662395B8CD06BAF074CFE9800@VI1PR04MB1262.eurprd04.prod.outlook.com>
On Fri, Aug 18, 2017 at 07:48:19AM +0000, Yinbo Zhu wrote:
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 3a3be87..0dbff29 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -458,6 +458,24 @@
> > status = "disabled";
> > };
> >
> > + usb0: usb3@3100000 {
> > + compatible = "snps,dwc3";
> > + reg = <0x0 0x3100000 0x0 0x10000>;
> > + interrupts = <0 80 0x4>; /* Level high type */
>
> Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment.
>
> > + dr_mode = "host";
> > + configure-gfladj;
>
> What is this? I do not see it in upstream kernel.
>
> > + snps,dis_rxdet_inp3_quirk;
>
> You probably need a "disabled" status.
>
> Shawn
>
> Hi Shawn,
>
> About your description " You probably need a "disabled" status."
> Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it?
> In fact, if remove the property , 1088ardb usb will doesn't detect.
No, that's not what I meant. I meant the USB device should be disabled
by default in <soc>.dtsi by having the following line.
status = "disabled";
And then if your board has the pin-out of this USB device, you have the
line below to turn on the support.
status = "okay";
Shawn
next prev parent reply other threads:[~2017-08-18 8:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 2:52 [PATCH] arm64: dts: ls1088a: Add USB support yinbo.zhu at nxp.com
2017-08-17 2:52 ` yinbo.zhu
2017-08-17 2:52 ` yinbo.zhu-3arQi8VN3Tc
2017-08-17 14:02 ` Shawn Guo
2017-08-17 14:02 ` Shawn Guo
2017-08-17 14:02 ` Shawn Guo
2017-08-18 7:48 ` Yinbo Zhu
2017-08-18 7:48 ` Yinbo Zhu
2017-08-18 8:03 ` Shawn Guo [this message]
2017-08-18 8:03 ` Shawn Guo
2017-08-18 8:03 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2017-08-18 8:14 yinbo.zhu at nxp.com
2017-08-18 8:14 ` yinbo.zhu
2017-08-18 8:14 ` yinbo.zhu
2017-08-18 13:02 ` Shawn Guo
2017-08-18 13:02 ` Shawn Guo
2017-08-18 13:02 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818080355.GK7608@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.