From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
linux-arm-kernel@lists.infradead.org,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH 3/3] ARM: OMAP5: Enable CPU off idle states
Date: Fri, 18 Aug 2017 08:26:00 -0700 [thread overview]
Message-ID: <20170818152600.GE6008@atomide.com> (raw)
In-Reply-To: <c31a90c4-8dbe-926a-831c-5fac92ebae80@ti.com>
* Nishanth Menon <nm@ti.com> [170817 18:30]:
> On 08/17/2017 06:01 PM, Tony Lindgren wrote:
> > With the idle code in place needed for supporting off mode for cpus,
> > let's enable it. This seems to save about 0.2W of power compared to
> > CPU retention states based on quick measurement on omap5-uevm.
>
> That makes sense since the Silicon you probably have is pre-production
> silicon.
It seems to be es2.0, the measurement was just based on a glance
of the power supply after rmmod of ehci-omap and ohci-platform
modules.
> unfortunately, you have been looking at some preproduction code which was
> being developed prior to the silicon going into production (also the reason
> why I have'nt upstreamed those changes).
Oh I did not know that, I was just looking at the old
ti-linux-3-8-y-kernel that the igepv5 kernel tree is
based on.
> unfortunately, I have to NAK this patch.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f5dc91b691cf296c49aedf0a671fd659a70f737
> as per Technical Reference Manual SWPU282AF–May 2012–Revised August 2016,
> PM_MPU_PWRSTCTRL can only support: ON INA, RET. (CSWR only).
>
> Same applies to CPUs as well. which was the reason in the first place for me
> to send the patch upstream.
OK, is there some hardware errata issued on that?
I also noticed these patches won't work when booted with LPAE
enabled kernel for some reason.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: OMAP5: Enable CPU off idle states
Date: Fri, 18 Aug 2017 08:26:00 -0700 [thread overview]
Message-ID: <20170818152600.GE6008@atomide.com> (raw)
In-Reply-To: <c31a90c4-8dbe-926a-831c-5fac92ebae80@ti.com>
* Nishanth Menon <nm@ti.com> [170817 18:30]:
> On 08/17/2017 06:01 PM, Tony Lindgren wrote:
> > With the idle code in place needed for supporting off mode for cpus,
> > let's enable it. This seems to save about 0.2W of power compared to
> > CPU retention states based on quick measurement on omap5-uevm.
>
> That makes sense since the Silicon you probably have is pre-production
> silicon.
It seems to be es2.0, the measurement was just based on a glance
of the power supply after rmmod of ehci-omap and ohci-platform
modules.
> unfortunately, you have been looking at some preproduction code which was
> being developed prior to the silicon going into production (also the reason
> why I have'nt upstreamed those changes).
Oh I did not know that, I was just looking at the old
ti-linux-3-8-y-kernel that the igepv5 kernel tree is
based on.
> unfortunately, I have to NAK this patch.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f5dc91b691cf296c49aedf0a671fd659a70f737
> as per Technical Reference Manual SWPU282AF?May 2012?Revised August 2016,
> PM_MPU_PWRSTCTRL can only support: ON INA, RET. (CSWR only).
>
> Same applies to CPUs as well. which was the reason in the first place for me
> to send the patch upstream.
OK, is there some hardware errata issued on that?
I also noticed these patches won't work when booted with LPAE
enabled kernel for some reason.
Regards,
Tony
next prev parent reply other threads:[~2017-08-18 15:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 23:01 [PATCH 0/3] omap5 cpu off mode support Tony Lindgren
2017-08-17 23:01 ` Tony Lindgren
2017-08-17 23:01 ` [PATCH 1/3] ARM: OMAP2+: Separate dra7 cpuidle from omap5 Tony Lindgren
2017-08-17 23:01 ` Tony Lindgren
2017-08-17 23:42 ` Tony Lindgren
2017-08-17 23:42 ` Tony Lindgren
2017-08-17 23:01 ` [PATCH 2/3] ARM: OMAP5: Add cpuidle assembly code Tony Lindgren
2017-08-17 23:01 ` Tony Lindgren
2017-08-18 1:38 ` Nishanth Menon
2017-08-18 1:38 ` Nishanth Menon
2017-08-17 23:01 ` [PATCH 3/3] ARM: OMAP5: Enable CPU off idle states Tony Lindgren
2017-08-17 23:01 ` Tony Lindgren
2017-08-18 1:29 ` Nishanth Menon
2017-08-18 1:29 ` Nishanth Menon
2017-08-18 15:26 ` Tony Lindgren [this message]
2017-08-18 15:26 ` Tony Lindgren
2017-08-18 22:27 ` Nishanth Menon
2017-08-18 22:27 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818152600.GE6008@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=santosh.shilimkar@oracle.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.