From: Eduardo Habkost <ehabkost@redhat.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com, rth@twiddle.net,
anthony.perard@citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen
Date: Fri, 18 Aug 2017 13:38:54 -0300 [thread overview]
Message-ID: <20170818163854.GY3108@localhost.localdomain> (raw)
In-Reply-To: <3ababa62-f055-5bbb-b9b9-c55ada8368dd@intel.com>
On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote:
> On 2017年08月16日 19:21, Paolo Bonzini wrote:
> > On 16/08/2017 02:22, Lan Tianyu wrote:
> >> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU
> >> check for Xen here when vcpu number is more than 255.
> >
> > I think you still need to do a check for vIOMMU being enabled.
>
> Yes, this will be done in the Xen tool stack and Qemu doesn't have such
> knowledge. Operations of create, destroy Xen vIOMMU will be done in the
> Xen tool stack.
Shouldn't we make QEMU have knowledge of the vIOMMU device, then?
Won't QEMU need to know about it eventually?
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org,
xen-devel@lists.xenproject.org, anthony.perard@citrix.com,
Paolo Bonzini <pbonzini@redhat.com>,
rth@twiddle.net
Subject: Re: [PATCH] x86: Skip check apic_id_limit for Xen
Date: Fri, 18 Aug 2017 13:38:54 -0300 [thread overview]
Message-ID: <20170818163854.GY3108@localhost.localdomain> (raw)
In-Reply-To: <3ababa62-f055-5bbb-b9b9-c55ada8368dd@intel.com>
On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote:
> On 2017年08月16日 19:21, Paolo Bonzini wrote:
> > On 16/08/2017 02:22, Lan Tianyu wrote:
> >> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU
> >> check for Xen here when vcpu number is more than 255.
> >
> > I think you still need to do a check for vIOMMU being enabled.
>
> Yes, this will be done in the Xen tool stack and Qemu doesn't have such
> knowledge. Operations of create, destroy Xen vIOMMU will be done in the
> Xen tool stack.
Shouldn't we make QEMU have knowledge of the vIOMMU device, then?
Won't QEMU need to know about it eventually?
--
Eduardo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-18 16:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 0:22 [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen Lan Tianyu
2017-08-16 0:22 ` Lan Tianyu
2017-08-16 11:21 ` [Qemu-devel] " Paolo Bonzini
2017-08-16 11:21 ` Paolo Bonzini
2017-08-17 1:37 ` [Qemu-devel] " Lan Tianyu
2017-08-17 1:37 ` Lan Tianyu
2017-08-18 16:38 ` Eduardo Habkost [this message]
2017-08-18 16:38 ` Eduardo Habkost
2017-08-18 16:53 ` [Qemu-devel] " Paolo Bonzini
2017-08-18 16:53 ` Paolo Bonzini
2017-08-21 2:22 ` [Qemu-devel] " Lan Tianyu
2017-08-21 2:22 ` Lan Tianyu
2017-10-26 12:19 ` [Qemu-devel] " Eduardo Habkost
2017-10-26 12:19 ` Eduardo Habkost
2017-10-26 14:27 ` Michael S. Tsirkin
2017-10-26 14:27 ` Michael S. Tsirkin
2017-10-27 1:30 ` Lan Tianyu
2017-10-27 1:30 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818163854.GY3108@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=tianyu.lan@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.