From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Bruce Rogers <brogers@suse.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp
Date: Fri, 18 Aug 2017 21:32:23 +0300 [thread overview]
Message-ID: <20170818213110-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170818160018.GH1475@perard.uk.xensource.com>
On Fri, Aug 18, 2017 at 05:00:18PM +0100, Anthony PERARD wrote:
> > > > >
> > > > > Clean it up after 2.10.
> > > > >
> > >
> > > So is the v2 good enough or do I need to resend it?
> > Do you really need it in 2.10?
> > it's only 2 days left till release so unless it's blocker
> > I'd wait till after release and do clean fix.
>
> It mostly means that someone building QEMU 2.10 would be unable to do
> PCI passthrough hotplug. But PCI PT works fine when the device is added
> before a guest is started. Maybe hotplug can work as well with extra
> steps done in the guest to force to probe for new devices.
>
> So I would say it is not a blocker, and could be added in the known
> issue of the release notes?
Regressions aren't nice. But risk to working setups isn't nice either.
If you can come up with a patch that obviously limits the effect to xen
only, I'll merge it or ack for merge through Xen tree.
> --
> Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, qemu-devel@nongnu.org,
Eduardo Habkost <ehabkost@redhat.com>,
Bruce Rogers <brogers@suse.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp
Date: Fri, 18 Aug 2017 21:32:23 +0300 [thread overview]
Message-ID: <20170818213110-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170818160018.GH1475@perard.uk.xensource.com>
On Fri, Aug 18, 2017 at 05:00:18PM +0100, Anthony PERARD wrote:
> > > > >
> > > > > Clean it up after 2.10.
> > > > >
> > >
> > > So is the v2 good enough or do I need to resend it?
> > Do you really need it in 2.10?
> > it's only 2 days left till release so unless it's blocker
> > I'd wait till after release and do clean fix.
>
> It mostly means that someone building QEMU 2.10 would be unable to do
> PCI passthrough hotplug. But PCI PT works fine when the device is added
> before a guest is started. Maybe hotplug can work as well with extra
> steps done in the guest to force to probe for new devices.
>
> So I would say it is not a blocker, and could be added in the known
> issue of the release notes?
Regressions aren't nice. But risk to working setups isn't nice either.
If you can come up with a patch that obviously limits the effect to xen
only, I'll merge it or ack for merge through Xen tree.
> --
> Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-18 18:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 16:23 [Qemu-devel] [PATCH for-2.10 v3 0/3] Fix hotplug of PCI passthrought device on Xen Anthony PERARD
2017-08-17 16:23 ` Anthony PERARD
2017-08-17 16:23 ` [Qemu-devel] [PATCH for-2.10 v3 1/3] hw/acpi: Limit hotplug to root bus on legacy mode Anthony PERARD
2017-08-17 16:23 ` Anthony PERARD
2017-08-17 16:23 ` [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp Anthony PERARD
2017-08-17 16:23 ` Anthony PERARD
2017-08-18 1:40 ` [Qemu-devel] " Michael S. Tsirkin
2017-08-18 1:40 ` Michael S. Tsirkin
2017-08-18 9:37 ` [Qemu-devel] " Igor Mammedov
2017-08-18 9:37 ` Igor Mammedov
2017-08-18 13:31 ` [Qemu-devel] " Anthony PERARD
2017-08-18 13:31 ` Anthony PERARD
2017-08-18 14:19 ` [Qemu-devel] " Igor Mammedov
2017-08-18 14:19 ` Igor Mammedov
2017-08-18 16:00 ` [Qemu-devel] " Anthony PERARD
2017-08-18 16:00 ` Anthony PERARD
2017-08-18 18:32 ` Michael S. Tsirkin [this message]
2017-08-18 18:32 ` Michael S. Tsirkin
2017-08-18 18:30 ` [Qemu-devel] " Michael S. Tsirkin
2017-08-18 18:30 ` Michael S. Tsirkin
2017-08-18 9:47 ` [Qemu-devel] " Igor Mammedov
2017-08-18 9:47 ` Igor Mammedov
2017-08-17 16:23 ` [Qemu-devel] [PATCH for-2.10 v3 3/3] Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen" Anthony PERARD
2017-08-17 16:23 ` Anthony PERARD
2017-08-17 16:57 ` [Qemu-devel] [PATCH for-2.10 v3 0/3] Fix hotplug of PCI passthrought device on Xen no-reply
2017-08-17 16:57 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818213110-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=brogers@suse.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.